Re: [PATCH net-next v7 15/15] onsemi: s2500: Added selftest support to onsemi's S2500 driver

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] Returning 0 from `s2500_get_sset_count` for `ETH_SS_TEST` triggers a kernel warning (WARN_ON) in the ethtool core when `CONFIG_NET_SELFTESTS` is disabled.
--

--- Patch [15]: [PATCH net-next v7 15/15] onsemi: s2500: Added selftest support to onsemi's S2500 driver ---
commit 23684bf1f56c19460bcd699584b785e9017d1ddf
Author: Selvamani Rajagopal <Selvamani.Rajagopal@onsemi.com>

onsemi: s2500: Added selftest support to onsemi's S2500 driver

This patch adds selftest support for the onsemi S2500 MAC-PHY driver by
implementing the required ethtool test operations.

> diff --git a/drivers/net/ethernet/onsemi/s2500/s2500_ethtool.c b/drivers/net/ethernet/onsemi/s2500/s2500_ethtool.c
> --- a/drivers/net/ethernet/onsemi/s2500/s2500_ethtool.c
> +++ b/drivers/net/ethernet/onsemi/s2500/s2500_ethtool.c
> @@ -229,6 +230,8 @@ static int s2500_get_sset_count(struct net_device *ndev, int sset)
>  	switch (sset) {
>  	case ETH_SS_STATS:
>  		return S2500_MAC_STATS_LEN;
> +	case ETH_SS_TEST:
> +		return net_selftest_get_count();

[Severity: Medium]
Will this trigger a kernel warning in the ethtool core if CONFIG_NET_SELFTESTS
is disabled?

When CONFIG_NET_SELFTESTS is not enabled, the inline fallback for
net_selftest_get_count() returns 0. If a privileged user runs "ethtool -t",
ethtool_self_test() directly calls get_sset_count(), receives 0, and
triggers a WARN_ON(test_len == 0) assertion.

Should this code check if the returned count is zero and yield -EOPNOTSUPP
instead?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260708-s2500-mac-phy-support-v7-0-478c877aa1a9@onsemi.com?part=15