[PATCH] dt-bindings: arm: qcom,coresight-tpdm: fix bracket

[PATCH] dt-bindings: arm: qcom,coresight-tpdm: fix bracket

[Manuel Ebner]

Add ')' and fix sentence structure.

Signed-off-by: Manuel Ebner <manuelebner@mailbox.org>
---
 .../bindings/clock/renesas,rcar-usb2-clock-sel.yaml           | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/Documentation/devicetree/bindings/clock/renesas,rcar-usb2-clock-sel.yaml b/Documentation/devicetree/bindings/clock/renesas,rcar-usb2-clock-sel.yaml
index c84f29f1810f..a14be249fa33 100644
--- a/Documentation/devicetree/bindings/clock/renesas,rcar-usb2-clock-sel.yaml
+++ b/Documentation/devicetree/bindings/clock/renesas,rcar-usb2-clock-sel.yaml
@@ -13,8 +13,8 @@ description: |
   If you connect an external clock to the USB_EXTAL pin only, you should set
   the clock rate to "usb_extal" node only.
   If you connect an oscillator to both the USB_XTAL and USB_EXTAL, this module
-  is not needed because this is default setting. (Of course, you can set the
-  clock rates to both "usb_extal" and "usb_xtal" nodes.
+  is not needed because this is default setting (Of course, you can set the
+  clock rates to both "usb_extal" and "usb_xtal" nodes).
 
   Case 1: An external clock connects to R-Car SoC
     +----------+   +--- R-Car ---------------------+
-- 
2.54.0

Re: [PATCH] dt-bindings: arm: qcom,coresight-tpdm: fix bracket

[sashiko-bot]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] The commit message subject incorrectly identifies the modified subsystem and hardware as `arm: qcom,coresight-tpdm` instead of `clock: renesas,rcar-usb2-clock-sel`.
--

--- Patch [1]: [PATCH] dt-bindings: arm: qcom,coresight-tpdm: fix bracket ---
commit 4518c7688f32a888db4924e5e78556acf8a513d9
Author: Manuel Ebner <manuelebner@mailbox.org>

dt-bindings: arm: qcom,coresight-tpdm: fix bracket

This commit fixes a missing bracket and adjusts the sentence structure in a
device tree binding description.

> dt-bindings: arm: qcom,coresight-tpdm: fix bracket

[Severity: Medium]
Is the commit subject line correct for this change? The patch actually modifies
Documentation/devicetree/bindings/clock/renesas,rcar-usb2-clock-sel.yaml,
but the subject references arm: qcom,coresight-tpdm. Should the subject
be updated to match the modified renesas clock bindings?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260710085744.430340-2-manuelebner@mailbox.org?part=1

Re: [PATCH] dt-bindings: arm: qcom,coresight-tpdm: fix bracket

[Geert Uytterhoeven]

On Fri, 10 Jul 2026 at 10:58, Manuel Ebner <manuelebner@mailbox.org> wrote:
> Add ')' and fix sentence structure.
>
> Signed-off-by: Manuel Ebner <manuelebner@mailbox.org>

With the patch subject fixed:
Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

[PATCH] dt-bindings: arm: qcom,coresight-tpdm: fix bracket

[Manuel Ebner]

Remove needless '('.

Fixes: 6c781a35133d ("dt-bindings: arm: Add CoreSight TPDM hardware")
Signed-off-by: Manuel Ebner <manuelebner@mailbox.org>
---
 Documentation/devicetree/bindings/arm/qcom,coresight-tpdm.yaml | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/Documentation/devicetree/bindings/arm/qcom,coresight-tpdm.yaml b/Documentation/devicetree/bindings/arm/qcom,coresight-tpdm.yaml
index 152403f548c3..c7301f1b28c1 100644
--- a/Documentation/devicetree/bindings/arm/qcom,coresight-tpdm.yaml
+++ b/Documentation/devicetree/bindings/arm/qcom,coresight-tpdm.yaml
@@ -9,7 +9,7 @@ title: Trace, Profiling and Diagnostics Monitor - TPDM
 
 description: |
   The TPDM or Monitor serves as data collection component for various dataset
-  types specified in the QPMDA spec. It covers Implementation defined ((ImplDef),
+  types specified in the QPMDA spec. It covers Implementation defined (ImplDef),
   Basic Counts (BC), Tenure Counts (TC), Continuous Multi-Bit (CMB), and Discrete
   Single Bit (DSB). It performs data collection in the data producing clock
   domain and transfers it to the data collection time domain, generally ATB
-- 
2.54.0

Re: [PATCH] dt-bindings: arm: qcom,coresight-tpdm: fix bracket

[Jie Gan]

On 7/10/2026 4:05 PM, Manuel Ebner wrote:
> Remove needless '('.
> 
> Fixes: 6c781a35133d ("dt-bindings: arm: Add CoreSight TPDM hardware")
> Signed-off-by: Manuel Ebner <manuelebner@mailbox.org>

Thanks for fixing the typo.

Reviewed-by: Jie Gan <jie.gan@oss.qualcomm.com>

> ---
>   Documentation/devicetree/bindings/arm/qcom,coresight-tpdm.yaml | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/Documentation/devicetree/bindings/arm/qcom,coresight-tpdm.yaml b/Documentation/devicetree/bindings/arm/qcom,coresight-tpdm.yaml
> index 152403f548c3..c7301f1b28c1 100644
> --- a/Documentation/devicetree/bindings/arm/qcom,coresight-tpdm.yaml
> +++ b/Documentation/devicetree/bindings/arm/qcom,coresight-tpdm.yaml
> @@ -9,7 +9,7 @@ title: Trace, Profiling and Diagnostics Monitor - TPDM
>   
>   description: |
>     The TPDM or Monitor serves as data collection component for various dataset
> -  types specified in the QPMDA spec. It covers Implementation defined ((ImplDef),
> +  types specified in the QPMDA spec. It covers Implementation defined (ImplDef),
>     Basic Counts (BC), Tenure Counts (TC), Continuous Multi-Bit (CMB), and Discrete
>     Single Bit (DSB). It performs data collection in the data producing clock
>     domain and transfers it to the data collection time domain, generally ATB