Re: [PATCH v2 03/18] dt-bindings: clock: mediatek: Make '#clock-cells' required for MT8195

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:

Pre-existing issues:
- [High] The `mediatek,mt8195-sys-clock.yaml` binding documents `#reset-cells` as a property but fails to enforce it conditionally for hardware variants that act as reset providers (e.g., `mediatek,mt8195-infracfg_ao`), and the example is missing it.
--

--- Patch [3]: [PATCH v2 03/18] dt-bindings: clock: mediatek: Make '#clock-cells' required for MT8195 ---
commit 42e0c80a3dd56f332e8ace6fcaa3d35d00fa2f11
Author: Louis-Alexis Eyraud <louisalexis.eyraud@collabora.com>

dt-bindings: clock: mediatek: Make '#clock-cells' required for MT8195

This commit updates the MT8195 clock and sys-clock device tree bindings.
It adds the #clock-cells property to the required list to ensure clock
provider nodes define it properly.

> diff --git a/Documentation/devicetree/bindings/clock/mediatek,mt8195-sys-clock.yaml b/Documentation/devicetree/bindings/clock/mediatek,mt8195-sys-clock.yaml
> index 69f096eb168d1..ba1b36fa01699 100644
> --- a/Documentation/devicetree/bindings/clock/mediatek,mt8195-sys-clock.yaml
> +++ b/Documentation/devicetree/bindings/clock/mediatek,mt8195-sys-clock.yaml
> @@ -43,6 +43,7 @@ properties:
>  required:
>    - compatible
>    - reg
> +  - '#clock-cells'

[Severity: High]
This is a pre-existing issue, but the mediatek,mt8195-sys-clock.yaml binding
documents #reset-cells as a property but fails to enforce it conditionally for
hardware variants that act as reset providers, such as mediatek,mt8195-infracfg_ao.

Should an allOf conditional block be added to enforce #reset-cells for these
compatibles?

Without this constraint, an incomplete device tree node lacking #reset-cells
for infracfg_ao will silently pass dt_binding_check validation. At runtime,
dependent drivers like the thermal driver (which relies on
MT8195_INFRA_RST4_THERM_CTRL_MCU_SWRST) could fail to probe or operate
correctly.

Additionally, the example for infracfg_ao later in the file is missing the
#reset-cells property:

  - |
    infracfg_ao: syscon@10001000 {
        compatible = "mediatek,mt8195-infracfg_ao", "syscon";
        reg = <0x10001000 0x1000>;
        #clock-cells = <1>;
    };

If the constraint is properly added, wouldn't the example also need to be
updated with #reset-cells = <1>; to prevent dt_binding_check from failing?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260709-mt8189-clocks-system-base-v2-0-2926da3db6cf@collabora.com?part=3