Re: [PATCH v2 06/18] dt-bindings: clock: mediatek: regroup MT8192 dt-bindings into MT8186

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] The if-then block conditionally requiring `#reset-cells` for MT8188 devices incorrectly uses `enum` instead of `contains: enum` to match the compatible array.
--

--- Patch [6]: [PATCH v2 06/18] dt-bindings: clock: mediatek: regroup MT8192 dt-bindings into MT8186 ---
commit 788afe3e2a2b9eb892a1f9b88e225e3204455c7a
Author: Louis-Alexis Eyraud <louisalexis.eyraud@collabora.com>

dt-bindings: clock: mediatek: regroup MT8192 dt-bindings into MT8186
    
Regroup the MT8192 clock and system clock dt-bindings into MT8186 ones
to ease maintainability and have common files for several currently
supported SoC or new future ones, that have the same kind of clock
controller design.

> diff --git a/Documentation/devicetree/bindings/clock/mediatek,mt8186-clock.yaml b/Documentation/devicetree/bindings/clock/mediatek,mt8186-clock.yaml
> index 0bc2da60a6016..b5988d122e4dd 100644
> --- a/Documentation/devicetree/bindings/clock/mediatek,mt8186-clock.yaml
> +++ b/Documentation/devicetree/bindings/clock/mediatek,mt8186-clock.yaml

[ ... ]

[Severity: Medium]
Looking at the schema validation in this file, there is a regression
introduced in the prior patch of this series (dt-bindings: clock: mediatek:
regroup MT8188 dt-bindings into MT8186) where the if-then block evaluates
the compatible array against a scalar string enum:

Documentation/devicetree/bindings/clock/mediatek,mt8186-clock.yaml:allOf.if
  allOf:
    - if:
        properties:
          compatible:
            enum:
              - mediatek,mt8188-camsys-rawa

Is this evaluation correct for an array property?

Comparing the compatible array directly against an enum always fails.
Consequently, valid device trees with MT8188 blocks and the required
#reset-cells property fall into the else block (which enforces
#reset-cells: false), leading to spurious schema validation failures
when running make dtbs_check.

Could this be updated to use contains: enum to correctly match the
compatible array?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260709-mt8189-clocks-system-base-v2-0-2926da3db6cf@collabora.com?part=6