Re: [PATCH v2 05/18] dt-bindings: clock: mediatek: regroup MT8188 dt-bindings into MT8186

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] The `allOf` conditional block in `mediatek,mt8186-clock.yaml` is missing the `contains:` keyword when matching the `compatible` property array against an enum, causing the condition to never match and falsely forbidding `#reset-cells` for all devices.
--

--- Patch [5]: [PATCH v2 05/18] dt-bindings: clock: mediatek: regroup MT8188 dt-bindings into MT8186 ---
commit 833611ff98aed20bc6663bc2bdced91c5491f806
Author: Louis-Alexis Eyraud <louisalexis.eyraud@collabora.com>

dt-bindings: clock: mediatek: regroup MT8188 dt-bindings into MT8186

This commit regroups the MT8188 clock and system clock device tree bindings
into the MT8186 bindings to ease maintainability and share common files for
SoCs with similar clock controller designs.

> diff --git a/Documentation/devicetree/bindings/clock/mediatek,mt8186-clock.yaml b/Documentation/devicetree/bindings/clock/mediatek,mt8186-clock.yaml
> index 756b937bb7c4c..0bc2da60a6016 100644
> --- a/Documentation/devicetree/bindings/clock/mediatek,mt8186-clock.yaml
> +++ b/Documentation/devicetree/bindings/clock/mediatek,mt8186-clock.yaml
[ ... ]
> @@ -42,11 +65,36 @@ properties:
>    '#clock-cells':
>      const: 1
>  
> +  '#reset-cells':
> +    const: 1
> +
>  required:
>    - compatible
>    - reg
>    - '#clock-cells'
>  
> +allOf:
> +  - if:
> +      properties:
> +        compatible:
> +          enum:
> +            - mediatek,mt8188-camsys-rawa

[Severity: Medium]
When the MT8188 clock binding was moved here, the contains keyword was dropped
from this conditional block.

Since the compatible property is evaluated as an array, matching it directly
against an enum without the contains keyword evaluates to false.

Will this cause the else branch to execute unconditionally and falsely forbid
the #reset-cells property for valid MT8188 device tree nodes during
dt_binding_check validation?

> +            - mediatek,mt8188-camsys-rawb
> +            - mediatek,mt8188-camsys-yuva

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260709-mt8189-clocks-system-base-v2-0-2926da3db6cf@collabora.com?part=5