Re: [PATCH v3 2/3] riscv: dts: spacemit: k1: Split gmac_clk_ref into independent pinctrl groups

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] The patch splits the `gmacX_clk_ref` pins into independent pinctrl groups but fails to update `k1-orangepi-rv2.dts`, silently breaking its Ethernet pinmux configuration.
--

--- Patch [2]: [PATCH v3 2/3] riscv: dts: spacemit: k1: Split gmac_clk_ref into independent pinctrl groups ---
commit 093c0ef49e1b8bcf37cbcb0a97a5e5bcd2242b3c
Author: Junhui Liu <junhui.liu@pigmoral.tech>

riscv: dts: spacemit: k1: Split gmac_clk_ref into independent pinctrl groups
    
The gmac_clk_ref signal is optional for the GMAC controller and is not
strictly required for all hardware designs. Split the refclk pins into
independent pinctrl groups so boards can request them only when needed.

> diff --git a/arch/riscv/boot/dts/spacemit/k1-bananapi-f3.dts b/arch/riscv/boot/dts/spacemit/k1-bananapi-f3.dts
> index 72f77e9edd63d..e6ab43be301a3 100644
> --- a/arch/riscv/boot/dts/spacemit/k1-bananapi-f3.dts
> +++ b/arch/riscv/boot/dts/spacemit/k1-bananapi-f3.dts
> @@ -101,7 +101,7 @@ &eth0 {
>  	phy-handle = <&rgmii0>;
>  	phy-mode = "rgmii-id";
>  	pinctrl-names = "default";
> -	pinctrl-0 = <&gmac0_cfg>;
> +	pinctrl-0 = <&gmac0_cfg>, <&gmac0_clk_ref_cfg>;
>  	rx-internal-delay-ps = <0>;
>  	tx-internal-delay-ps = <0>;
>  	status = "okay";

[ ... ]

> diff --git a/arch/riscv/boot/dts/spacemit/k1-pinctrl.dtsi b/arch/riscv/boot/dts/spacemit/k1-pinctrl.dtsi
> index 4e9a62d0e85b5..8c57ca05dabdb 100644
> --- a/arch/riscv/boot/dts/spacemit/k1-pinctrl.dtsi
> +++ b/arch/riscv/boot/dts/spacemit/k1-pinctrl.dtsi
> @@ -27,8 +27,16 @@ gmac0-pins {
>  				 <K1_PADCONF(11, 1)>,	/* gmac0_tx_en */
>  				 <K1_PADCONF(12, 1)>,	/* gmac0_mdc */
>  				 <K1_PADCONF(13, 1)>,	/* gmac0_mdio */
> -				 <K1_PADCONF(14, 1)>,	/* gmac0_int_n */
> -				 <K1_PADCONF(45, 1)>;	/* gmac0_clk_ref */
> +				 <K1_PADCONF(14, 1)>;	/* gmac0_int_n */

[Severity: Medium]
Will this change break networking on the OrangePi RV2 board?

The eth0 and eth1 nodes in arch/riscv/boot/dts/spacemit/k1-orangepi-rv2.dts
request gmac0_cfg and gmac1_cfg respectively, but this file was not updated
to include the newly separated refclk pinmux configuration:

arch/riscv/boot/dts/spacemit/k1-orangepi-rv2.dts:&eth0 {
    ...
	phy-mode = "rgmii-id";
	pinctrl-names = "default";
	pinctrl-0 = <&gmac0_cfg>;
    ...
}

If the OrangePi RV2 hardware relies on these external clock reference pins
for its physical Ethernet interfaces, removing them from the default group
might leave the pinmux incomplete. Should k1-orangepi-rv2.dts also be
updated to include gmac0_clk_ref_cfg and gmac1_clk_ref_cfg?

> +
> +			bias-pull-up = <0>;
> +			drive-strength = <21>;
> +		};
> +	};

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260712-bpi-cm6-v3-0-8d1e2045179d@pigmoral.tech?part=2