Re: [PATCH v3 3/3] riscv: dts: spacemit: k1: Add Banana Pi BPI-CM6 IO board

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] The LED nodes omit the `function` property, preventing standard sysfs naming.
--

--- Patch [3]: [PATCH v3 3/3] riscv: dts: spacemit: k1: Add Banana Pi BPI-CM6 IO board ---
commit eca00d20544419594bdbc975c29f6586b94b4fd3
Author: Junhui Liu <junhui.liu@pigmoral.tech>

riscv: dts: spacemit: k1: Add Banana Pi BPI-CM6 IO board
    
The Banana Pi BPI-CM6 IO board combines the BPI-CM6 compute module with
an IO carrier board. The core module integrates the SpacemiT K1 SoC,
PMIC, DDR, eMMC, the eth0 PHY, and wireless connectivity. The companion
IO carrier board extends it by providing the eth1 PHY and exposing
standard interfaces, including dual Gigabit Ethernet, MicroSD, two USB-A
ports, a USB Type-C port, two PCIe M.2 slots, and a serial console.
    
Link: https://docs.banana-pi.org/en/BPI-CM6/BananaPi_BPI-CM6

> diff --git a/arch/riscv/boot/dts/spacemit/k1-bananapi-cm6-io.dts b/arch/riscv/boot/dts/spacemit/k1-bananapi-cm6-io.dts
> new file mode 100644
> index 0000000000000..2c2d78aee98aa
> --- /dev/null
> +++ b/arch/riscv/boot/dts/spacemit/k1-bananapi-cm6-io.dts
> @@ -0,0 +1,177 @@

[ ... ]

> +	leds {
> +		compatible = "gpio-leds";
> +
> +		led0 {
> +			color = <LED_COLOR_ID_RED>;
> +			gpios = <&gpio K1_GPIO(96) GPIO_ACTIVE_LOW>;
> +		};

[Severity: Low]
This isn't a bug, but should the led0 node in k1-bananapi-cm6-io.dts include a
function property to indicate its hardware role?

Without it, the LED subsystem cannot construct the standard color:function
sysfs name (e.g., red:status) during the gpio-leds driver probe, and will
fall back to legacy or incomplete naming.

> +
> +		led1 {
> +			color = <LED_COLOR_ID_BLUE>;
> +			gpios = <&gpio K1_GPIO(97) GPIO_ACTIVE_LOW>;
> +		};

[Severity: Low]
This isn't a bug, but should the led1 node also include a function property?

Like led0, omitting it prevents the LED subsystem from generating standard
user-space sysfs paths for this LED during device tree parsing.

> +	};

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260712-bpi-cm6-v3-0-8d1e2045179d@pigmoral.tech?part=3