From: sashiko-bot@kernel.org
To: "James Calligeros" <jcalligeros99@gmail.com>
Cc: conor+dt@kernel.org, devicetree@vger.kernel.org, robh@kernel.org
Subject: Re: [PATCH 12/12] arm64: dts: apple: t60xx: jxxx: Add device-specific SMC hwmon sensors
Date: Sun, 12 Jul 2026 09:52:19 +0000 [thread overview]
Message-ID: <20260712095219.965CD1F000E9@smtp.kernel.org> (raw)
In-Reply-To: <20260712-smc-subdev-dt-v1-12-7763006d57c7@gmail.com>
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] M2 Mac Studio models incorrectly include the single-fan hwmon configuration instead of the dual-fan configuration.
--
--- Patch [12]: [PATCH 12/12] arm64: dts: apple: t60xx: jxxx: Add device-specific SMC hwmon sensors ---
commit 9b6661d8907736a04d8f29e1718ac346ff51ced8
Author: James Calligeros <jcalligeros99@gmail.com>
arm64: dts: apple: t60xx: jxxx: Add device-specific SMC hwmon sensors
Add the device-specific hwmon sensors for select T60xx-based devices.
[ ... ]
> diff --git a/arch/arm64/boot/dts/apple/t6021-j475c.dts b/arch/arm64/boot/dts/apple/t6021-j475c.dts
> index 533e357748746..82689c380cdf2 100644
> --- a/arch/arm64/boot/dts/apple/t6021-j475c.dts
> +++ b/arch/arm64/boot/dts/apple/t6021-j475c.dts
> @@ -35,3 +35,5 @@ &port01 {
> &pcie0_dart_1 {
> status = "okay";
> };
> +
> +#include "hwmon-fan.dtsi"
[Severity: Medium]
Should this M2 Max Mac Studio use hwmon-fan-dual.dtsi instead of
hwmon-fan.dtsi?
Using the single-fan configuration might cause hardware monitoring telemetry
to miss the second fan on this device, leading to incomplete fan statistics
in userspace.
> diff --git a/arch/arm64/boot/dts/apple/t6022-j475d.dts b/arch/arm64/boot/dts/apple/t6022-j475d.dts
> index 31f24bbda9689..f50a6d56f3d8e 100644
> --- a/arch/arm64/boot/dts/apple/t6022-j475d.dts
> +++ b/arch/arm64/boot/dts/apple/t6022-j475d.dts
> @@ -44,6 +44,8 @@ &typec5 {
> label = "USB-C Front Left";
> };
>
> +#include "hwmon-fan.dtsi"
[Severity: Medium]
Does this M2 Ultra Mac Studio also need hwmon-fan-dual.dtsi rather than
hwmon-fan.dtsi?
Similar to the M2 Max model, using the single-fan configuration could cause
hardware monitoring to miss the second fan's telemetry.
--
Sashiko AI review · https://sashiko.dev/#/patchset/20260712-smc-subdev-dt-v1-0-7763006d57c7@gmail.com?part=12
prev parent reply other threads:[~2026-07-12 9:52 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-12 9:43 [PATCH 00/12] arm64: dts: apple: Add SMC hwmon nodes James Calligeros
2026-07-12 9:43 ` [PATCH 01/12] arm64: dts: apple: t8112: Add SMC hwmon node James Calligeros
2026-07-12 9:53 ` sashiko-bot
2026-07-12 9:43 ` [PATCH 02/12] arm64: dts: apple: t8103: " James Calligeros
2026-07-12 9:55 ` sashiko-bot
2026-07-12 9:43 ` [PATCH 03/12] arm64: dts: apple: t600x: " James Calligeros
2026-07-12 9:43 ` [PATCH 04/12] arm64: dts: apple: t602x: " James Calligeros
2026-07-12 9:43 ` [PATCH 05/12] arm64: dts: apple: Add common SMC hwmon infrastructure James Calligeros
2026-07-12 9:43 ` [PATCH 06/12] arm64: dts: apple: t8103: Add common SMC hwmon sensors James Calligeros
2026-07-12 9:43 ` [PATCH 07/12] arm64: dts: apple: t8112: " James Calligeros
2026-07-12 9:43 ` [PATCH 08/12] arm64: dts: apple: t600x: " James Calligeros
2026-07-12 9:43 ` [PATCH 09/12] arm64: dts: apple: t602x: " James Calligeros
2026-07-12 9:43 ` [PATCH 10/12] arm64: dts: apple: t8103: jxxx: Add device-specific " James Calligeros
2026-07-12 9:43 ` [PATCH 11/12] arm64: dts: apple: t8112: " James Calligeros
2026-07-12 9:43 ` [PATCH 12/12] arm64: dts: apple: t60xx: " James Calligeros
2026-07-12 9:52 ` sashiko-bot [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260712095219.965CD1F000E9@smtp.kernel.org \
--to=sashiko-bot@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=jcalligeros99@gmail.com \
--cc=robh@kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox