Re: [PATCH 01/12] arm64: dts: apple: t8112: Add SMC hwmon node

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] Adding an unconditionally enabled `smc_hwmon` node without child sensors triggers a spurious `dev_err` on boot on all T8112 platforms.
--

--- Patch [1]: [PATCH 01/12] arm64: dts: apple: t8112: Add SMC hwmon node ---
commit 98dce99825d4d377b6a5ac4bb63591402516eb04
Author: James Calligeros <jcalligeros99@gmail.com>

arm64: dts: apple: t8112: Add SMC hwmon node

This commit adds the SMC hwmon subdevice node to the Apple T8112 device tree.

> diff --git a/arch/arm64/boot/dts/apple/t8112.dtsi b/arch/arm64/boot/dts/apple/t8112.dtsi
> index 85c47422d4e8e..a3241c816c26b 100644
> --- a/arch/arm64/boot/dts/apple/t8112.dtsi
> +++ b/arch/arm64/boot/dts/apple/t8112.dtsi
> @@ -921,6 +921,10 @@ smc_reboot: reboot {
>  					"boot_error_count", "panic_count";
>  			};
>  
> +			smc_hwmon: hwmon {
> +				compatible = "apple,smc-hwmon";
> +			};
> +

[Severity: Medium]
Will this unconditionally enabled node trigger a spurious error on boot?

Because this node is added without any child sensors and lacks a
status = "disabled" property, the SMC MFD core will instantiate the
macsmc-hwmon platform device.

When the probe function runs, it won't find any sensors, and will print an
error message to the kernel log before returning -ENODEV:

drivers/hwmon/macsmc-hwmon.c:macsmc_hwmon_probe() {
    ...
	if (!hwmon->curr.count && !hwmon->fan.count &&
	    !hwmon->power.count && !hwmon->temp.count &&
	    !hwmon->volt.count) {
		dev_err(hwmon->dev,
			"No valid sensors found of any supported type\n");
		return -ENODEV;
	}
    ...
}

Should this node be added with status = "disabled" to prevent the
macsmc-hwmon driver from probing and polluting dmesg on platforms
without sensors?

>  			rtc {
>  				compatible = "apple,smc-rtc";
>  				nvmem-cells = <&rtc_offset>;

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260712-smc-subdev-dt-v1-0-7763006d57c7@gmail.com?part=1