Re: [PATCH 02/12] arm64: dts: apple: t8103: Add SMC hwmon node

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] Adding an empty `smc_hwmon` node without `status = "disabled"` causes the `macsmc_hwmon` driver to fail its probe and print a `dev_err` on every boot for all t8103 devices.
--

--- Patch [2]: [PATCH 02/12] arm64: dts: apple: t8103: Add SMC hwmon node ---
commit 537fe4eb204476276f256c169a803f44dce48ec8
Author: James Calligeros <jcalligeros99@gmail.com>

arm64: dts: apple: t8103: Add SMC hwmon node

This commit adds the SMC hwmon subdevice node to the t8103 device tree.

> diff --git a/arch/arm64/boot/dts/apple/t8103.dtsi b/arch/arm64/boot/dts/apple/t8103.dtsi
> --- a/arch/arm64/boot/dts/apple/t8103.dtsi
> +++ b/arch/arm64/boot/dts/apple/t8103.dtsi
[ ... ]
> @@ -918,6 +918,10 @@ smc_reboot: reboot {
>  					"boot_error_count", "panic_count";
>  			};
>  
> +			smc_hwmon: hwmon {
> +				compatible = "apple,smc-hwmon";
> +			};

[Severity: Medium]
Will this empty hwmon node cause a spurious error message on boot for all
t8103 devices?

When the macsmc_hwmon driver probes this node without any child sensor nodes
defined, it evaluates the empty node, finds 0 sensors, and prints an error:

drivers/hwmon/macsmc-hwmon.c:macsmc_hwmon_probe() {
    ...
    if (!hwmon->curr.count && !hwmon->fan.count &&
        !hwmon->power.count && !hwmon->temp.count &&
        !hwmon->volt.count) {
        dev_err(hwmon->dev,
            "No valid sensors found of any supported type\n");
        return -ENODEV;
    }
    ...
}

Should this node include status = "disabled" by default to prevent the driver
from failing its probe and polluting the kernel log?

> +
>  			rtc {
>  				compatible = "apple,smc-rtc";
>  				nvmem-cells = <&rtc_offset>;

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260712-smc-subdev-dt-v1-0-7763006d57c7@gmail.com?part=2