Re: [PATCH v3 5/8] dt-bindings: iio: adc: add ti,ads122c14

[Jonathan Cameron <jic23@kernel.org>]

On Fri, 10 Jul 2026 17:50:38 -0500
"David Lechner (TI)" <dlechner@baylibre.com> wrote:

> Add new bindings for ti,ads122c14 and similar devices.
> 
> This is an ADC that is primarily intended for use with temperature
> sensors.

I'd avoid stating that - if nothing else because it then sounds like
it should be a hwmon sensor.   There are a bunch of other use cases of
these that definitely aren't hwmon territory. E.g. pressure, strain and
flow sensors.   At very least refer to some of those other sensor types.

> There are a few unusual properties because of this. In
> particular, the reference voltage source and current output requirements
> can be different for each measurement, so these are included in the
> channel bindings.
> 
> The REFP/REFN reference voltage is usually just connected to a resistor
> that is being driven by the ADC's current outputs, so there is special
> property for this case rather than requiring a regulator to be defined
> to represent that.
> 
> ti,vref-source is reused from ti,tlv320adcx140.yaml (otherwise might
> have preferred an enum of strings).

Sashiko calls out you aren't using this so commit message needs an update.
Otherwise just that potential mismatch in ordering between interrupts
descriptions and interrupt-names you called out in the earlier version.
That's common enough I think we are fine with it, but dt bindings maintainers
can comment on that if they like.

> 
> Signed-off-by: David Lechner (TI) <dlechner@baylibre.com>
> ---
> v3 changes:
> * Fixed channel@ pattern.
> * Adapted to input-chopping property rename.
> * Made sure to use items: on array properties.
> * Added reg to required list.
> * Fixed missing space in example comment.
> 
> v2 changes:
> * Added ti, vendor prefix when appropriate.
> * Others are now standardized properties from adc.yaml.
> * Moved top-level unevaluatedProperties.
> * Fixed some issues with the channel@ matching and reg property.
> * Dropped description on bipolar property.
> * Renamed current-chopping to input-channel-rotation.
> * Drop header file and use string enum instead for reference-sources.
> * Added burn-out-current-nanoamp property.
> * Drop allOf: and just use oneOf: directly.
> * Fix inconsistent indentation in the examples.
> ---
>  .../devicetree/bindings/iio/adc/ti,ads112c14.yaml  | 207 +++++++++++++++++++++
>  MAINTAINERS                                        |   6 +
>  2 files changed, 213 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/iio/adc/ti,ads112c14.yaml b/Documentation/devicetree/bindings/iio/adc/ti,ads112c14.yaml
> new file mode 100644
> index 000000000000..a2ee473c8e61
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/iio/adc/ti,ads112c14.yaml
> @@ -0,0 +1,207 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/iio/adc/ti,ads112c14.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Texas Instruments' ADS112C14 and similar ADC chips
> +
> +description: |
> +  Supports the following Texas Instruments' ADC chips:
> +  - ADS112C14 (16-bit)
> +  - ADS122C14 (24-bit)
> +
> +  https://www.ti.com/lit/ds/symlink/ads122c14.pdf
> +
> +  These chips are primarily designed for use with temperature sensors such as
> +  RTDs and thermocouples. The channel bindings reflect this in that each channel
> +  represents the conditions required to make a measurement rather than strictly
> +  just the physical input channels.

Similar to above. I'd broaden this to cover a few other sensor types.  The datasheet
is less committed to temperature sensors than this text!  E.g. Section 9.2.3
(It has both a wheatstone bridge and a thermistor, so still some temperature
aspects!)

Otherwise binding looks fine to me.