From: David Lechner <dlechner@baylibre.com>
To: Jonathan Cameron <jic23@kernel.org>
Cc: "Nuno Sá" <nuno.sa@analog.com>,
"Andy Shevchenko" <andy@kernel.org>,
"Rob Herring" <robh@kernel.org>,
"Krzysztof Kozlowski" <krzk+dt@kernel.org>,
"Conor Dooley" <conor+dt@kernel.org>,
"Chris Hall" <c-hall@ti.com>, "Patrick Edwards" <pedwards@ti.com>,
"Kurt Borja" <kuurtb@gmail.com>,
"Nguyen Minh Tien" <zizuzacker@gmail.com>,
linux-iio@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 6/8] iio: adc: add ti-ads112c14 driver
Date: Mon, 13 Jul 2026 09:03:04 -0500 [thread overview]
Message-ID: <7d01660f-2b42-4602-97fd-29a80cb2ac45@baylibre.com> (raw)
In-Reply-To: <20260713031110.55ab2764@jic23-huawei>
On 7/12/26 9:11 PM, Jonathan Cameron wrote:
> On Fri, 10 Jul 2026 17:50:39 -0500
> "David Lechner (TI)" <dlechner@baylibre.com> wrote:
>
>> Add a new driver for the TI ADS112C14/ADS122C14 ADC chips.
>>
...
>> + info->device_id,
>> + FIELD_GET(ADS112C14_DEVICE_ID_BITS, reg_val));
>> +
>> + /* Place in single-shot conversion mode to make ready for raw read. */
> Writing a bit called conv mode puts it in single-shot? (sashiko)
Sashiko didn't read the datasheet. The options are continuous conversion
mode (0) or single-shot conversion mode (1).
It isn't obvious from the bit name which one is active when the bit
is set, hence the comment.
>
>> + ret = regmap_set_bits(data->regmap, ADS112C14_REG_DEVICE_CFG,
>> + ADS112C14_DEVICE_CFG_CONV_MODE);
>
> Thanks,
>
> Jonathan
>
>
next prev parent reply other threads:[~2026-07-13 14:03 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-10 22:50 [PATCH v3 0/8] iio: adc: new ti-ads112c14 driver David Lechner
2026-07-10 22:50 ` [PATCH v3 1/8] dt-bindings: iio: adc: Add reference-sources property David Lechner
2026-07-10 22:50 ` [PATCH v3 2/8] dt-bindings: iio: adc: Add excitation current sources properties David Lechner
2026-07-13 1:32 ` Jonathan Cameron
2026-07-10 22:50 ` [PATCH v3 3/8] dt-bindings: iio: adc: Add burn-out current properties David Lechner
2026-07-10 22:50 ` [PATCH v3 4/8] dt-bindings: iio: adc: add input-chopping property David Lechner (TI)
2026-07-13 1:34 ` Jonathan Cameron
2026-07-13 14:55 ` David Lechner
2026-07-13 15:24 ` Jonathan Cameron
2026-07-13 16:29 ` Conor Dooley
2026-07-10 22:50 ` [PATCH v3 5/8] dt-bindings: iio: adc: add ti,ads122c14 David Lechner (TI)
2026-07-10 22:59 ` sashiko-bot
2026-07-10 23:12 ` David Lechner
2026-07-13 1:54 ` Jonathan Cameron
2026-07-13 16:28 ` Conor Dooley
2026-07-10 22:50 ` [PATCH v3 6/8] iio: adc: add ti-ads112c14 driver David Lechner (TI)
2026-07-10 23:00 ` sashiko-bot
2026-07-12 9:42 ` Andy Shevchenko
2026-07-12 16:30 ` David Lechner
2026-07-13 2:11 ` Jonathan Cameron
2026-07-13 14:03 ` David Lechner [this message]
2026-07-10 22:50 ` [PATCH v3 7/8] iio: adc: ti-ads112c14: implement gain on internal short SYS_MON channel David Lechner (TI)
2026-07-10 23:04 ` sashiko-bot
2026-07-11 9:11 ` Andy Shevchenko
2026-07-13 2:21 ` Jonathan Cameron
2026-07-10 22:50 ` [PATCH v3 8/8] iio: adc: ti-ads112c14: add measurement channel support David Lechner (TI)
2026-07-10 23:08 ` sashiko-bot
2026-07-11 13:00 ` Andy Shevchenko
2026-07-13 19:40 ` David Lechner
2026-07-13 2:35 ` Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7d01660f-2b42-4602-97fd-29a80cb2ac45@baylibre.com \
--to=dlechner@baylibre.com \
--cc=andy@kernel.org \
--cc=c-hall@ti.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=jic23@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=kuurtb@gmail.com \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nuno.sa@analog.com \
--cc=pedwards@ti.com \
--cc=robh@kernel.org \
--cc=zizuzacker@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox