Re: [PATCH 7/8] ARM: dts: mstar: sbc2d06: Add regulators

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [High] The `vcc_sd` and `reg_vcc_wifi` fixed regulators specify `GPIO_ACTIVE_HIGH` but omit the `enable-active-high` property, causing their GPIO polarity to be incorrectly forced to active-low.
--

--- Patch [7]: [PATCH 7/8] ARM: dts: mstar: sbc2d06: Add regulators ---
commit 9f0e98cb27cc735c61124ee041d094826dabd5cf
Author: Daniel Palmer <daniel@0x0f.com>

ARM: dts: mstar: sbc2d06: Add regulators

This commit adds the board's fixed regulators.

> diff --git a/arch/arm/boot/dts/sigmastar/mstar-infinity2m-ssd202d-wirelesstag-ido-sbc2d06-v1b-22w.dts b/arch/arm/boot/dts/sigmastar/mstar-infinity2m-ssd202d-wirelesstag-ido-sbc2d06-v1b-22w.dts
> index b15c40762bc0a..8dbff5e53e5f2 100644
> --- a/arch/arm/boot/dts/sigmastar/mstar-infinity2m-ssd202d-wirelesstag-ido-sbc2d06-v1b-22w.dts
> +++ b/arch/arm/boot/dts/sigmastar/mstar-infinity2m-ssd202d-wirelesstag-ido-sbc2d06-v1b-22w.dts

[ ... ]

> +	vcc_sd: regulator-vcc-sd {
> +		compatible = "regulator-fixed";
> +		regulator-name = "vcc_sd";
> +		regulator-min-microvolt = <3300000>;
> +		regulator-max-microvolt = <3300000>;
> +		gpio = <&gpio SSD20XD_GPIO_GPIO90 GPIO_ACTIVE_HIGH>;
> +	};

[Severity: High]
Does this missing enable-active-high property cause the SD card power supply to
fail to turn on?

The vcc_sd fixed regulator specifies GPIO_ACTIVE_HIGH but omits the
enable-active-high property. When the regulator framework attempts to enable it,
gpiolib intercepts the GPIO request via of_gpio_flags_quirks(). Because the
property is missing, the quirk forcefully applies the OF_GPIO_ACTIVE_LOW flag,
overriding the GPIO_ACTIVE_HIGH phandle argument, and logs "enforce active low
on GPIO handle".

The regulator framework would then incorrectly drive the GPIO low to enable it.
This could prevent the SD card from powering on, potentially breaking boot if
the root filesystem is located on it.

A similar issue appears to be present in reg_vcc_wifi (regulator-vcc-wifi) from
an earlier patch in this series, which also omits the enable-active-high
property.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260713105950.1346962-1-daniel@thingy.jp?part=7