Re: [PATCH 5/8] ARM: dts: mstar: miyoo-mini: Add vibrator

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] Missing `#include <dt-bindings/gpio/gpio.h>` causes device tree compilation failure due to an undefined `GPIO_ACTIVE_LOW` macro.
--

--- Patch [5]: [PATCH 5/8] ARM: dts: mstar: miyoo-mini: Add vibrator ---
commit c4d7e499cb7660d52f8d45adc7aae0663b10a9a9
Author: Daniel Palmer <daniel@0x0f.com>

ARM: dts: mstar: miyoo-mini: Add vibrator

This commit adds a vibration motor node to the Miyoo Mini device tree,
configuring it to be driven by a GPIO pin.

> diff --git a/arch/arm/boot/dts/sigmastar/mstar-infinity2m-ssd202d-miyoo-mini.dts b/arch/arm/boot/dts/sigmastar/mstar-infinity2m-ssd202d-miyoo-mini.dts
> --- a/arch/arm/boot/dts/sigmastar/mstar-infinity2m-ssd202d-miyoo-mini.dts
> +++ b/arch/arm/boot/dts/sigmastar/mstar-infinity2m-ssd202d-miyoo-mini.dts

[ ... ]

> @@ -18,6 +18,12 @@ aliases {
>  	chosen {
>  		stdout-path = "serial0:115200n8";
>  	};
> +
> +	vibrator {
> +		compatible = "gpio-vibrator";
> +		enable-gpios = <&gpio SSD20XD_GPIO_UART0_TX GPIO_ACTIVE_LOW>;

[Severity: Low]
Does this file compile successfully without the gpio bindings header?

It looks like GPIO_ACTIVE_LOW is used in the new vibrator node, but the
file doesn't appear to include <dt-bindings/gpio/gpio.h>.

Will this result in a compilation failure from the device tree compiler
due to the undefined macro?

> +	};
> +
>  };
>  
>  &pm_uart {

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260713105950.1346962-1-daniel@thingy.jp?part=5