Re: [PATCH 8/8] ARM: dts: mstar: ssd201htv2: Add SD card supply regulator

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] The fixed regulator node `reg_sd_vdd` is missing the `enable-active-high;` property, causing the GPIO subsystem to silently override the polarity to active-low despite the `GPIO_ACTIVE_HIGH` flag.
--

--- Patch [8]: [PATCH 8/8] ARM: dts: mstar: ssd201htv2: Add SD card supply regulator ---
commit 54af4e7814b68ef5327152ebd2b9e1372991e4d5
Author: Daniel Palmer <daniel@0x0f.com>

ARM: dts: mstar: ssd201htv2: Add SD card supply regulator

Add the fixed regulator that supplies the SD card slot on the ssd201htv2.

> diff --git a/arch/arm/boot/dts/sigmastar/mstar-infinity2m-ssd202d-ssd201htv2.dts b/arch/arm/boot/dts/sigmastar/mstar-infinity2m-ssd202d-ssd201htv2.dts
> index 5d81641414a21..9f0ce16a08748 100644
> --- a/arch/arm/boot/dts/sigmastar/mstar-infinity2m-ssd202d-ssd201htv2.dts
> +++ b/arch/arm/boot/dts/sigmastar/mstar-infinity2m-ssd202d-ssd201htv2.dts
[ ... ]
> @@ -18,6 +20,14 @@ aliases {
>  	chosen {
>  		stdout-path = "serial0:115200n8";
>  	};
> +
> +	reg_sd_vdd: regulator-sd-vdd {
> +		compatible = "regulator-fixed";
> +		regulator-name = "sd_vdd";
> +		regulator-min-microvolt = <3300000>;
> +		regulator-max-microvolt = <3300000>;
> +		gpio = <&gpio SSD20XD_GPIO_GPIO0 GPIO_ACTIVE_HIGH>;

[Severity: Medium]
Is the enable-active-high; property missing here?

For regulator-fixed nodes, the GPIO subsystem applies a legacy quirk in
drivers/gpio/gpiolib-of.c:of_gpio_set_polarity_by_property() where the
absence of enable-active-high forces an active-low override. This ignores
the GPIO_ACTIVE_HIGH flag.

Will this cause the regulator framework to drive the GPIO low instead of
high, failing to power the SD card on this board?

> +	};
>  };
>  
>  &pm_uart {

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260713105950.1346962-1-daniel@thingy.jp?part=8