Re: [PATCH v10 02/11] reset: Add Realtek basic reset support

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 2 potential issue(s) to consider:
- [Medium] The Kconfig help text and commit message incorrectly claim the driver provides a registration helper function to extract the regmap and device tree node.
- [Low] Unnecessary inclusion of `<linux/device.h>` and `<linux/of.h>`.
--

--- Patch [2]: [PATCH v10 02/11] reset: Add Realtek basic reset support ---
commit 231fee7f5cf687d120e12d9c11d120d53d5aa54d
Author: Cheng-Yu Lee <cylee12@realtek.com>

reset: Add Realtek basic reset support

This commit defines reset operations backed by a regmap-based register
interface for Realtek SoCs. It exports the reset control operations to allow
callers to manually assign their own reset controller data structures.

> reset: Add Realtek basic reset support
> 
> Define the reset operations backed by a regmap-based register interface
> and prepare the reset controller to be registered through the reset
> framework.
> 
> Since the reset controllers on Realtek SoCs often share the same register
> space with the clock controllers, this common framework is designed to
> extract the regmap and device tree node from the parent device
> (e.g., an auxiliary device parent).

[Severity: Medium]
Is this description still accurate?

The changelog notes that in v10, the wrapper function was removed to allow
callers to assign the regmap, ops, dev, and of_node individually. It seems the
common framework no longer extracts the regmap and device tree node from the
parent device.

[ ... ]

> diff --git a/drivers/reset/realtek/Kconfig b/drivers/reset/realtek/Kconfig
> new file mode 100644
> index 0000000000000..bb6dd856a64a5
> --- /dev/null
> +++ b/drivers/reset/realtek/Kconfig
> @@ -0,0 +1,8 @@
> +# SPDX-License-Identifier: GPL-2.0-only
> +config RESET_RTK_COMMON
> +	tristate "Realtek common reset driver" if COMPILE_TEST
> +	help
> +	  This option enables the common reset controller library for
> +	  Realtek SoCs. It provides shared reset control operations
> +	  (assert, deassert, status) and a registration helper function
> +	  that other Realtek-specific reset drivers can use.

[Severity: Medium]
Should the Kconfig help text be updated to reflect the v10 changes? 

It explicitly claims a registration helper function is provided, which appears
to no longer be true since rtk_reset_ops is exported directly instead.

[ ... ]

> diff --git a/drivers/reset/realtek/reset-rtk-common.c b/drivers/reset/realtek/reset-rtk-common.c
> new file mode 100644
> index 0000000000000..4d5ec2b0416d1
> --- /dev/null
> +++ b/drivers/reset/realtek/reset-rtk-common.c
> @@ -0,0 +1,75 @@
> +// SPDX-License-Identifier: GPL-2.0-only
> +/*
> + * Copyright (C) 2019-2026 Realtek Semiconductor Corporation
> + */
> +
> +#include <linux/device.h>
> +#include <linux/export.h>
> +#include <linux/module.h>
> +#include <linux/of.h>

[Severity: Low]
Since the registration helper function was removed, are linux/device.h and
linux/of.h still necessary? 

It looks like these headers were used to interact with struct device and
of_node, and could now be safely dropped.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260713155630.3054636-1-eleanor.lin@realtek.com?part=2