Re: [PATCH v10 04/11] clk: realtek: Introduce a common probe()

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [High] Failure to check for error pointers in the `clk_hw_onecell_data` array leads to a potential kernel panic when registering clocks.
--

--- Patch [4]: [PATCH v10 04/11] clk: realtek: Introduce a common probe() ---
commit 2ca4c07d930b1b3a9fa36b5d566c53f338efd00d
Author: Cheng-Yu Lee <cylee12@realtek.com>

clk: realtek: Introduce a common probe()

This commit adds rtk_clk_probe() to set up the shared regmap, register clock
hardware, and add the clock provider. It also creates an auxiliary device for
reset controllers if the #reset-cells property is present in the device tree.

> diff --git a/drivers/clk/realtek/clk-rtk-common.c b/drivers/clk/realtek/clk-rtk-common.c
> new file mode 100644
> index 0000000000000..cea7d94313daa
> --- /dev/null
> +++ b/drivers/clk/realtek/clk-rtk-common.c
[ ... ]
> +int rtk_clk_probe(struct platform_device *pdev, const struct rtk_clk_desc *desc)
> +{
[ ... ]
> +	for (i = 0; i < desc->clk_data->num; i++) {
> +		struct clk_hw *hw = desc->clk_data->hws[i];
> +
> +		if (!hw)
> +			continue;
> +
> +		ret = devm_clk_hw_register(dev, hw);

[Severity: High]
If a clock array populates unused slots with an error pointer like
ERR_PTR(-ENOENT) (which is a standard practice so of_clk_hw_onecell_get
propagates the error to consumers), will devm_clk_hw_register() try to
dereference it here since we only check for NULL?

Should this condition be updated to handle error pointers as well, perhaps
by using IS_ERR_OR_NULL(hw)?

> +		if (ret)
> +			return dev_err_probe(dev, ret, "failed to register hw of clk%d\n", i);
> +	}
[ ... ]

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260713155630.3054636-1-eleanor.lin@realtek.com?part=4