Re: [PATCH v10 10/11] clk: realtek: Add RTD1625-ISO clock controller driver

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] Unused macros RTD1625_ISO_RSTN_MAX and RTD1625_ISO_S_RSTN_MAX are defined in the clock driver.
--

--- Patch [10]: [PATCH v10 10/11] clk: realtek: Add RTD1625-ISO clock controller driver ---
commit c492e99cbe50d13329cfaeaed02f38be0c5245e8
Author: Cheng-Yu Lee <cylee12@realtek.com>

clk: realtek: Add RTD1625-ISO clock controller driver

This commit adds support for the ISO domain clock controller on the Realtek
RTD1625 SoC. It manages clocks in the always-on power domain and acts as a
parent device to register the shared reset controller as an auxiliary device.

> diff --git a/drivers/clk/realtek/clk-rtd1625-iso.c b/drivers/clk/realtek/clk-rtd1625-iso.c
> new file mode 100644
> index 0000000000000..07ff8b95db3e9
> --- /dev/null
> +++ b/drivers/clk/realtek/clk-rtd1625-iso.c
> @@ -0,0 +1,147 @@
> +// SPDX-License-Identifier: GPL-2.0-only
> +/*
> + * Copyright (C) 2024-2026 Realtek Semiconductor Corporation
> + * Author: Cheng-Yu Lee <cylee12@realtek.com>
> + */
> +
> +#include <dt-bindings/clock/realtek,rtd1625-clk.h>
> +#include <linux/array_size.h>
> +#include <linux/init.h>
> +#include <linux/module.h>
> +#include <linux/of_device.h>
> +#include <linux/platform_device.h>
> +#include "clk-regmap-gate.h"
> +
> +#define RTD1625_ISO_CLK_MAX	19
> +#define RTD1625_ISO_RSTN_MAX	29
> +#define RTD1625_ISO_S_CLK_MAX	5
> +#define RTD1625_ISO_S_RSTN_MAX	5

[Severity: Low]
This isn't a bug, but are the RTD1625_ISO_RSTN_MAX and RTD1625_ISO_S_RSTN_MAX
macros intended to be used in this file? They appear to be defined locally
here but are never referenced anywhere within the driver.

[ ... ]

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260713155630.3054636-1-eleanor.lin@realtek.com?part=10