Re: [PATCH v16 09/10] iio: imu: inv_icm42607: Add Temp Support in icm42607

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] The temperature scale and offset sysfs attributes always return -EINVAL.
--

--- Patch [9]: [PATCH v16 09/10] iio: imu: inv_icm42607: Add Temp Support in icm42607 ---
commit 5c22145efbd1dae68fedacdc2fc8522da3f2f320
Author: Chris Morgan <macromorgan@hotmail.com>

iio: imu: inv_icm42607: Add Temp Support in icm42607

This commit adds functions for reading temperature sensor data to the
inv_icm42607 driver.

> diff --git a/drivers/iio/imu/inv_icm42607/inv_icm42607_accel.c b/drivers/iio/imu/inv_icm42607/inv_icm42607_accel.c
> --- a/drivers/iio/imu/inv_icm42607/inv_icm42607_accel.c
> +++ b/drivers/iio/imu/inv_icm42607/inv_icm42607_accel.c
[ ... ]
> @@ -186,6 +189,9 @@ static int inv_icm42607_accel_read_raw(struct iio_dev *indio_dev,
>  
>  	switch (mask) {
>  	case IIO_CHAN_INFO_RAW:
> +		if (chan->type == IIO_TEMP)
> +			return inv_icm42607_temp_read_raw(indio_dev, chan,
> +							  val, val2, mask);

[Severity: Medium]
Since this check is nested inside case IIO_CHAN_INFO_RAW:, how are requests
for IIO_CHAN_INFO_SCALE and IIO_CHAN_INFO_OFFSET handled for the temperature
channel?

Won't those masks bypass this check, fall through to the accelerometer-specific
cases below, and ultimately return -EINVAL?

[ ... ]
> diff --git a/drivers/iio/imu/inv_icm42607/inv_icm42607_gyro.c b/drivers/iio/imu/inv_icm42607/inv_icm42607_gyro.c
> --- a/drivers/iio/imu/inv_icm42607/inv_icm42607_gyro.c
> +++ b/drivers/iio/imu/inv_icm42607/inv_icm42607_gyro.c
[ ... ]
> @@ -183,6 +186,9 @@ static int inv_icm42607_gyro_read_raw(struct iio_dev *indio_dev,
>  
>  	switch (mask) {
>  	case IIO_CHAN_INFO_RAW:
> +		if (chan->type == IIO_TEMP)
> +			return inv_icm42607_temp_read_raw(indio_dev, chan,
> +							  val, val2, mask);

[Severity: Medium]
Does this have the same routing issue as the accelerometer handler above?

It appears that requests for the temperature channel's scale and offset will
also fail with -EINVAL here, making the IIO_CHAN_INFO_SCALE and
IIO_CHAN_INFO_OFFSET cases in inv_icm42607_temp_read_raw() unreachable.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260713215842.69097-1-macroalpha82@gmail.com?part=9