Re: [PATCH v16 07/10] iio: imu: inv_icm42607: Add Accelerometer for icm42607

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] Missing update of cached sensor state `mode` causes configuration changes to inadvertently power off the sensor and breaks suspend/resume state tracking.
--

--- Patch [7]: [PATCH v16 07/10] iio: imu: inv_icm42607: Add Accelerometer for icm42607 ---
commit 599d6ae3a9166a30d7aae587e26cd1fe820357f4
Author: Chris Morgan <macromorgan@hotmail.com>

iio: imu: inv_icm42607: Add Accelerometer for icm42607
    
Add icm42607 accelerometer sensor for icm42607.

> diff --git a/drivers/iio/imu/inv_icm42607/inv_icm42607_core.c b/drivers/iio/imu/inv_icm42607/inv_icm42607_core.c
> index 303a6a0b1b21e..45e031cefd4ae 100644
> --- a/drivers/iio/imu/inv_icm42607/inv_icm42607_core.c
> +++ b/drivers/iio/imu/inv_icm42607/inv_icm42607_core.c

[ ... ]

> +static void inv_icm42607_update_config(struct inv_icm42607_sensor_conf *conf,
> +				       struct inv_icm42607_sensor_conf *oldconf,
> +				       bool *config0, bool *config1)
> +{
> +	if (conf->mode < 0)
> +		conf->mode = oldconf->mode;

[ ... ]

> +int inv_icm42607_set_sensor_conf(struct inv_icm42607_state *st,
> +				 struct inv_icm42607_sensor_conf *conf,
> +				 enum iio_chan_type chan_type)
> +{
[ ... ]
> +	if (config0) {
[ ... ]
> +		oldconf->fs = conf->fs;
> +		oldconf->odr = conf->odr;
> +	}
> +
> +	if (config1) {
[ ... ]
> +		oldconf->filter = conf->filter;
> +	}
> +
> +	switch (chan_type) {
> +	case IIO_ACCEL:
> +		return inv_icm42607_set_pwr_mgmt0(st, gyro_mode, conf->mode);
> +	case IIO_ANGL_VEL:
> +		return inv_icm42607_set_pwr_mgmt0(st, conf->mode, accel_mode);
> +	default:
> +		return -EINVAL;
> +	}
> +}

[Severity: Medium]
Does this code miss updating the cached mode (e.g., oldconf->mode = conf->mode)?

It looks like fs, odr, and filter are properly cached, but mode is not. If the
cached mode is never updated, it could permanently stay OFF.

When a configuration parameter like scale or ODR is written via sysfs,
inv_icm42607_update_config() merges the requested change with the cached
mode. If the cached mode is incorrectly seen as OFF, it could inadvertently
power off the sensor despite an active runtime PM reference. This might also
break suspend/resume state tracking which relies on this cache.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260713215842.69097-1-macroalpha82@gmail.com?part=7