Re: [PATCH v16 04/10] iio: imu: inv_icm42607: Add inv_icm42607 Core Driver

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] Configuration registers `FIFO_CONFIG2` and `FIFO_CONFIG3` are incorrectly marked as volatile, preventing them from being cached and restored by `regcache_sync()`.
--

--- Patch [4]: [PATCH v16 04/10] iio: imu: inv_icm42607: Add inv_icm42607 Core Driver ---
commit bb558c6dbdd036d405cccb1f326025519297d967
Author: Chris Morgan <macromorgan@hotmail.com>

iio: imu: inv_icm42607: Add inv_icm42607 Core Driver

This commit adds the core component of a new inv_icm42607 driver. It includes
setup functions, register definitions, and the initial functionality necessary
to compile and probe the device over an i2c bus.

> diff --git a/drivers/iio/imu/inv_icm42607/inv_icm42607_core.c b/drivers/iio/imu/inv_icm42607/inv_icm42607_core.c
> new file mode 100644
> --- /dev/null
> +++ b/drivers/iio/imu/inv_icm42607/inv_icm42607_core.c
[ ... ]
> +static bool inv_icm42607_is_volatile_reg(struct device *dev, unsigned int reg)
> +{
> +	switch (reg) {
> +	case INV_ICM42607_REG_MCLK_RDY:
> +	case INV_ICM42607_REG_SIGNAL_PATH_RESET:
> +	case INV_ICM42607_REG_TEMP_DATA1 ... INV_ICM42607_REG_APEX_DATA5:
> +	case INV_ICM42607_REG_APEX_CONFIG0:
> +	case INV_ICM42607_REG_FIFO_CONFIG2 ... INV_ICM42607_REG_FIFO_CONFIG3:

[Severity: Medium]
Should INV_ICM42607_REG_FIFO_CONFIG2 and INV_ICM42607_REG_FIFO_CONFIG3 be
marked as volatile here?

These registers hold the FIFO watermark threshold, which is static
configuration. Marking them as volatile causes any value written to them to
bypass the regmap cache.

If future functionality utilizes these registers, they will not be restored
during a regcache_sync() (such as after a soft reset or resume from
suspend), which would cause the device to lose its watermark configuration.

> +	case INV_ICM42607_REG_FIFO_LOST_PKT0 ... INV_ICM42607_REG_APEX_DATA3:
> +	case INV_ICM42607_REG_INT_STATUS_DRDY:
> +	case INV_ICM42607_REG_INT_STATUS ... INV_ICM42607_REG_FIFO_DATA:
> +		return true;
> +	}
> +
> +	return false;
> +}

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260713215842.69097-1-macroalpha82@gmail.com?part=4