[PATCH] arm64: dts: rockchip: Remove invalid rk3566-bigtreetech-cb2 property

[PATCH] arm64: dts: rockchip: Remove invalid rk3566-bigtreetech-cb2 property

[Fabio Estevam]

Remove the 'ti,rt-thr' property because it is not used nor documented
anywhere.

Signed-off-by: Fabio Estevam <festevam@gmail.com>
---
 arch/arm64/boot/dts/rockchip/rk3566-bigtreetech-cb2.dtsi | 1 -
 1 file changed, 1 deletion(-)

diff --git a/arch/arm64/boot/dts/rockchip/rk3566-bigtreetech-cb2.dtsi b/arch/arm64/boot/dts/rockchip/rk3566-bigtreetech-cb2.dtsi
index b6cf03a7ba66..542269c338da 100644
--- a/arch/arm64/boot/dts/rockchip/rk3566-bigtreetech-cb2.dtsi
+++ b/arch/arm64/boot/dts/rockchip/rk3566-bigtreetech-cb2.dtsi
@@ -569,7 +569,6 @@ tft_tp: touchscreen@48 {
 		reg = <0x48>;
 		status = "okay";
 		ti,x-plate-ohms = <660>;
-		ti,rt-thr = <3000>;
 		ti,fuzzx = <32>;
 		ti,fuzzy = <16>;
 	};
-- 
2.43.0

Re: [PATCH] arm64: dts: rockchip: Remove invalid rk3566-bigtreetech-cb2 property

[sashiko-bot]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] The patch incorrectly removes the 'ti,rt-thr' property instead of correcting it to 'ti,max-rt', permanently discarding the board designer's intended touchscreen resistance threshold.
--

--- Patch [1]: [PATCH] arm64: dts: rockchip: Remove invalid rk3566-bigtreetech-cb2 property ---
commit f09729b87ec6a8e1dd741bb9d8987b1590909b19
Author: Fabio Estevam <festevam@gmail.com>

arm64: dts: rockchip: Remove invalid rk3566-bigtreetech-cb2 property

This commit removes the ti,rt-thr property from the rk3566-bigtreetech-cb2
device tree because it is undocumented.

> diff --git a/arch/arm64/boot/dts/rockchip/rk3566-bigtreetech-cb2.dtsi b/arch/arm64/boot/dts/rockchip/rk3566-bigtreetech-cb2.dtsi
> index b6cf03a7ba66b..542269c338daf 100644
> --- a/arch/arm64/boot/dts/rockchip/rk3566-bigtreetech-cb2.dtsi
> +++ b/arch/arm64/boot/dts/rockchip/rk3566-bigtreetech-cb2.dtsi
> @@ -569,7 +569,6 @@ tft_tp: touchscreen@48 {
>  		reg = <0x48>;
>  		status = "okay";
>  		ti,x-plate-ohms = <660>;
> -		ti,rt-thr = <3000>;

[Severity: Medium]
Should this property be corrected to ti,max-rt rather than being removed?

While ti,rt-thr is indeed invalid and ignored (falling back to the default
max resistance of 4095), deleting it entirely discards the board designer's
intended touchscreen resistance threshold (3000) instead of fixing the typo.

The tsc2007 driver documents ti,max-rt for this purpose, which would
preserve the configuration intent.

>  		ti,fuzzx = <32>;
>  		ti,fuzzy = <16>;
>  	};

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260721133408.44240-1-festevam@gmail.com?part=1