From: sashiko-bot@kernel.org
To: "Aaron Kling" <webgeek1234@gmail.com>
Cc: robh@kernel.org, conor+dt@kernel.org, devicetree@vger.kernel.org
Subject: Re: [PATCH v3 1/2] dt-bindings: soc: tegra: pmc: Document Tegra210B01
Date: Thu, 23 Jul 2026 02:56:06 +0000 [thread overview]
Message-ID: <20260723025606.ABF291F000E9@smtp.kernel.org> (raw)
In-Reply-To: <20260722-t210b01-pmc-v3-1-1c5b970788f2@gmail.com>
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] Incomplete documentation of powergate differences for Tegra210B01.
--
--- Patch [1]: [PATCH v3 1/2] dt-bindings: soc: tegra: pmc: Document Tegra210B01 ---
commit 4ee623d1a1b305589950060beca1ad845d9ac09e
Author: Aaron Kling <webgeek1234@gmail.com>
dt-bindings: soc: tegra: pmc: Document Tegra210B01
This commit documents the Tegra210B01 SoC in the Tegra PMC bindings.
It notes that the hardware is very similar to the original Tegra210
but has a few powergate differences.
> diff --git a/Documentation/devicetree/bindings/soc/tegra/nvidia,tegra20-pmc.yaml b/Documentation/devicetree/bindings/soc/tegra/nvidia,tegra20-pmc.yaml
> index f516960dbbefb..8ec36c49f9594 100644
> --- a/Documentation/devicetree/bindings/soc/tegra/nvidia,tegra20-pmc.yaml
> +++ b/Documentation/devicetree/bindings/soc/tegra/nvidia,tegra20-pmc.yaml
> @@ -18,6 +18,7 @@ properties:
> - nvidia,tegra114-pmc
> - nvidia,tegra124-pmc
> - nvidia,tegra210-pmc
> + - nvidia,tegra210b01-pmc
>
> reg:
> maxItems: 1
[Severity: Low]
The commit message mentions that Tegra210B01 "has a few powergate
differences." Should the documentation table further down in this file
under the powergates property also be updated to include Tegra210B01?
Currently, the Devices Applicable table does not list the new hardware,
leaving device tree authors without a reference for its valid powergates:
Name Description Devices Applicable
--------------------------------------------------------------
3d 3D Graphics Tegra20/114/124/210
[ ... ]
--
Sashiko AI review · https://sashiko.dev/#/patchset/20260722-t210b01-pmc-v3-0-1c5b970788f2@gmail.com?part=1
next prev parent reply other threads:[~2026-07-23 2:56 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-23 2:46 [PATCH v3 0/2] soc/tegra: pmc: Add Tegra210B01 support Aaron Kling via B4 Relay
2026-07-23 2:46 ` [PATCH v3 1/2] dt-bindings: soc: tegra: pmc: Document Tegra210B01 Aaron Kling via B4 Relay
2026-07-23 2:56 ` sashiko-bot [this message]
2026-07-23 2:46 ` [PATCH v3 2/2] soc/tegra: pmc: Add Tegra210B01 support Aaron Kling via B4 Relay
2026-07-23 2:57 ` sashiko-bot
2026-07-23 4:08 ` Mikko Perttunen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260723025606.ABF291F000E9@smtp.kernel.org \
--to=sashiko-bot@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=robh@kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
--cc=webgeek1234@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox