From: Rob Herring <robh@kernel.org>
To: sashiko-reviews@lists.linux.dev
Cc: dongxuyang@eswincomputing.com, devicetree@vger.kernel.org,
conor+dt@kernel.org
Subject: Re: [PATCH v13 4/5] dt-bindings: timer: dwc: Update resets property items
Date: Fri, 24 Jul 2026 08:55:37 -0500 [thread overview]
Message-ID: <20260724135537.GA3009481-robh@kernel.org> (raw)
In-Reply-To: <20260724085553.BD3971F000E9@smtp.kernel.org>
On Fri, Jul 24, 2026 at 08:55:53AM +0000, sashiko-bot@kernel.org wrote:
> Thank you for your contribution! Sashiko AI review found 3 potential issue(s) to consider:
>
> New issues:
> - [High] The timer driver is not updated to deassert the newly allowed second reset line, which can lead to system hangs.
> - [Medium] Missing `reset-names` property prevents accurate hardware representation for partial reset implementations.
Neither of these are issues.
Rob
next prev parent reply other threads:[~2026-07-24 13:55 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-24 8:41 [PATCH v13 0/5] Update designware pwm driver dongxuyang
2026-07-24 8:43 ` [PATCH v13 1/5] dt-bindings: pwm: dwc: Document optional resets property dongxuyang
2026-07-24 8:53 ` sashiko-bot
2026-07-24 8:43 ` [PATCH v13 2/5] dt-bindings: pwm: dwc: Add eswin compatible dongxuyang
2026-07-24 8:56 ` sashiko-bot
2026-07-24 8:43 ` [PATCH v13 3/5] pwm: dwc: add of/platform support dongxuyang
2026-07-24 8:57 ` sashiko-bot
2026-07-24 8:44 ` [PATCH v13 4/5] dt-bindings: timer: dwc: Update resets property items dongxuyang
2026-07-24 8:55 ` sashiko-bot
2026-07-24 13:55 ` Rob Herring [this message]
2026-07-24 8:44 ` [PATCH v13 5/5] clocksource: dw_apb_timer: Use reset array API to handle all resets dongxuyang
2026-07-24 8:55 ` sashiko-bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260724135537.GA3009481-robh@kernel.org \
--to=robh@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dongxuyang@eswincomputing.com \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox