Re: [PATCH 1/2] dt-bindings: iio: dac: add support for mcp47a1

[Jonathan Cameron <jic23@kernel.org>]

On Tue, 21 Jul 2026 20:24:38 +0200
Joshua Crofts <joshua.crofts1@gmail.com> wrote:

> The Microchip MCP47A1 is a 6-bit volatile Digital-to-Analog converted
> which communicates via I2C.
> 
> Signed-off-by: Joshua Crofts <joshua.crofts1@gmail.com>
> ---
>  .../bindings/iio/dac/microchip,mcp47a1.yaml        | 56 ++++++++++++++++++++++
>  MAINTAINERS                                        |  6 +++
>  2 files changed, 62 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/iio/dac/microchip,mcp47a1.yaml b/Documentation/devicetree/bindings/iio/dac/microchip,mcp47a1.yaml
> new file mode 100644
> index 000000000000..3322fca03b3a
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/iio/dac/microchip,mcp47a1.yaml

> +
> +examples:
> +  - |
> +    i2c {
> +          #address-cells = <1>;
> +          #size-cells = <0>;
> +
> +          dac@2e {
> +              compatible = "microchip,mcp47a1";
> +              reg = <0x2e>;
> +              vref-supply = <&vref_regulator>;
> +              vdd-supply = <&vdd_regulator>;
> +          };
> +
> +          dac@3e {
> +              compatible = "microchip,mcp47a1";
Hi Joshua,

What is the advantage of the second example?  I'd drop it.

Thanks,

Jonathan

> +              reg = <0x3e>;
> +              vref-supply = <&vref_regulator>;
> +              vdd-supply = <&vdd_regulator>;
> +          };
> +    };
> diff --git a/MAINTAINERS b/MAINTAINERS
> index 2b1ec46c5919..b44693593b94 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -17699,6 +17699,12 @@ S:	Maintained
>  F:	Documentation/devicetree/bindings/iio/adc/microchip,mcp3911.yaml
>  F:	drivers/iio/adc/mcp3911.c
>  
> +MICROCHIP MCP47A1 DAC DRIVER
> +M:	Joshua Crofts <joshua.crofts1@gmail.com>
> +L:	linux-iio@vger.kernel.org
> +S:	Maintained
> +F:	Documentation/devicetree/bindings/iio/dac/microchip,mcp47a1.yaml
> +
>  MICROCHIP MCP9982 TEMPERATURE DRIVER
>  M:	Victor Duicu <victor.duicu@microchip.com>
>  L:	linux-hwmon@vger.kernel.org
>