Re: [PATCH v8 07/35] pinctrl: airoha: an7583: there are no muxes to enable i2c buses

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] The 'i2c' function is removed from the AN7583 pinctrl driver, but the corresponding device tree binding still lists it as a valid function.
--

--- Patch [7]: [PATCH v8 07/35] pinctrl: airoha: an7583: there are no muxes to enable i2c buses ---
commit 468f37a4e3c15517200510fff4781fc404ca25d0
Author: Mikhail Kshevetskiy <mikhail.kshevetskiy@iopsys.eu>

pinctrl: airoha: an7583: there are no muxes to enable i2c buses
    
In the AN7583 case there are no mux bits to enable i2c buses, so i2c pin
function is not necessary.

> diff --git a/drivers/pinctrl/airoha/pinctrl-airoha.c b/drivers/pinctrl/airoha/pinctrl-airoha.c
> index ffbc7b3c61812..b90917d64f158 100644
> --- a/drivers/pinctrl/airoha/pinctrl-airoha.c
> +++ b/drivers/pinctrl/airoha/pinctrl-airoha.c
> @@ -1822,7 +1822,6 @@ static const struct airoha_pinctrl_func an7583_pinctrl_funcs[] = {
>  	PINCTRL_FUNC_DESC("sipo", sipo),
>  	PINCTRL_FUNC_DESC("mdio", an7583_mdio),
>  	PINCTRL_FUNC_DESC("uart", uart),
> -	PINCTRL_FUNC_DESC("i2c", i2c),

[Severity: Medium]
Should the device tree binding for this device also be updated to prevent a
validation regression?

The documentation in Documentation/devicetree/bindings/pinctrl/airoha,an7583-pinctrl.yaml
still lists i2c as a valid function in its enum and contains a conditional block
for it:

          - if:
              properties:
                function:
                  const: i2c
            then:
              properties:
                groups:
                  enum: [i2c1]

Leaving this in the yaml file means a device tree could specify function = "i2c"
for the AN7583 SoC and pass dtbs_check, but fail at runtime because the driver
no longer supports it.

>  	PINCTRL_FUNC_DESC("jtag", jtag),
>  	PINCTRL_FUNC_DESC("pcm", pcm),
>  	PINCTRL_FUNC_DESC("spi", spi),

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260727174141.664933-1-mikhail.kshevetskiy@iopsys.eu?part=7