Re: [PATCH v8 09/35] pinctrl: airoha: an7581: fix mux/conf of pcie_reset pins

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:

Pre-existing issues:
- [High] The fix applied to `pcie_reset_func_group` for the EN7581 SoC to correct the mux polarity was missed in the corresponding `an7583_pcie_reset_func_group` for the AN7583 SoC, leaving its PCIe reset pins broken.
--

--- Patch [9]: [PATCH v8 09/35] pinctrl: airoha: an7581: fix mux/conf of pcie_reset pins ---
commit 666ae88b706b2dfd8c306248b5e161abf530d833
Author: Mikhail Kshevetskiy <mikhail.kshevetskiy@iopsys.eu>

pinctrl: airoha: an7581: fix mux/conf of pcie_reset pins

This commit fixes the pin mapping for pcie_reset pins on the AN7581 SoC to
match the datasheet. It also corrects the pcie_reset pin function to properly
configure the pins for PCIe reset rather than as GPIOs, and introduces dedicated
methods to set these pins as GPIOs or PWM.

> diff --git a/drivers/pinctrl/airoha/pinctrl-airoha.c b/drivers/pinctrl/airoha/pinctrl-airoha.c
> index b90917d64f158..8815b25edcee7 100644
> --- a/drivers/pinctrl/airoha/pinctrl-airoha.c
> +++ b/drivers/pinctrl/airoha/pinctrl-airoha.c

[ ... ]

> @@ -1431,7 +1478,7 @@ static const struct airoha_pinctrl_func_group pcie_reset_func_group[] = {
>  			AIROHA_FUNC_MUX,
>  			REG_GPIO_PON_MODE,
>  			GPIO_PCIE_RESET2_MASK,
> -			GPIO_PCIE_RESET2_MASK
> +			0
>  		},
>  		.regmap_size = 1,
>  	},

[Severity: High]
This is a pre-existing issue, but since this patch fixes the mux polarity
for the EN7581 SoC's PCIe reset function by writing 0 instead of the mask,
should the same fix be applied to an7583_pcie_reset_func_group?

Currently, an7583_pcie_reset_func_group still applies GPIO_PCIE_RESET0_MASK
to REG_GPIO_PON_MODE. If the device tree requests the pcie_reset pins
function on the AN7583 SoC during device probe, won't this incorrectly
configure the pins as GPIOs instead of PCIe reset lines, breaking PCIe
device initialization for that SoC?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260727174141.664933-1-mikhail.kshevetskiy@iopsys.eu?part=9