Re: [PATCH v8 02/35] dt-bindings: pinctrl: airoha: en7581: fix pwm pin-groups

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 2 potential issue(s) to consider:

Pre-existing issues:
- [High] The sister binding `airoha,an7583-pinctrl.yaml` is out of sync with the hardware capabilities, missing `gpio47` and `gpio48`.
- [High] Conflicting conditional constraints for the `i2c` function make the AN7583 schema unsatisfiable.
--

--- Patch [2]: [PATCH v8 02/35] dt-bindings: pinctrl: airoha: en7581: fix pwm pin-groups ---
commit 69fe8d84177a9cae3d1defe966ff7b51f98c8706
Author: Mikhail Kshevetskiy <mikhail.kshevetskiy@iopsys.eu>

dt-bindings: pinctrl: airoha: en7581: fix pwm pin-groups

According to commit 08a5af468e613b ("pinctrl: airoha: fix pwm pin function
for an7581 and an7583") there is no gpio47 pin-group, so device schema must
be fixed.

> diff --git a/Documentation/devicetree/bindings/pinctrl/airoha,en7581-pinctrl.yaml b/Documentation/devicetree/bindings/pinctrl/airoha,en7581-pinctrl.yaml
> index 0c5a7eb6d563e..12dd85b5b4105 100644
> --- a/Documentation/devicetree/bindings/pinctrl/airoha,en7581-pinctrl.yaml
> +++ b/Documentation/devicetree/bindings/pinctrl/airoha,en7581-pinctrl.yaml
> @@ -208,7 +208,7 @@ patternProperties:
>                           gpio20, gpio21, gpio22, gpio23, gpio24, gpio25,
>                           gpio26, gpio27, gpio28, gpio29, gpio30, gpio31,
>                           gpio36, gpio37, gpio38, gpio39, gpio40, gpio41,
> -                         gpio42, gpio43, gpio44, gpio45, gpio46, gpio47]
> +                         gpio42, gpio43, gpio44, gpio45, gpio46]

[Severity: High]
This isn't a bug introduced by this patch, but while you are fixing en7581,
the sister binding Documentation/devicetree/bindings/pinctrl/airoha,an7583-pinctrl.yaml
is out of sync with the hardware capabilities.

The enum list for pwm groups is missing gpio48:

Documentation/devicetree/bindings/pinctrl/airoha,an7583-pinctrl.yaml:
    ...
                         gpio42, gpio43, gpio44, gpio45, gpio46, gpio47]
    ...

Additionally, the enum list for pins is missing gpio47 and gpio48, and
maxItems is incorrectly constrained to 58 instead of 60:

Documentation/devicetree/bindings/pinctrl/airoha,an7583-pinctrl.yaml:
    ...
                     gpio41, gpio42, gpio43, gpio44, gpio45, gpio46,
                     pcie_reset0, pcie_reset1, pcie_reset2]
            minItems: 1
            maxItems: 58
    ...

Running dtbs_check on an an7583 device tree that configures gpio47 or gpio48
will fail validation. Could these constraints be updated so valid an7583
device trees can pass validation?


[Severity: High]
This is a pre-existing issue, but there are conflicting conditional constraints
for the i2c function making the an7583 schema unsatisfiable.

The allOf if properties function block checks for function: const: i2c but
expects groups: enum: [i2s]:

Documentation/devicetree/bindings/pinctrl/airoha,an7583-pinctrl.yaml:
    ...
          - if:
              properties:
                function:
                  const: i2c
            then:
              properties:
                groups:
                  enum: [i2s]
    ...

Because there is another if block that correctly requires groups to be [i2c1]
for function: const: i2c, the schema requires all matching conditions to be
satisfied simultaneously. This makes i2c impossible to satisfy and leaves i2s
unconstrained.

Should this typo be corrected to function: const: i2s to match the group?

>            - if:
>                properties:
>                  function:

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260727174141.664933-1-mikhail.kshevetskiy@iopsys.eu?part=2