Re: [PATCH v2 2/3] dt-bindings: riscv: Add Worlds per-hart properties

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 2 potential issue(s) to consider:
- [High] The CPU node schema incorrectly references the system-wide Worlds schema, bypassing strict property validation for all CPU nodes.
- [High] The schema incorrectly requires the `riscv,pmwid` property on legacy devicetrees that lack the `riscv,isa-extensions` property.
--

--- Patch [2]: [PATCH v2 2/3] dt-bindings: riscv: Add Worlds per-hart properties ---
commit 8c65780e5330e56c6e5f7b6479ae772aa1d15f0c
Author: Yu-Chien Peter Lin <peter.lin@sifive.com>

dt-bindings: riscv: Add Worlds per-hart properties

This commit adds device tree properties to describe the RISC-V Worlds
architecture. It introduces system-wide and per-hart configuration
properties for World IDs, along with schema validation rules.

> diff --git a/Documentation/devicetree/bindings/riscv/cpus.yaml b/Documentation/devicetree/bindings/riscv/cpus.yaml
> index 5feeb2203050a..5922a0307cfe0 100644
> --- a/Documentation/devicetree/bindings/riscv/cpus.yaml
> +++ b/Documentation/devicetree/bindings/riscv/cpus.yaml
> @@ -26,6 +26,7 @@ description: |
>  allOf:
>    - $ref: /schemas/cpu.yaml#
>    - $ref: extensions.yaml
> +  - $ref: worlds.yaml

[Severity: High]
Does this inclusion break the strict property validation for all CPU nodes?

Because worlds.yaml includes additionalProperties: true, JSON schema
validation will treat all properties as successfully evaluated. 

This neutralizes the unevaluatedProperties: false restriction in cpus.yaml,
allowing undocumented or typo'd properties to silently pass validation.

[ ... ]

> +  - if:
> +      allOf:
> +        - properties:
> +            riscv,isa-extensions:
> +              not:
> +                contains:
> +                  const: smwid
> +        - properties:
> +            riscv,isa-extensions:
> +              contains:
> +                enum:
> +                  - smlwid
> +                  - smwiddeleg
> +                  - sswid
> +    then:
> +      required:
> +        - riscv,pmwid

[Severity: High]
Will this erroneously require riscv,pmwid on legacy devicetrees that lack
the riscv,isa-extensions property?

In JSON Schema, a properties check automatically succeeds if the specified
property is absent. 

Without an explicit check requiring riscv,isa-extensions to be present, this
conditional evaluates to true when the property is missing. This breaks
backward compatibility with older valid devicetrees that use the deprecated
riscv,isa property.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260729163908.249838-1-peter.lin@sifive.com?part=2