Re: [PATCH v4 06/24] dt-bindings: clock: mediatek: regroup MT8192 dt-bindings into MT8186

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] The `allOf` `if-then` block incorrectly uses `enum` directly under `compatible`, failing to match device tree array values.
--

--- Patch [6]: [PATCH v4 06/24] dt-bindings: clock: mediatek: regroup MT8192 dt-bindings into MT8186 ---
commit f258fa892abdda9fb25c70a8dc0f201865aac7ab
Author: Louis-Alexis Eyraud <louisalexis.eyraud@collabora.com>

dt-bindings: clock: mediatek: regroup MT8192 dt-bindings into MT8186

This commit consolidates the MT8192 functional clock and system clock device tree bindings into the existing MT8186 bindings to ease maintainability. The dedicated MT8192 YAML files are removed, and their compatible strings are added to the MT8186 schema properties.

> diff --git a/Documentation/devicetree/bindings/clock/mediatek,mt8186-clock.yaml b/Documentation/devicetree/bindings/clock/mediatek,mt8186-clock.yaml
> index 0bc2da60a6016..b5988d122e4dd 100644
> --- a/Documentation/devicetree/bindings/clock/mediatek,mt8186-clock.yaml
> +++ b/Documentation/devicetree/bindings/clock/mediatek,mt8186-clock.yaml
> @@ -58,6 +58,26 @@ properties:
>            - mediatek,mt8188-vencsys
>            - mediatek,mt8188-wpesys
>            - mediatek,mt8188-wpesys-vpp0
> +          - mediatek,mt8192-camsys
> +          - mediatek,mt8192-camsys_rawa
> +          - mediatek,mt8192-camsys_rawb
> +          - mediatek,mt8192-camsys_rawc
> +          - mediatek,mt8192-imgsys
> +          - mediatek,mt8192-imgsys2
> +          - mediatek,mt8192-imp_iic_wrap_c
> +          - mediatek,mt8192-imp_iic_wrap_e
> +          - mediatek,mt8192-imp_iic_wrap_s
> +          - mediatek,mt8192-imp_iic_wrap_ws
> +          - mediatek,mt8192-imp_iic_wrap_w
> +          - mediatek,mt8192-imp_iic_wrap_n
> +          - mediatek,mt8192-ipesys
> +          - mediatek,mt8192-mdpsys
> +          - mediatek,mt8192-mfgcfg
> +          - mediatek,mt8192-msdc_top
> +          - mediatek,mt8192-scp_adsp
> +          - mediatek,mt8192-vdecsys_soc
> +          - mediatek,mt8192-vdecsys
> +          - mediatek,mt8192-vencsys
>  
>    reg:
>      maxItems: 1

[Severity: Medium]
In the same file under the allOf if-then block, the compatible match uses enum directly instead of contains:

allOf:
  - if:
      properties:
        compatible:
          enum:
            - mediatek,mt8188-camsys-rawa

Because the compatible property evaluates as an array in device tree schema, applying JSON schema's enum directly against the array will fail to match the string scalar values.

Should this be updated to use contains: enum: so that the constraints correctly apply to these compatible strings during validation?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260729-mt8189-clocks-system-base-v4-0-e356b813a64c@collabora.com?part=6