Re: [PATCH v3 4/8] dt-bindings: mfd: syscon: add ESWIN EIC7700 compatible

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 2 potential issue(s) to consider:
- [Medium] The new compatible string 'eswin,eic7700-syscfg' was omitted from the 'select' block's enum list in `syscon.yaml`.
- [Low] The commit message description is not capitalized, violating MFD subsystem guidelines.
--

--- Patch [4]: [PATCH v3 4/8] dt-bindings: mfd: syscon: add ESWIN EIC7700 compatible ---
commit b6fbe8a9c92251f8d7a4c290284000e71004ed87
Author: Pinkesh Vaghela <pinkesh.vaghela@einfochips.com>

dt-bindings: mfd: syscon: add ESWIN EIC7700 compatible
    
Document ESWIN EIC7700 SoC compatible for syscon registers.

> dt-bindings: mfd: syscon: add ESWIN EIC7700 compatible

[Severity: Low]
This isn't a bug, but should the commit description be capitalized after 
the subsystem prefix to match MFD subsystem guidelines, perhaps using 
"Add ESWIN EIC7700 compatible"?

[ ... ]

> diff --git a/Documentation/devicetree/bindings/mfd/syscon.yaml b/Documentation/devicetree/bindings/mfd/syscon.yaml
> index e228670880631..2bcaaba6948d3 100644
> --- a/Documentation/devicetree/bindings/mfd/syscon.yaml
> +++ b/Documentation/devicetree/bindings/mfd/syscon.yaml
> @@ -175,6 +175,7 @@ properties:
>                - cirrus,ep7209-syscon3
>                - cnxt,cx92755-uc
>                - econet,en751221-chip-scu
> +              - eswin,eic7700-syscfg

[Severity: Medium]
Does this new compatible string also need to be mirrored in the select 
block's enum list earlier in the file?

If eswin,eic7700-syscfg is omitted from the select list:

  select:
    properties:
      compatible:
        contains:
          enum:
            ...
            - econet,en751221-chip-scu
            - freecom,fsg-cs2-system-controller

will older tooling like dtschema < 2024.02 fail to select this schema as a
fallback, which could silently allow invalid configurations to pass undetected?

>                - freecom,fsg-cs2-system-controller
>                - fsl,imx93-aonmix-ns-syscfg
>                - fsl,imx93-wakeupmix-syscfg

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260804104431.1391839-1-pinkesh.vaghela@einfochips.com?part=4