[PATCH 0/4] Add front-facing camera support for Nothing Phone (1)

[PATCH 0/4] Add front-facing camera support for Nothing Phone (1)

[Danila Tikhonov]

This series adds support for the Sony IMX471 front-facing camera sensor
on the Nothing Phone (1).

The Sony IMX471 driver currently supports the sensor only on ACPI-based
platforms. To support the sensor on the Nothing Phone (1), this series
adds handling for the required vdig and vif supplies, extends the driver
for use on Devicetree-based systems, and enables the sensor as the
device's front-facing camera.

- Patch 1 adds the Sony IMX471 CMOS image sensor dt-binding.
- Patch 2 updates the Sony IMX471 sensor driver to support the required 
vdig and vif power supplies.
- Patch 3 updates the Sony IMX471 sensor driver to add Device Tree
matching support.
- Patch 4 adds and configures the nodes required to enable the Sony
IMX471 front-facing camera in the Nothing Phone (1) Device Tree.

Signed-off-by: Danila Tikhonov <danila@mainlining.org>
---
Danila Tikhonov (4):
      dt-bindings: media: i2c: Add Sony IMX471 CMOS Image Sensor
      drivers: media: i2c: imx471: Add vdig and vif power supplies
      drivers: media: i2c: imx471: Add Device Tree matching support
      arm64: dts: qcom: sm7325-nothing-spacewar: Add front camera support

 .../devicetree/bindings/media/i2c/sony,imx471.yaml | 123 +++++++++++++++++++++
 arch/arm64/boot/dts/qcom/kodiak.dtsi               |   7 ++
 .../boot/dts/qcom/sm7325-nothing-spacewar.dts      |  46 +++++++-
 drivers/media/i2c/imx471.c                         |  12 +-
 4 files changed, 186 insertions(+), 2 deletions(-)
---
base-commit: 1701fda2f58e345c050f4309971bdc07cd6146ba
change-id: 20260805-imx471-c2198b81414a

Best regards,
--  
Danila Tikhonov <danila@mainlining.org>

[PATCH 1/4] dt-bindings: media: i2c: Add Sony IMX471 CMOS Image Sensor

[Danila Tikhonov]

Document the Sony IMX471 CMOS Image Sensor.

Signed-off-by: Danila Tikhonov <danila@mainlining.org>
---
 .../devicetree/bindings/media/i2c/sony,imx471.yaml | 123 +++++++++++++++++++++
 1 file changed, 123 insertions(+)

diff --git a/Documentation/devicetree/bindings/media/i2c/sony,imx471.yaml b/Documentation/devicetree/bindings/media/i2c/sony,imx471.yaml
new file mode 100644
index 000000000000..9c6c7c55746f
--- /dev/null
+++ b/Documentation/devicetree/bindings/media/i2c/sony,imx471.yaml
@@ -0,0 +1,123 @@
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/media/i2c/sony,imx471.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Sony IMX471 CMOS Image Sensor
+
+maintainers:
+  - Danila Tikhonov <danila@mainlining.org>
+
+description: |-
+  The Sony IMX471 is a diagonal 5.822 mm (Type 1/3.09) 16-megapixel
+  back-illuminated stacked CMOS active pixel image sensor with a 4656 x 3496
+  active pixel array and 1.0 um square pixels. It uses a Quad Bayer color filter
+  array, is programmable through an I2C interface, and outputs image data
+  through MIPI CSI-2.
+
+allOf:
+  - $ref: /schemas/media/video-interface-devices.yaml#
+
+properties:
+  compatible:
+    const: sony,imx471
+
+  reg:
+    maxItems: 1
+
+  clocks:
+    description: External input clock (19.2 MHz)
+    maxItems: 1
+
+  vana-supply:
+    description: Analog power supply (2.8 V)
+
+  vdig-supply:
+    description: Digital core power supply (1.05 V)
+
+  vif-supply:
+    description: I/O interface power supply (1.8 V)
+
+  reset-gpios:
+    description: Sensor reset (XCLR) GPIO
+    maxItems: 1
+
+  port:
+    $ref: /schemas/graph.yaml#/$defs/port-base
+    unevaluatedProperties: false
+
+    properties:
+      endpoint:
+        $ref: /schemas/media/video-interfaces.yaml#
+        unevaluatedProperties: false
+
+        properties:
+          data-lanes:
+            items:
+              - const: 1
+              - const: 2
+              - const: 3
+              - const: 4
+
+          link-frequencies:
+            maxItems: 1
+            items:
+              const: 200000000
+
+        required:
+          - data-lanes
+          - link-frequencies
+
+    required:
+      - endpoint
+
+required:
+  - compatible
+  - reg
+  - clocks
+  - vana-supply
+  - vdig-supply
+  - vif-supply
+  - port
+
+unevaluatedProperties: false
+
+examples:
+  - |
+    #include <dt-bindings/clock/qcom,camcc-sc7280.h>
+    #include <dt-bindings/gpio/gpio.h>
+
+    i2c {
+        #address-cells = <1>;
+        #size-cells = <0>;
+
+        camf_imx471: camera@1a {
+            compatible = "sony,imx471";
+            reg = <0x1a>;
+
+            vana-supply = <&vreg_camf_vana_2p8>;
+            vdig-supply = <&vreg_camf_vdig_1p1>;
+            vif-supply = <&vreg_cam_vio_1p8>;
+
+            clocks = <&camcc CAM_CC_MCLK0_CLK>;
+            assigned-clocks = <&camcc CAM_CC_MCLK0_CLK>;
+            assigned-clock-rates = <19200000>;
+
+            reset-gpios = <&tlmm 20 GPIO_ACTIVE_LOW>;
+            pinctrl-0 = <&cam_mclk0_default>;
+            pinctrl-names = "default";
+
+            orientation = <0>;
+            rotation = <270>;
+
+            port {
+                camera_imx471_ep: endpoint {
+                    data-lanes = <1 2 3 4>;
+                    link-frequencies = /bits/ 64 <200000000>;
+                    remote-endpoint = <&csiphy0_ep>;
+                };
+            };
+        };
+    };
+...

-- 
2.55.0

[PATCH 2/4] drivers: media: i2c: imx471: Add vdig and vif power supplies

[Danila Tikhonov]

According to the product brief, the IMX471 sensor requires analog
(vana, 2.8V), digital (vdig, 1.05V), and interface (vif, 1.8V) power
supplies. Currently, only the analog supply is requested.

Add 'vdig' and 'vif' to the regulator supply array. Following the
pattern of other media i2c drivers (e.g., imx219, imx415), the regulator
core will automatically substitute dummy regulators if these are
missing.

Signed-off-by: Danila Tikhonov <danila@mainlining.org>
---
 drivers/media/i2c/imx471.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/drivers/media/i2c/imx471.c b/drivers/media/i2c/imx471.c
index 4053aed84340..3ad123699f14 100644
--- a/drivers/media/i2c/imx471.c
+++ b/drivers/media/i2c/imx471.c
@@ -117,7 +117,9 @@
 #define to_imx471(_sd) container_of_const(_sd, struct imx471, sd)
 
 static const char * const imx471_supply_name[] = {
-	"vana",
+	"vana", /* 2p8V */
+	"vdig", /* 1p05V */
+	"vif",  /* 1p8V */
 };
 
 struct imx471_mode {

-- 
2.55.0

[PATCH 3/4] drivers: media: i2c: imx471: Add Device Tree matching support

[Danila Tikhonov]

The IMX471 driver currently only supports probing via ACPI. Add OF
device ID table with "sony,imx471" compatible string and <linux/of.h>
header to allow probing on Device Tree based platforms.

Signed-off-by: Danila Tikhonov <danila@mainlining.org>
---
 drivers/media/i2c/imx471.c | 8 ++++++++
 1 file changed, 8 insertions(+)

diff --git a/drivers/media/i2c/imx471.c b/drivers/media/i2c/imx471.c
index 3ad123699f14..cc75664f1af4 100644
--- a/drivers/media/i2c/imx471.c
+++ b/drivers/media/i2c/imx471.c
@@ -10,6 +10,7 @@
 #include <linux/delay.h>
 #include <linux/i2c.h>
 #include <linux/module.h>
+#include <linux/of.h>
 #include <linux/pm_runtime.h>
 #include <linux/regulator/consumer.h>
 #include <media/v4l2-cci.h>
@@ -941,10 +942,17 @@ static const struct acpi_device_id imx471_acpi_ids[] __maybe_unused = {
 };
 MODULE_DEVICE_TABLE(acpi, imx471_acpi_ids);
 
+static const struct of_device_id imx471_of_match[] = {
+	{ .compatible = "sony,imx471" },
+	{ /* sentinel */ }
+};
+MODULE_DEVICE_TABLE(of, imx471_of_match);
+
 static struct i2c_driver imx471_i2c_driver = {
 	.driver = {
 		.name = "imx471",
 		.acpi_match_table = ACPI_PTR(imx471_acpi_ids),
+		.of_match_table = imx471_of_match,
 		.pm = pm_sleep_ptr(&imx471_pm_ops),
 	},
 	.probe = imx471_probe,

-- 
2.55.0

[PATCH 4/4] arm64: dts: qcom: sm7325-nothing-spacewar: Add front camera support

[Danila Tikhonov]

Add and configure the necessary nodes to enable the front camera
(Sony IMX471), connected to CSIPHY 0.

Signed-off-by: Danila Tikhonov <danila@mainlining.org>
---
 arch/arm64/boot/dts/qcom/kodiak.dtsi               |  7 ++++
 .../boot/dts/qcom/sm7325-nothing-spacewar.dts      | 46 +++++++++++++++++++++-
 2 files changed, 52 insertions(+), 1 deletion(-)

diff --git a/arch/arm64/boot/dts/qcom/kodiak.dtsi b/arch/arm64/boot/dts/qcom/kodiak.dtsi
index f2da3706d5c8..9a66e65b2271 100644
--- a/arch/arm64/boot/dts/qcom/kodiak.dtsi
+++ b/arch/arm64/boot/dts/qcom/kodiak.dtsi
@@ -5852,6 +5852,13 @@ tlmm: pinctrl@f100000 {
 			gpio-ranges = <&tlmm 0 0 175>;
 			wakeup-parent = <&pdc>;
 
+			cam_mclk0_default: cam-mclk0-default-state {
+				pins = "gpio64";
+				function = "cam_mclk";
+				drive-strength = <2>;
+				bias-disable;
+			};
+
 			cam_mclk3_default: cam-mclk3-default-state {
 				pins = "gpio67";
 				function = "cam_mclk";
diff --git a/arch/arm64/boot/dts/qcom/sm7325-nothing-spacewar.dts b/arch/arm64/boot/dts/qcom/sm7325-nothing-spacewar.dts
index 7db9ae1c3cef..272c56328686 100644
--- a/arch/arm64/boot/dts/qcom/sm7325-nothing-spacewar.dts
+++ b/arch/arm64/boot/dts/qcom/sm7325-nothing-spacewar.dts
@@ -12,6 +12,7 @@
 #include <dt-bindings/iio/qcom,spmi-adc7-pm8350b.h>
 #include <dt-bindings/iio/qcom,spmi-adc7-pmk8350.h>
 #include <dt-bindings/leds/common.h>
+#include <dt-bindings/media/video-interfaces.h>
 #include <dt-bindings/pinctrl/qcom,pmic-gpio.h>
 #include <dt-bindings/regulator/qcom,rpmh-regulator.h>
 #include <dt-bindings/sound/qcom,q6afe.h>
@@ -831,6 +832,23 @@ vreg_bob: bob {
 	};
 };
 
+&camss {
+	vdda-phy-supply = <&vreg_l10c_0p88>;
+	vdda-pll-supply = <&vreg_l6b_1p2>;
+
+	status = "okay";
+
+	ports {
+		port@0 {
+			csiphy0_ep: endpoint {
+				data-lanes = <0 1 2 3>;
+				bus-type = <MEDIA_BUS_TYPE_CSI2_DPHY>;
+				remote-endpoint = <&camera_imx471_ep>;
+			};
+		};
+	};
+};
+
 &cci0 {
 	/*
 	 * cci0_i2c1 bus is unused and GPIO 71&72 are repurposed.
@@ -843,7 +861,33 @@ &cci0 {
 };
 
 &cci0_i2c0 {
-	/* D-PHY sony,imx471 (Front) @ 0x1a */
+	camf_imx471: camera@1a {
+		compatible = "sony,imx471";
+		reg = <0x1a>;
+
+		vana-supply = <&vreg_camf_vana_2p8>;
+		vdig-supply = <&vreg_camf_vdig_1p1>;
+		vif-supply = <&vreg_cam_vio_1p8>;
+
+		clocks = <&camcc CAM_CC_MCLK0_CLK>;
+		assigned-clocks = <&camcc CAM_CC_MCLK0_CLK>;
+		assigned-clock-rates = <19200000>;
+
+		reset-gpios = <&tlmm 20 GPIO_ACTIVE_LOW>;
+		pinctrl-0 = <&cam_mclk0_default>;
+		pinctrl-names = "default";
+
+		orientation = <0>; /* Front facing */
+		rotation = <270>;
+
+		port {
+			camera_imx471_ep: endpoint {
+				data-lanes = <1 2 3 4>;
+				link-frequencies = /bits/ 64 <200000000>;
+				remote-endpoint = <&csiphy0_ep>;
+			};
+		};
+	};
 
 	camf_p24c64f: eeprom@52 {
 		compatible = "puya,p24c64f",

-- 
2.55.0

Re: [PATCH 3/4] drivers: media: i2c: imx471: Add Device Tree matching support

[sashiko-bot]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:

Pre-existing issues:
- [High] The `dev_pm_ops` structure pointer `&imx471_pm_ops` is incorrectly wrapped with `pm_sleep_ptr()`, discarding runtime PM callbacks when `CONFIG_PM_SLEEP` is disabled.
--

--- Patch [3]: [PATCH 3/4] drivers: media: i2c: imx471: Add Device Tree matching support ---
commit 0a7fa78c5d7c772d5834bc87176b5fcc9a6246db
Author: Danila Tikhonov <danila@mainlining.org>

drivers: media: i2c: imx471: Add Device Tree matching support

The IMX471 driver currently only supports probing via ACPI. This commit adds
an OF device ID table with the sony,imx471 compatible string to allow
probing on Device Tree based platforms.

> diff --git a/drivers/media/i2c/imx471.c b/drivers/media/i2c/imx471.c
> --- a/drivers/media/i2c/imx471.c
> +++ b/drivers/media/i2c/imx471.c
[ ... ]
>  static struct i2c_driver imx471_i2c_driver = {
>  	.driver = {
>  		.name = "imx471",
>  		.acpi_match_table = ACPI_PTR(imx471_acpi_ids),
> +		.of_match_table = imx471_of_match,
>  		.pm = pm_sleep_ptr(&imx471_pm_ops),

[Severity: High]
This is a pre-existing issue, but is it intended to use pm_sleep_ptr() here 
instead of pm_ptr()? 

When CONFIG_PM is enabled but CONFIG_PM_SLEEP is disabled, pm_sleep_ptr() 
evaluates to NULL. This drops the entire dev_pm_ops structure and its runtime 
PM callbacks in imx471_i2c_driver. 

Will this cause the device to permanently leak power on embedded platforms 
because the regulators and clocks are never disabled after probe or between 
streams?

>  	},
>  	.probe = imx471_probe,

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260805-imx471-v1-0-7be79f539ed8@mainlining.org?part=3

Re: [PATCH 1/4] dt-bindings: media: i2c: Add Sony IMX471 CMOS Image Sensor

[Sakari Ailus]

Hi Danila,

Thanks for the set.

On Wed, Aug 05, 2026 at 10:54:24PM +0300, Danila Tikhonov wrote:
> Document the Sony IMX471 CMOS Image Sensor.
> 
> Signed-off-by: Danila Tikhonov <danila@mainlining.org>
> ---
>  .../devicetree/bindings/media/i2c/sony,imx471.yaml | 123 +++++++++++++++++++++
>  1 file changed, 123 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/media/i2c/sony,imx471.yaml b/Documentation/devicetree/bindings/media/i2c/sony,imx471.yaml
> new file mode 100644
> index 000000000000..9c6c7c55746f
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/media/i2c/sony,imx471.yaml
> @@ -0,0 +1,123 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/media/i2c/sony,imx471.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Sony IMX471 CMOS Image Sensor
> +
> +maintainers:
> +  - Danila Tikhonov <danila@mainlining.org>
> +
> +description: |-

I believe you can drop ' |-'.

> +  The Sony IMX471 is a diagonal 5.822 mm (Type 1/3.09) 16-megapixel
> +  back-illuminated stacked CMOS active pixel image sensor with a 4656 x 3496
> +  active pixel array and 1.0 um square pixels. It uses a Quad Bayer color filter
> +  array, is programmable through an I2C interface, and outputs image data
> +  through MIPI CSI-2.
> +
> +allOf:
> +  - $ref: /schemas/media/video-interface-devices.yaml#
> +
> +properties:
> +  compatible:
> +    const: sony,imx471
> +
> +  reg:
> +    maxItems: 1
> +
> +  clocks:
> +    description: External input clock (19.2 MHz)
> +    maxItems: 1
> +
> +  vana-supply:
> +    description: Analog power supply (2.8 V)
> +
> +  vdig-supply:
> +    description: Digital core power supply (1.05 V)
> +
> +  vif-supply:
> +    description: I/O interface power supply (1.8 V)
> +
> +  reset-gpios:
> +    description: Sensor reset (XCLR) GPIO
> +    maxItems: 1
> +
> +  port:
> +    $ref: /schemas/graph.yaml#/$defs/port-base
> +    unevaluatedProperties: false
> +
> +    properties:
> +      endpoint:
> +        $ref: /schemas/media/video-interfaces.yaml#
> +        unevaluatedProperties: false
> +
> +        properties:
> +          data-lanes:
> +            items:
> +              - const: 1
> +              - const: 2
> +              - const: 3
> +              - const: 4

The sensor also supports two-lane operation.

> +
> +          link-frequencies:
> +            maxItems: 1
> +            items:
> +              const: 200000000

The sensor isn't limited to 200 MHz, is it? I just wouldn't specify it at
all.

> +
> +        required:
> +          - data-lanes
> +          - link-frequencies
> +
> +    required:
> +      - endpoint
> +
> +required:
> +  - compatible
> +  - reg
> +  - clocks
> +  - vana-supply
> +  - vdig-supply
> +  - vif-supply
> +  - port
> +
> +unevaluatedProperties: false
> +
> +examples:
> +  - |
> +    #include <dt-bindings/clock/qcom,camcc-sc7280.h>
> +    #include <dt-bindings/gpio/gpio.h>
> +
> +    i2c {
> +        #address-cells = <1>;
> +        #size-cells = <0>;
> +
> +        camf_imx471: camera@1a {
> +            compatible = "sony,imx471";
> +            reg = <0x1a>;
> +
> +            vana-supply = <&vreg_camf_vana_2p8>;
> +            vdig-supply = <&vreg_camf_vdig_1p1>;
> +            vif-supply = <&vreg_cam_vio_1p8>;
> +
> +            clocks = <&camcc CAM_CC_MCLK0_CLK>;
> +            assigned-clocks = <&camcc CAM_CC_MCLK0_CLK>;
> +            assigned-clock-rates = <19200000>;
> +
> +            reset-gpios = <&tlmm 20 GPIO_ACTIVE_LOW>;
> +            pinctrl-0 = <&cam_mclk0_default>;
> +            pinctrl-names = "default";
> +
> +            orientation = <0>;
> +            rotation = <270>;
> +
> +            port {
> +                camera_imx471_ep: endpoint {
> +                    data-lanes = <1 2 3 4>;
> +                    link-frequencies = /bits/ 64 <200000000>;
> +                    remote-endpoint = <&csiphy0_ep>;
> +                };
> +            };
> +        };
> +    };
> +...
> 

-- 
Regards,

Sakari Ailus