From: sashiko-bot@kernel.org
To: "James Hilliard" <james.hilliard1@gmail.com>
Cc: mfd@lists.linux.dev, lee@kernel.org, robh@kernel.org,
devicetree@vger.kernel.org, conor+dt@kernel.org
Subject: Re: [PATCH net-next v2 1/8] dt-bindings: net: x-powers: add AC200 EPHY control
Date: Thu, 06 Aug 2026 02:32:38 +0000 [thread overview]
Message-ID: <20260806023239.D10351F000E9@smtp.kernel.org> (raw)
In-Reply-To: <20260804-submit-acx00-of-dynamic-v1-v2-1-3eef49ff1d8c@gmail.com>
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] The YAML binding schema is missing the mandatory `examples:` section.
--
--- Patch [1]: [PATCH net-next v2 1/8] dt-bindings: net: x-powers: add AC200 EPHY control ---
commit e7e7a5a68f157d374c9eb4fdb6add2b0b9d23284
Author: James Hilliard <james.hilliard1@gmail.com>
dt-bindings: net: x-powers: add AC200 EPHY control
This commit adds the device tree binding for the X-Powers AC200 Fast Ethernet
PHY control function. It describes the control logic and an optional SoC SID
calibration cell used by the AC200 I2C regmap.
> diff --git a/Documentation/devicetree/bindings/net/x-powers,ac200-ephy-ctl.yaml b/Documentation/devicetree/bindings/net/x-powers,ac200-ephy-ctl.yaml
> new file mode 100644
> index 0000000000000..5bb60542030fc
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/net/x-powers,ac200-ephy-ctl.yaml
[ ... ]
> required:
> - compatible
>
> dependentRequired:
> nvmem-cells: [ nvmem-cell-names ]
>
> additionalProperties: false
> ...
[Severity: Low]
Is this YAML binding schema missing the examples section?
Device tree bindings typically require an examples section at the end of the
document. Without it, developers lack documentation on how to construct the
node, and the dt_binding_check tooling has no concrete representation to
validate the schema against to ensure constraints like dependentRequired work
as intended.
--
Sashiko AI review · https://sashiko.dev/#/patchset/20260804-submit-acx00-of-dynamic-v1-v2-0-3eef49ff1d8c@gmail.com?part=1
next prev parent reply other threads:[~2026-08-06 2:32 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-05 2:26 [PATCH net-next v2 0/8] net: phy: add X-Powers AC200/AC300 EPHY support James Hilliard
2026-08-05 2:26 ` [PATCH net-next v2 1/8] dt-bindings: net: x-powers: add AC200 EPHY control James Hilliard
2026-08-06 2:32 ` sashiko-bot [this message]
2026-08-05 2:27 ` [PATCH net-next v2 2/8] dt-bindings: mfd: x-powers: add AC200 James Hilliard
2026-08-06 2:32 ` sashiko-bot
2026-08-05 2:27 ` [PATCH net-next v2 3/8] mfd: add X-Powers AC200 support James Hilliard
2026-08-06 2:32 ` sashiko-bot
2026-08-05 2:27 ` [PATCH net-next v2 4/8] net: phy: add X-Powers AC200 EPHY control driver James Hilliard
2026-08-06 2:32 ` sashiko-bot
2026-08-06 9:19 ` Jagielski, Jedrzej
2026-08-05 2:27 ` [PATCH net-next v2 5/8] dt-bindings: net: x-powers: add AC300 EPHY control James Hilliard
2026-08-05 3:38 ` Rob Herring (Arm)
2026-08-05 14:17 ` Rob Herring
2026-08-06 1:36 ` James Hilliard
2026-08-06 2:32 ` sashiko-bot
2026-08-05 2:27 ` [PATCH net-next v2 6/8] net: phy: add X-Powers AC300 EPHY control driver James Hilliard
2026-08-05 12:22 ` Andrew Lunn
2026-08-06 2:32 ` sashiko-bot
2026-08-06 9:20 ` Jagielski, Jedrzej
2026-08-05 2:27 ` [PATCH net-next v2 7/8] dt-bindings: net: x-powers: add AC200/AC300 EPHY James Hilliard
2026-08-06 2:32 ` sashiko-bot
2026-08-05 2:27 ` [PATCH net-next v2 8/8] net: phy: add X-Powers AC200/AC300 EPHY driver James Hilliard
2026-08-05 12:37 ` Andrew Lunn
2026-08-06 1:28 ` James Hilliard
2026-08-06 9:21 ` Jagielski, Jedrzej
2026-08-06 2:32 ` sashiko-bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260806023239.D10351F000E9@smtp.kernel.org \
--to=sashiko-bot@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=james.hilliard1@gmail.com \
--cc=lee@kernel.org \
--cc=mfd@lists.linux.dev \
--cc=robh@kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox