Devicetree
 help / color / mirror / Atom feed
From: sashiko-bot@kernel.org
To: "James Hilliard" <james.hilliard1@gmail.com>
Cc: conor+dt@kernel.org, devicetree@vger.kernel.org,
	mfd@lists.linux.dev, lee@kernel.org, robh@kernel.org
Subject: Re: [PATCH net-next v2 7/8] dt-bindings: net: x-powers: add AC200/AC300 EPHY
Date: Thu, 06 Aug 2026 02:32:40 +0000	[thread overview]
Message-ID: <20260806023241.67B721F00A3A@smtp.kernel.org> (raw)
In-Reply-To: <20260804-submit-acx00-of-dynamic-v1-v2-7-3eef49ff1d8c@gmail.com>

> The AC200 and AC300 MDIO link interfaces report the same Clause 22
> identifier and use a compatible link-side paged register layout, but need
> different package control interfaces before that identifier can be read.
> 
> Describe the forced-ID PHY and require exactly one reference to an
> enabled AC200 or AC300 control device. The PHY node's reg value is
> programmed through the AC200 control interface. For AC300, it must match
> the address selected by the package straps and is therefore limited to 0
> through 7.
> 
> Allow a system to provide its optional two-bit SID configuration field.
> Bit 0 identifies the AC200 or AC300 package and must agree with the
> described control device. Bit 1 selects the AC300 low-calibration tuning
> sequence. Omitting the field skips package validation and selects the
> normal calibration sequence.
> 
> Also describe the optional xMII receive-clock inversion needed by some
> integrations. Requiring an X-Powers control reference distinguishes these
> integrations from the Rockchip RK630 PHY, which reports the same
> identifier.
> 
> Signed-off-by: James Hilliard <james.hilliard1@gmail.com>

Sashiko has reviewed this patch and found no issues. It looks great!

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260804-submit-acx00-of-dynamic-v1-v2-0-3eef49ff1d8c@gmail.com?part=7


  reply	other threads:[~2026-08-06  2:32 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-08-05  2:26 [PATCH net-next v2 0/8] net: phy: add X-Powers AC200/AC300 EPHY support James Hilliard
2026-08-05  2:26 ` [PATCH net-next v2 1/8] dt-bindings: net: x-powers: add AC200 EPHY control James Hilliard
2026-08-06  2:32   ` sashiko-bot
2026-08-05  2:27 ` [PATCH net-next v2 2/8] dt-bindings: mfd: x-powers: add AC200 James Hilliard
2026-08-06  2:32   ` sashiko-bot
2026-08-05  2:27 ` [PATCH net-next v2 3/8] mfd: add X-Powers AC200 support James Hilliard
2026-08-06  2:32   ` sashiko-bot
2026-08-05  2:27 ` [PATCH net-next v2 4/8] net: phy: add X-Powers AC200 EPHY control driver James Hilliard
2026-08-06  2:32   ` sashiko-bot
2026-08-06  9:19   ` Jagielski, Jedrzej
2026-08-05  2:27 ` [PATCH net-next v2 5/8] dt-bindings: net: x-powers: add AC300 EPHY control James Hilliard
2026-08-05  3:38   ` Rob Herring (Arm)
2026-08-05 14:17   ` Rob Herring
2026-08-06  1:36     ` James Hilliard
2026-08-06  2:32   ` sashiko-bot
2026-08-05  2:27 ` [PATCH net-next v2 6/8] net: phy: add X-Powers AC300 EPHY control driver James Hilliard
2026-08-05 12:22   ` Andrew Lunn
2026-08-06  2:32   ` sashiko-bot
2026-08-06  9:20   ` Jagielski, Jedrzej
2026-08-05  2:27 ` [PATCH net-next v2 7/8] dt-bindings: net: x-powers: add AC200/AC300 EPHY James Hilliard
2026-08-06  2:32   ` sashiko-bot [this message]
2026-08-05  2:27 ` [PATCH net-next v2 8/8] net: phy: add X-Powers AC200/AC300 EPHY driver James Hilliard
2026-08-05 12:37   ` Andrew Lunn
2026-08-06  1:28     ` James Hilliard
2026-08-06  9:21       ` Jagielski, Jedrzej
2026-08-06  2:32   ` sashiko-bot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260806023241.67B721F00A3A@smtp.kernel.org \
    --to=sashiko-bot@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=james.hilliard1@gmail.com \
    --cc=lee@kernel.org \
    --cc=mfd@lists.linux.dev \
    --cc=robh@kernel.org \
    --cc=sashiko-reviews@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox