Re: [PATCH 3/4] arm64: dts: st: Add UCPD node on stm32mp231

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] Duplicate unit-address for sibling NVMEM cell nodes 'package-otp@1e8' and 'atrim3@1e8'.
--

--- Patch [3]: [PATCH 3/4] arm64: dts: st: Add UCPD node on stm32mp231 ---
commit 73383f2b2e9f887b4df27458fed89459eba124e2
Author: Marek Vasut <marex@nabladev.com>

arm64: dts: st: Add UCPD node on stm32mp231

This commit adds the ST UCPD Type-C block node to the stm32mp231 device tree.
It also adds the UCPD Rp/Rd resistor trimming values as a new nvmem cell
subnode pointing to the OTP registers.

> diff --git a/arch/arm64/boot/dts/st/stm32mp231.dtsi b/arch/arm64/boot/dts/st/stm32mp231.dtsi
> index 9e1d240888ff2..5049e031a38dd 100644
> --- a/arch/arm64/boot/dts/st/stm32mp231.dtsi
> +++ b/arch/arm64/boot/dts/st/stm32mp231.dtsi
[ ... ]
> @@ -794,6 +809,11 @@ package-otp@1e8 {
>  				reg = <0x1e8 0x1>;
>  				bits = <0 3>;
>  			};
> +
> +			ucpdtrim: atrim3@1e8 {

[Severity: Low]
Does this duplicate unit address cause a dtc warning during the build?

Both package-otp and the newly added atrim3 node share the @1e8 unit address,
which violates the device tree specification requirement for unique sibling
unit addresses.

> +				reg = <0x1e8 0x4>;
> +				bits = <4 16>;
> +			};
>  		};
>  
>  		rcc: clock-controller@44200000 {

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260819163410.119755-1-marex@nabladev.com?part=3