[PATCH 0/4] arm64: dts: ti: add out-band-wakeup property to m_can devices

[PATCH 0/4] arm64: dts: ti: add out-band-wakeup property to m_can devices

[Kendall Willis]

This series adds out-of-band wakeup support for the m_can devices in the
device tree of AM62X-LP, AM62A, AM62D, and AM62P SoCs by integrating
the out-band-wakeup property.

Dependency
----------
This series depends on the "can: m_can: support out-of-band wakeup
capability" series which implements the out-of-band wakeup support in
the m_can driver and dt bindings.

Testing
-------
Tested suspend/resume with CAN wakeup on AM62P SK EVM.

Signed-off-by: Kendall Willis <k-willis@ti.com>
---
Kendall Willis (4):
      arm64: dts: ti: k3-am62-lp-sk: add out-band-wakeup property to m_can devices
      arm64: dts: ti: k3-am62a7-sk: add out-band-wakeup property to m_can devices
      arm64: dts: ti: k3-am62p5-sk: add out-band-wakeup property to m_can devices
      arm64: dts: ti: k3-am62d2-evm: add out-band-wakeup property to m_can devices

 arch/arm64/boot/dts/ti/k3-am62-lp-sk.dts | 2 ++
 arch/arm64/boot/dts/ti/k3-am62a7-sk.dts  | 2 ++
 arch/arm64/boot/dts/ti/k3-am62d2-evm.dts | 2 ++
 arch/arm64/boot/dts/ti/k3-am62p5-sk.dts  | 2 ++
 4 files changed, 8 insertions(+)
---
base-commit: 8d3ae59288f1e7d58d76558a6ee96d533bc5019f
change-id: 20260819-smth-6fb189fc148f

Best regards,
-- 
Kendall Willis <k-willis@ti.com>

[PATCH 1/4] arm64: dts: ti: k3-am62-lp-sk: add out-band-wakeup property to m_can devices

[Kendall Willis]

The m_can pins can be a wakeup source in the deepest low power states,
despite being in the MCU domain which is OFF during deeper low power
states. Add the out-band-wakeup property to allow the out_band_wakeup flag
to be enabled during suspend for m_can devices.

Signed-off-by: Kendall Willis <k-willis@ti.com>
---
 arch/arm64/boot/dts/ti/k3-am62-lp-sk.dts | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/arch/arm64/boot/dts/ti/k3-am62-lp-sk.dts b/arch/arm64/boot/dts/ti/k3-am62-lp-sk.dts
index dfd65c00f5b95bca9e3a447f3ca14ad40631e1c2..011f2f37037553d1dd8ef68d2ecad36c4e93b130 100644
--- a/arch/arm64/boot/dts/ti/k3-am62-lp-sk.dts
+++ b/arch/arm64/boot/dts/ti/k3-am62-lp-sk.dts
@@ -283,6 +283,7 @@ &gpmc0 {
 };
 
 &mcu_mcan0 {
+	out-band-wakeup;
 	pinctrl-names = "default", "wakeup";
 	pinctrl-0 = <&mcu_mcan0_tx_pins_default>, <&mcu_mcan0_rx_pins_default>;
 	pinctrl-1 = <&mcu_mcan0_tx_pins_default>, <&mcu_mcan0_rx_pins_wakeup>;
@@ -294,6 +295,7 @@ &mcu_mcan0 {
 };
 
 &mcu_mcan1 {
+	out-band-wakeup;
 	pinctrl-names = "default", "wakeup";
 	pinctrl-0 = <&mcu_mcan1_tx_pins_default>, <&mcu_mcan1_rx_pins_default>;
 	pinctrl-1 = <&mcu_mcan1_tx_pins_default>, <&mcu_mcan1_rx_pins_wakeup>;

-- 
2.34.1

Re: [PATCH 1/4] arm64: dts: ti: k3-am62-lp-sk: add out-band-wakeup property to m_can devices

[sashiko-bot]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] The `out-band-wakeup` property is added to the device tree but is completely ignored by the kernel because no driver or core code parses it.
--

--- Patch [1]: [PATCH 1/4] arm64: dts: ti: k3-am62-lp-sk: add out-band-wakeup property to m_can devices ---
commit 74f82c5ded5daaf7cf6527a753badc1049e2cd79
Author: Kendall Willis <k-willis@ti.com>

arm64: dts: ti: k3-am62-lp-sk: add out-band-wakeup property to m_can devices

This commit adds the out-band-wakeup property to the mcu_mcan0 and
mcu_mcan1 nodes in the k3-am62-lp-sk device tree. The commit message states
this allows the out_band_wakeup flag to be enabled during suspend for m_can
devices.

> diff --git a/arch/arm64/boot/dts/ti/k3-am62-lp-sk.dts b/arch/arm64/boot/dts/ti/k3-am62-lp-sk.dts
> index dfd65c00f5b95..011f2f3703755 100644
> --- a/arch/arm64/boot/dts/ti/k3-am62-lp-sk.dts
> +++ b/arch/arm64/boot/dts/ti/k3-am62-lp-sk.dts
> @@ -283,6 +283,7 @@ &gpmc0 {
>  };
>  
>  &mcu_mcan0 {
> +	out-band-wakeup;

[Severity: Medium]
Is this property parsed anywhere in the kernel?

Looking at the kernel code, there doesn't appear to be any driver or core
code that reads the out-band-wakeup property, nor does it seem to be defined
in any device tree bindings.

Without a driver (such as m_can) parsing this property and setting the flag,
the intended wakeup functionality from deep low power states will fail to
operate.

Are there missing driver changes that should accompany this device tree
modification to actually enable this feature?

>  	pinctrl-names = "default", "wakeup";
>  	pinctrl-0 = <&mcu_mcan0_tx_pins_default>, <&mcu_mcan0_rx_pins_default>;
>  	pinctrl-1 = <&mcu_mcan0_tx_pins_default>, <&mcu_mcan0_rx_pins_wakeup>;
> @@ -294,6 +295,7 @@ &mcu_mcan0 {
>  };
>  
>  &mcu_mcan1 {
> +	out-band-wakeup;
>  	pinctrl-names = "default", "wakeup";
>  	pinctrl-0 = <&mcu_mcan1_tx_pins_default>, <&mcu_mcan1_rx_pins_default>;

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260820-smth-v1-0-e1738a38d58e@ti.com?part=1

[PATCH 2/4] arm64: dts: ti: k3-am62a7-sk: add out-band-wakeup property to m_can devices

[Kendall Willis]

The m_can pins can be a wakeup source in the deepest low power states,
despite being in the MCU domain which is OFF during deeper low power
states. Add the out-band-wakeup property to allow the out_band_wakeup flag
to be enabled during suspend for m_can devices.

Signed-off-by: Kendall Willis <k-willis@ti.com>
---
 arch/arm64/boot/dts/ti/k3-am62a7-sk.dts | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/arch/arm64/boot/dts/ti/k3-am62a7-sk.dts b/arch/arm64/boot/dts/ti/k3-am62a7-sk.dts
index 821a9705bb7d42091d4ad0e68d8769b49c115bcd..27ab51a6f261b32d5d1c3ef3175bd6c5347efd4c 100644
--- a/arch/arm64/boot/dts/ti/k3-am62a7-sk.dts
+++ b/arch/arm64/boot/dts/ti/k3-am62a7-sk.dts
@@ -906,6 +906,7 @@ AM62AX_IOPAD(0x008, PIN_INPUT, 0) /* (J24) OSPI0_DQS */
 };
 
 &mcu_mcan0 {
+	out-band-wakeup;
 	pinctrl-names = "default", "wakeup";
 	pinctrl-0 = <&mcu_mcan0_tx_pins_default>, <&mcu_mcan0_rx_pins_default>;
 	pinctrl-1 = <&mcu_mcan0_tx_pins_default>, <&mcu_mcan0_rx_pins_wakeup>;
@@ -917,6 +918,7 @@ &mcu_mcan0 {
 };
 
 &mcu_mcan1 {
+	out-band-wakeup;
 	pinctrl-names = "default", "wakeup";
 	pinctrl-0 = <&mcu_mcan1_tx_pins_default>, <&mcu_mcan1_rx_pins_default>;
 	pinctrl-1 = <&mcu_mcan1_tx_pins_default>, <&mcu_mcan1_rx_pins_wakeup>;

-- 
2.34.1

Re: [PATCH 2/4] arm64: dts: ti: k3-am62a7-sk: add out-band-wakeup property to m_can devices

[sashiko-bot]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] The newly added `out-band-wakeup` device tree property is not defined in any bindings and is not parsed by any kernel driver or core code.
--

--- Patch [2]: [PATCH 2/4] arm64: dts: ti: k3-am62a7-sk: add out-band-wakeup property to m_can devices ---
commit 19d8465485a156bad59ccde394dc04242bee6cd4
Author: Kendall Willis <k-willis@ti.com>

arm64: dts: ti: k3-am62a7-sk: add out-band-wakeup property to m_can devices

The m_can pins can be a wakeup source in the deepest low power states,
despite being in the MCU domain which is OFF during deeper low power
states. Add the out-band-wakeup property to allow the out_band_wakeup flag
to be enabled during suspend for m_can devices.

> diff --git a/arch/arm64/boot/dts/ti/k3-am62a7-sk.dts b/arch/arm64/boot/dts/ti/k3-am62a7-sk.dts
> index 821a9705bb7d4..27ab51a6f261b 100644
> --- a/arch/arm64/boot/dts/ti/k3-am62a7-sk.dts
> +++ b/arch/arm64/boot/dts/ti/k3-am62a7-sk.dts
> @@ -906,6 +906,7 @@ AM62AX_IOPAD(0x008, PIN_INPUT, 0) /* (J24) OSPI0_DQS */
>  };
>  
>  &mcu_mcan0 {
> +	out-band-wakeup;

[Severity: Medium]
Is this new property being parsed by any kernel driver or core code?

Looking through the kernel, there doesn't appear to be any code that reads the
"out-band-wakeup" string from the device tree or calls
device_set_out_band_wakeup() based on it. Without corresponding C code to parse
this property, does this addition have any functional effect on the
out_band_wakeup flag during suspend?

>  	pinctrl-names = "default", "wakeup";
>  	pinctrl-0 = <&mcu_mcan0_tx_pins_default>, <&mcu_mcan0_rx_pins_default>;
>  	pinctrl-1 = <&mcu_mcan0_tx_pins_default>, <&mcu_mcan0_rx_pins_wakeup>;
> @@ -917,6 +918,7 @@ &mcu_mcan0 {
>  };
>  
>  &mcu_mcan1 {
> +	out-band-wakeup;

[Severity: Medium]
Same question here, does the kernel currently consume this property for
mcu_mcan1 to enable the wakeup functionality described in the commit message?

>  	pinctrl-names = "default", "wakeup";
>  	pinctrl-0 = <&mcu_mcan1_tx_pins_default>, <&mcu_mcan1_rx_pins_default>;
>  	pinctrl-1 = <&mcu_mcan1_tx_pins_default>, <&mcu_mcan1_rx_pins_wakeup>;

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260820-smth-v1-0-e1738a38d58e@ti.com?part=2

[PATCH 3/4] arm64: dts: ti: k3-am62p5-sk: add out-band-wakeup property to m_can devices

[Kendall Willis]

The m_can pins can be a wakeup source in the deepest low power states,
despite being in the MCU domain which is OFF during deeper low power
states. Add the out-band-wakeup property to allow the out_band_wakeup flag
to be enabled during suspend for m_can devices.

Signed-off-by: Kendall Willis <k-willis@ti.com>
---
 arch/arm64/boot/dts/ti/k3-am62p5-sk.dts | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/arch/arm64/boot/dts/ti/k3-am62p5-sk.dts b/arch/arm64/boot/dts/ti/k3-am62p5-sk.dts
index b770ed82be9d8f5827c49ed871351a6423db8026..aa7314e8310830eb2281de7224b996ac2e638a69 100644
--- a/arch/arm64/boot/dts/ti/k3-am62p5-sk.dts
+++ b/arch/arm64/boot/dts/ti/k3-am62p5-sk.dts
@@ -815,6 +815,7 @@ &epwm1 {
 };
 
 &mcu_mcan0 {
+	out-band-wakeup;
 	pinctrl-names = "default", "wakeup";
 	pinctrl-0 = <&mcu_mcan0_tx_pins_default>, <&mcu_mcan0_rx_pins_default>;
 	pinctrl-1 = <&mcu_mcan0_tx_pins_default>, <&mcu_mcan0_rx_pins_wakeup>;
@@ -826,6 +827,7 @@ &mcu_mcan0 {
 };
 
 &mcu_mcan1 {
+	out-band-wakeup;
 	pinctrl-names = "default", "wakeup";
 	pinctrl-0 = <&mcu_mcan1_tx_pins_default>, <&mcu_mcan1_rx_pins_default>;
 	pinctrl-1 = <&mcu_mcan1_tx_pins_default>, <&mcu_mcan1_rx_pins_wakeup>;

-- 
2.34.1

Re: [PATCH 3/4] arm64: dts: ti: k3-am62p5-sk: add out-band-wakeup property to m_can devices

[sashiko-bot]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] The `out-band-wakeup` property is added to the device tree but is neither parsed by any kernel C code nor documented in device tree bindings, rendering it functionally inert.
--

--- Patch [3]: [PATCH 3/4] arm64: dts: ti: k3-am62p5-sk: add out-band-wakeup property to m_can devices ---
commit 4ca80a2e891d70e706f8bb44ea395ee00e41e9dc
Author: Kendall Willis <k-willis@ti.com>

arm64: dts: ti: k3-am62p5-sk: add out-band-wakeup property to m_can devices

This commit adds the out-band-wakeup property to the mcu_mcan0 and mcu_mcan1
nodes in the k3-am62p5-sk device tree. The intent is to enable the
out_band_wakeup flag during suspend so the devices can serve as wakeup
sources from deep low-power states.

> diff --git a/arch/arm64/boot/dts/ti/k3-am62p5-sk.dts b/arch/arm64/boot/dts/ti/k3-am62p5-sk.dts
> --- a/arch/arm64/boot/dts/ti/k3-am62p5-sk.dts
> +++ b/arch/arm64/boot/dts/ti/k3-am62p5-sk.dts
[ ... ]
> @@ -815,6 +815,7 @@ &epwm1 {
>  };
>  
>  &mcu_mcan0 {
> +	out-band-wakeup;

[Severity: Medium]
Is this property parsed by any driver code in the kernel?

The commit message indicates this allows the out_band_wakeup flag to be
enabled during suspend, but there does not appear to be any C code that
actually parses the out-band-wakeup property from the device tree to apply
this flag.

Without driver support to parse this, the property will remain inert. Does
this rely on a separate driver patch that is missing from this series?

Additionally, is this property documented in the device tree bindings? If
not, it will trigger dtbs_check validation errors.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260820-smth-v1-0-e1738a38d58e@ti.com?part=3

[PATCH 4/4] arm64: dts: ti: k3-am62d2-evm: add out-band-wakeup property to m_can devices

[Kendall Willis]

The m_can pins can be a wakeup source in the deepest low power states,
despite being in the MCU domain which is OFF during deeper low power
states. Add the out-band-wakeup property to allow the out_band_wakeup flag
to be enabled during suspend for m_can devices.

Signed-off-by: Kendall Willis <k-willis@ti.com>
---
 arch/arm64/boot/dts/ti/k3-am62d2-evm.dts | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/arch/arm64/boot/dts/ti/k3-am62d2-evm.dts b/arch/arm64/boot/dts/ti/k3-am62d2-evm.dts
index f5ceb6a1b5debabf1ead67eea634b48db1540186..7f3c50a56ea87ea576e7e7a547932ede94f256ec 100644
--- a/arch/arm64/boot/dts/ti/k3-am62d2-evm.dts
+++ b/arch/arm64/boot/dts/ti/k3-am62d2-evm.dts
@@ -789,6 +789,7 @@ &c7x_0 {
 };
 
 &mcu_mcan0 {
+	out-band-wakeup;
 	pinctrl-names = "default", "wakeup";
 	pinctrl-0 = <&mcu_mcan0_tx_pins_default>, <&mcu_mcan0_rx_pins_default>;
 	pinctrl-1 = <&mcu_mcan0_tx_pins_default>, <&mcu_mcan0_rx_pins_wakeup>;
@@ -800,6 +801,7 @@ &mcu_mcan0 {
 };
 
 &mcu_mcan1 {
+	out-band-wakeup;
 	pinctrl-names = "default", "wakeup";
 	pinctrl-0 = <&mcu_mcan1_tx_pins_default>, <&mcu_mcan1_rx_pins_default>;
 	pinctrl-1 = <&mcu_mcan1_tx_pins_default>, <&mcu_mcan1_rx_pins_wakeup>;

-- 
2.34.1

Re: [PATCH 4/4] arm64: dts: ti: k3-am62d2-evm: add out-band-wakeup property to m_can devices

[sashiko-bot]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] The `out-band-wakeup` device tree property is added to `m_can` devices, but no C code in the kernel parses this property, making it completely inert. The commit message states this property is intended to allow the `out_band_wakeup` flag to be enabled during suspend. However, an exhaustive search of the kernel source confirms the string `"out-band-wakeup"` is not present in any C code, nor is it documented in the DT bindings. Neither the generic driver core nor the `m_can` driver reads this property or calls `device_set_out_band_wakeup()`. As a result, `dev->power.out_band_wakeup` will remain false, and the intended out-of-band wakeup functionality will not operate.
--

--- Patch [4]: [PATCH 4/4] arm64: dts: ti: k3-am62d2-evm: add out-band-wakeup property to m_can devices ---
commit 7f02e9c8c4b2476d4793985a8f2b56891c451cf2
Author: Kendall Willis <k-willis@ti.com>

arm64: dts: ti: k3-am62d2-evm: add out-band-wakeup property to m_can devices

This commit adds the out-band-wakeup property to the mcu_mcan0 and mcu_mcan1
nodes in the k3-am62d2-evm device tree. It intends to enable the
out_band_wakeup flag during suspend for these devices.

> diff --git a/arch/arm64/boot/dts/ti/k3-am62d2-evm.dts b/arch/arm64/boot/dts/ti/k3-am62d2-evm.dts
> index f5ceb6a1b5deb..7f3c50a56ea87 100644
> --- a/arch/arm64/boot/dts/ti/k3-am62d2-evm.dts
> +++ b/arch/arm64/boot/dts/ti/k3-am62d2-evm.dts
> @@ -789,6 +789,7 @@ &c7x_0 {
>  };
>  
>  &mcu_mcan0 {
> +	out-band-wakeup;

[Severity: Medium]
Is the "out-band-wakeup" property actually parsed by the kernel?

Looking through the kernel source, there doesn't appear to be any C code
that parses the "out-band-wakeup" string, nor does it seem to be documented
in the DT bindings.

Neither the generic driver core nor the m_can driver appears to read this
property or call device_set_out_band_wakeup(), which would leave
dev->power.out_band_wakeup as false and prevent the intended out-of-band
wakeup functionality from operating.

Does this patch rely on another driver change that hasn't been merged yet?

>  	pinctrl-names = "default", "wakeup";
>  	pinctrl-0 = <&mcu_mcan0_tx_pins_default>, <&mcu_mcan0_rx_pins_default>;
>  	pinctrl-1 = <&mcu_mcan0_tx_pins_default>, <&mcu_mcan0_rx_pins_wakeup>;

[ ... ]

> @@ -800,6 +801,7 @@ &mcu_mcan0 {
>  };
>  
>  &mcu_mcan1 {
> +	out-band-wakeup;

[Severity: Medium]
Will this face the same issue where the property is ignored by the kernel?

>  	pinctrl-names = "default", "wakeup";
>  	pinctrl-0 = <&mcu_mcan1_tx_pins_default>, <&mcu_mcan1_rx_pins_default>;
>  	pinctrl-1 = <&mcu_mcan1_tx_pins_default>, <&mcu_mcan1_rx_pins_wakeup>;

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260820-smth-v1-0-e1738a38d58e@ti.com?part=4