Re: [PATCH 7/7] dt-bindings: beagle: Add BeagleConnect Freedom

[Conor Dooley <conor@kernel.org>]

[-- Attachment #1: Type: text/plain, Size: 3024 bytes --]

On Fri, Aug 21, 2026 at 11:01:16AM +0530, Ayush Singh wrote:
> On 8/21/26 12:03 AM, Conor Dooley wrote:
> 
> > On Thu, Aug 20, 2026 at 02:55:49PM +0530, Ayush Singh wrote:
> > > Add devicetree bindings for the BeagleBoard.org BeagleConnect Freedom,
> > > a wireless-enabled board based on the TI CC1352P7. The board exposes an
> > > MCU that can be attached to a host over USB, UART, SPI or I2C, and is
> > > described as a child node of the corresponding bus.
> > > 
> > > Signed-off-by: Ayush Singh <ayush@beagleboard.org>
> > > ---
> > >   .../beagle/beagle,beagleconnect-freedom.yaml       | 30 ++++++++++++++++++++++
> > >   MAINTAINERS                                        |  1 +
> > >   2 files changed, 31 insertions(+)
> > > 
> > > diff --git a/Documentation/devicetree/bindings/beagle/beagle,beagleconnect-freedom.yaml b/Documentation/devicetree/bindings/beagle/beagle,beagleconnect-freedom.yaml
> > > new file mode 100644
> > > index 000000000000..5a246f81261e
> > > --- /dev/null
> > > +++ b/Documentation/devicetree/bindings/beagle/beagle,beagleconnect-freedom.yaml
> > > @@ -0,0 +1,30 @@
> > > +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause
> > > +%YAML 1.2
> > > +---
> > > +$id: http://devicetree.org/schemas/beagle/beagle,beagleconnect-freedom.yaml#
> > > +$schema: http://devicetree.org/meta-schemas/core.yaml#
> > > +
> > > +title: BeagleBoard.org BeagleConnect Freedom
> > > +
> > > +description:
> > > +  The BeagleBoard.org BeagleConnect Freedom board connected over USB, UART, SPI or I2C.
> > > +
> > > +maintainers:
> > > +  - Ayush Singh <ayush@beagleboard.org>
> > > +
> > > +properties:
> > > +  compatible:
> > > +    const: beagle,beagleconnect-freedom
> > These compatible only devices always look suspect to me, I feel like
> > these things probably at least have an optional regulator if the power
> > source for the freedom is provided by the device running linux.
> 
> Well, the power source can be provided, yes, so will add that. In my
> testing, I was powering the BeagleConnect Freedom [0] via USB to view logs.
> 
> 
> > You're also short the required properties for dealing with anything
> > other than uart, so spi or i2c. (I assume USB doesn't need devicetree to
> > function).
> 
> I have only tested with UART at the moment. Is just having
> `additional_properties: true` sufficient? I think the reg property is the

No, only bindings intended to be included by others should have that.
You should ref spi-peripheral-props if anything is relevant and have
"{additional,unevaluated}Properties: false" depending on whether or not
anything other than reg is.

> only thing SPI and I2C will require setting here.

Ye, then add a "reg: maxItems: 1" for those cases then.

pw-bot: changes-requested

Cheers,
Conor.

> 
> 
> > pw-bot: changes-requested
> > 
> > Thanks,
> > Conor.
> 
> 
> Best Regards,
> 
> Ayush Singh
> 
> 
> [0]: https://www.beagleboard.org/boards/beagleconnect-freedom
> 

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]