Re: [PATCH v5 01/17] dt-bindings: rtc: renesas,rzn1-rtc: Add RZ/T2H and RZ/N2H support

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] The RZ/T2H variant introduces a clock provider capability (1Hz output), but the binding schema omits the mandatory `#clock-cells` property.
--

--- Patch [1]: [PATCH v5 01/17] dt-bindings: rtc: renesas,rzn1-rtc: Add RZ/T2H and RZ/N2H support ---
commit 61200b5bfde6a5793e723c5af2c3129b5a618eae
Author: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
Subject: dt-bindings: rtc: renesas,rzn1-rtc: Add RZ/T2H and RZ/N2H support

This commit adds compatible strings and clock requirements for the RTC 
block on Renesas RZ/T2H and RZ/N2H SoCs. It also notes that the RZ/T2H 
RTC variant supports a 1Hz output signal on the RTCAT1HZ pin.

> diff --git a/Documentation/devicetree/bindings/rtc/renesas,rzn1-rtc.yaml b/Documentation/devicetree/bindings/rtc/renesas,rzn1-rtc.yaml
> index 1860f0e4c31a2..ea7b039a91e77 100644
> --- a/Documentation/devicetree/bindings/rtc/renesas,rzn1-rtc.yaml
> +++ b/Documentation/devicetree/bindings/rtc/renesas,rzn1-rtc.yaml
[ ... ]
> @@ -54,6 +58,23 @@ required:
>    - clock-names
>    - power-domains
>  
> +allOf:
> +  - $ref: rtc.yaml#
> +
> +  - if:
> +      properties:
> +        compatible:
> +          contains:
> +            enum:
> +              - renesas,r9a09g077-rtc
> +              - renesas,r9a09g087-rtc
> +    then:
> +      properties:
> +        clocks:
> +          minItems: 2
> +        clock-names:
> +          minItems: 2

[Severity: Medium]
The commit message mentions that the RZ/T2H variant supports a 1Hz
output signal, which acts as a clock provider. Should this conditional
block also define and require the #clock-cells property for this variant?

When a hardware variant adds a clock provider capability, the device tree
binding guidelines expect #clock-cells to be documented and constrained 
(for example, #clock-cells: const: 0). 

Since unevaluatedProperties is set to false in this binding, if a device
tree node attempts to expose and use this 1Hz output by providing
#clock-cells, will it fail schema validation?

> +
>  unevaluatedProperties: false
>  
>  examples:

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260821135608.275233-1-prabhakar.mahadev-lad.rj@bp.renesas.com?part=1