Re: [PATCH v5 16/17] rtc: rzn1: Drop trailing comma from OF match table sentinel

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] The commit message claims to 'mark it explicitly as the sentinel', but no explicit marker (such as a `/* sentinel */` comment) is added to the code.
--

--- Patch [16]: [PATCH v5 16/17] rtc: rzn1: Drop trailing comma from OF match table sentinel ---
commit 6102085fc7a0622a82be53791f34e44f2573ec8b
Author: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>

rtc: rzn1: Drop trailing comma from OF match table sentinel

This commit drops the trailing comma from the final empty entry in the RZN1
RTC OF match table.

> diff --git a/drivers/rtc/rtc-rzn1.c b/drivers/rtc/rtc-rzn1.c
> index 35770bff129ff..75713e7b045b0 100644
> --- a/drivers/rtc/rtc-rzn1.c
> +++ b/drivers/rtc/rtc-rzn1.c
> @@ -528,7 +528,7 @@ static const struct rzn1_rtc_data rzn1_rtc_rzn1_data = {
>  
>  static const struct of_device_id rzn1_rtc_of_match[] = {
>  	{ .compatible	= "renesas,rzn1-rtc", .data = &rzn1_rtc_rzn1_data },
> -	{},
> +	{}

[Severity: Low]
This isn't a bug, but the commit message claims to mark it explicitly as the
sentinel. Should there be a /* sentinel */ comment added here to match the
description in the commit message?

>  };
>  MODULE_DEVICE_TABLE(of, rzn1_rtc_of_match);

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260821135608.275233-1-prabhakar.mahadev-lad.rj@bp.renesas.com?part=16