Devicetree
 help / color / mirror / Atom feed
From: Paul Elder <paul.elder@ideasonboard.com>
To: Mauro Carvalho Chehab <mchehab@kernel.org>,
	 Heiko Stuebner <heiko@sntech.de>,
	Dafna Hirschfeld <dafna@fastmail.com>,
	 Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
	 Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	 Conor Dooley <conor+dt@kernel.org>,
	michael.riesch@collabora.com,  stefan.klug@ideasonboard.com,
	mehdi.djait@linux.intel.com,  xuhf@rock-chips.com,
	zyc@rock-chips.com, dalong.deng@rock-chips.com
Cc: linux-kernel@vger.kernel.org, linux-media@vger.kernel.org,
	 linux-arm-kernel@lists.infradead.org,
	linux-rockchip@lists.infradead.org,  devicetree@vger.kernel.org,
	Paul Elder <paul.elder@ideasonboard.com>
Subject: [PATCH v3 0/5] media: rockchip: rkisp2: Add driver for ISP on Rk3588
Date: Thu, 27 Aug 2026 19:48:29 +0900	[thread overview]
Message-ID: <20260827-rkisp2-v3-0-e91ff0a604d6@ideasonboard.com> (raw)

Hello everyone!

This patch series adds a new rkisp2 driver that aims to support all
Rockchip 2.x and 3.x series ISPs. Here we add support for the version on
the RK3588, which as far as I'm aware is a 3.0.

Patches 1 and 2 add dt bindings and dt nodes; patches 3~5 add the actual
driver.

Notable changes from the RFC version:
- fixed a couple potential page fault storms
- use extensible stats (previously only params were extensible)
- no more subdev pad crops; all cropping has been moved to parameter
  buffers so that they can be configured synchronously
- the DMA RX sink pads and the main/self path source pads on the ISP
  subdev have been split into individual pads
- an unused sink pad has been allocated on the ISP subdev for future
  inline mode support (to prevent uapi from changing)

Changes in v3:
- add explicit padding to uapi structs
- reorder patches so that dt goes last
- move uapi header to a nicer location

This series is based on the latest version (v7.2-rc1) (at the time of
posting) of media-commiters/next [0], with some patches on top for
testing on the Orange Pi CM5 Base with an imx708. I have a branch [1]
that integrates this series on top of said patches and
media-committers/next.

Corresponding libcamera patches+branch will be coming soon (within
minutes), but since I cannot send and link these simultanously, you will
have to search the libcamera mailing list :) I'll be sending a v3 to
match the driver v3.

[0] https://gitlab.freedesktop.org/linux-media/media-committers/-/tree/4900cad020c0580dfb1be27776ff10a4ef110cfa
[1] https://git.ideasonboard.com/epaul/linux/src/branch/epaul/v7.2-rc1/rk3588/rkisp2/upstream-v3

To: Mauro Carvalho Chehab <mchehab@kernel.org>
To: Heiko Stuebner <heiko@sntech.de>
To: Dafna Hirschfeld <dafna@fastmail.com>
To: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: Rob Herring <robh@kernel.org>
To: Krzysztof Kozlowski <krzk+dt@kernel.org>
To: Conor Dooley <conor+dt@kernel.org>
To: michael.riesch@collabora.com
To: stefan.klug@ideasonboard.com
To: mehdi.djait@linux.intel.com
To: xuhf@rock-chips.com
To: zyc@rock-chips.com
To: dalong.deng@rock-chips.com
Cc: linux-kernel@vger.kernel.org
Cc: linux-media@vger.kernel.org
Cc: linux-arm-kernel@lists.infradead.org
Cc: linux-rockchip@lists.infradead.org
Cc: devicetree@vger.kernel.org

Signed-off-by: Paul Elder <paul.elder@ideasonboard.com>
---
Paul Elder (3):
      media: rkisp2: Add parameters output video node
      media: rkisp2: Add statistics capture video node
      dt-bindings: media: Add rockchip rkisp2

Xu Hongfei (2):
      media: rockchip: rkisp2: Add rkisp2 driver
      arm64: dts: rockchip: add ISP nodes to rk3588

 .../devicetree/bindings/media/rockchip-isp2.yaml   |  125 +
 .../userspace-api/media/v4l/meta-formats.rst       |    1 +
 .../userspace-api/media/v4l/metafmt-rkisp2.rst     |  112 +
 MAINTAINERS                                        |   10 +
 arch/arm64/boot/dts/rockchip/rk3588-base.dtsi      |   57 +
 drivers/media/platform/rockchip/Kconfig            |    1 +
 drivers/media/platform/rockchip/Makefile           |    1 +
 drivers/media/platform/rockchip/rkisp2/Kconfig     |   19 +
 drivers/media/platform/rockchip/rkisp2/Makefile    |   14 +
 .../platform/rockchip/rkisp2/rkisp2-capture.c      | 1540 +++++++++
 .../media/platform/rockchip/rkisp2/rkisp2-common.c |  180 +
 .../media/platform/rockchip/rkisp2/rkisp2-common.h |  620 ++++
 .../media/platform/rockchip/rkisp2/rkisp2-debug.c  |  234 ++
 .../media/platform/rockchip/rkisp2/rkisp2-dev.c    |  372 +++
 .../media/platform/rockchip/rkisp2/rkisp2-dmarx.c  |  706 ++++
 .../media/platform/rockchip/rkisp2/rkisp2-isp.c    |  839 +++++
 .../media/platform/rockchip/rkisp2/rkisp2-params.c | 1167 +++++++
 .../platform/rockchip/rkisp2/rkisp2-regs-v2x.h     | 2625 +++++++++++++++
 .../platform/rockchip/rkisp2/rkisp2-regs-v3x.h     | 3428 ++++++++++++++++++++
 .../media/platform/rockchip/rkisp2/rkisp2-regs.h   | 1736 ++++++++++
 .../platform/rockchip/rkisp2/rkisp2-resizer.c      |  407 +++
 .../media/platform/rockchip/rkisp2/rkisp2-stats.c  |  509 +++
 drivers/media/v4l2-core/v4l2-ioctl.c               |    2 +
 include/uapi/linux/media/rockchip/rkisp2-config.h  |  643 ++++
 include/uapi/linux/rkisp1-config.h                 |    1 +
 include/uapi/linux/videodev2.h                     |    4 +
 26 files changed, 15353 insertions(+)
---
base-commit: 7517ffce3b70c999f6038fc87d4811004d994d25
change-id: 20260826-rkisp2-cd295f7eae4a

Best regards,
-- 
Paul Elder <paul.elder@ideasonboard.com>


             reply	other threads:[~2026-08-27 10:48 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-08-27 10:48 Paul Elder [this message]
2026-08-27 10:48 ` [PATCH v3 1/5] media: rockchip: rkisp2: Add rkisp2 driver Paul Elder
2026-08-27 10:48 ` [PATCH v3 2/5] media: rkisp2: Add parameters output video node Paul Elder
2026-08-27 11:05   ` sashiko-bot
2026-08-27 10:48 ` [PATCH v3 3/5] media: rkisp2: Add statistics capture " Paul Elder
2026-08-27 11:08   ` sashiko-bot
2026-08-27 10:48 ` [PATCH v3 4/5] dt-bindings: media: Add rockchip rkisp2 Paul Elder
2026-08-27 10:57   ` sashiko-bot
2026-08-27 16:43   ` Conor Dooley
2026-08-27 10:48 ` [PATCH v3 5/5] arm64: dts: rockchip: add ISP nodes to rk3588 Paul Elder
2026-08-27 10:57   ` sashiko-bot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260827-rkisp2-v3-0-e91ff0a604d6@ideasonboard.com \
    --to=paul.elder@ideasonboard.com \
    --cc=conor+dt@kernel.org \
    --cc=dafna@fastmail.com \
    --cc=dalong.deng@rock-chips.com \
    --cc=devicetree@vger.kernel.org \
    --cc=heiko@sntech.de \
    --cc=krzk+dt@kernel.org \
    --cc=laurent.pinchart@ideasonboard.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-media@vger.kernel.org \
    --cc=linux-rockchip@lists.infradead.org \
    --cc=mchehab@kernel.org \
    --cc=mehdi.djait@linux.intel.com \
    --cc=michael.riesch@collabora.com \
    --cc=robh@kernel.org \
    --cc=stefan.klug@ideasonboard.com \
    --cc=xuhf@rock-chips.com \
    --cc=zyc@rock-chips.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox