Re: [PATCH v3 4/5] dt-bindings: media: Add rockchip rkisp2

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] Missing `interrupt-names` property in the `required` list allows incomplete device trees to pass schema validation but fail driver probing.
--

commit 6781ced6c9930c8c3220edc52b5934581e2961ae
Author: Paul Elder <paul.elder@ideasonboard.com>

dt-bindings: media: Add rockchip rkisp2

This commit adds device tree binding documentation for the Rockchip ISP2,
specifically introducing support for the rk3588 compatible string. It
defines the required properties, clocks, interrupts, and ports for the
image signal processing unit.

> diff --git a/Documentation/devicetree/bindings/media/rockchip-isp2.yaml b/Documentation/devicetree/bindings/media/rockchip-isp2.yaml
> new file mode 100644
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/media/rockchip-isp2.yaml
[ ... ]
> +    required:
> +      - port@0
> +
> +required:
> +  - compatible
> +  - reg
> +  - interrupts
> +  - clocks
> +  - clock-names
> +  - power-domains

[Severity: Medium]
Should interrupt-names be included in this required list to ensure incomplete
device trees do not pass schema validation?

The Rockchip ISP2 driver in drivers/media/platform/rockchip/rkisp2/rkisp2-dev.c
iterates over its statically defined rk3588_isp_isrs array, which sets the name
field for both interrupts (isp_irq and mi_irq). The driver then unconditionally
executes:

info->isrs[i].name ? platform_get_irq_byname(...) : ...

This will fail and return less than 0 if interrupt-names is absent in the
device tree, aborting the probe. Adding interrupt-names to the required
properties would enforce an accurate hardware description that matches the
strict probing requirements of the driver.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260827-rkisp2-v3-0-e91ff0a604d6@ideasonboard.com?part=4