Devicetree
 help / color / mirror / Atom feed
* [PATCH 0/2] pinctrl: qcom: Add PMAU0102 GPIO support
@ 2026-08-30  4:29 Shawn Guo
  2026-08-30  4:29 ` [PATCH 1/2] dt-bindings: pinctrl: qcom,pmic-gpio: Document " Shawn Guo
                   ` (2 more replies)
  0 siblings, 3 replies; 6+ messages in thread
From: Shawn Guo @ 2026-08-30  4:29 UTC (permalink / raw)
  To: Bartosz Golaszewski
  Cc: Bjorn Andersson, Linus Walleij, Rob Herring, Krzysztof Kozlowski,
	Conor Dooley, Manivannan Sadhasivam, Dhruvin Rajpura,
	linux-arm-msm, linux-gpio, devicetree, linux-kernel, Shawn Guo

PMAU0102 is a new PMIC used on the Qualcomm Nord platform. It exposes
a 12-GPIO block that is compatible with the existing SPMI PMIC GPIO
programming model, so support amounts to documenting and registering
a new compatible string.

Dhruvin Rajpura (2):
  dt-bindings: pinctrl: qcom,pmic-gpio: Document PMAU0102 GPIO support
  pinctrl: qcom: spmi-gpio: Add PMAU0102 GPIO support

 Documentation/devicetree/bindings/pinctrl/qcom,pmic-gpio.yaml | 3 +++
 drivers/pinctrl/qcom/pinctrl-spmi-gpio.c                      | 1 +
 2 files changed, 4 insertions(+)

-- 
2.43.0


^ permalink raw reply	[flat|nested] 6+ messages in thread

* [PATCH 1/2] dt-bindings: pinctrl: qcom,pmic-gpio: Document PMAU0102 GPIO support
  2026-08-30  4:29 [PATCH 0/2] pinctrl: qcom: Add PMAU0102 GPIO support Shawn Guo
@ 2026-08-30  4:29 ` Shawn Guo
  2026-08-30  4:39   ` sashiko-bot
  2026-08-31  9:31   ` Krzysztof Kozlowski
  2026-08-30  4:29 ` [PATCH 2/2] pinctrl: qcom: spmi-gpio: Add " Shawn Guo
  2026-09-02 10:24 ` [PATCH 0/2] pinctrl: qcom: " Bartosz Golaszewski
  2 siblings, 2 replies; 6+ messages in thread
From: Shawn Guo @ 2026-08-30  4:29 UTC (permalink / raw)
  To: Bartosz Golaszewski
  Cc: Bjorn Andersson, Linus Walleij, Rob Herring, Krzysztof Kozlowski,
	Conor Dooley, Manivannan Sadhasivam, Dhruvin Rajpura,
	linux-arm-msm, linux-gpio, devicetree, linux-kernel, Shawn Guo

From: Dhruvin Rajpura <drajpura@qti.qualcomm.com>

Add compatible string for the PMAU0102 PMIC GPIO block, which has 12
GPIOs, used on Nord platform.

Signed-off-by: Dhruvin Rajpura <drajpura@qti.qualcomm.com>
Signed-off-by: Shawn Guo <shengchao.guo@oss.qualcomm.com>
---
 Documentation/devicetree/bindings/pinctrl/qcom,pmic-gpio.yaml | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/Documentation/devicetree/bindings/pinctrl/qcom,pmic-gpio.yaml b/Documentation/devicetree/bindings/pinctrl/qcom,pmic-gpio.yaml
index c27e24cb206f..77be0690c751 100644
--- a/Documentation/devicetree/bindings/pinctrl/qcom,pmic-gpio.yaml
+++ b/Documentation/devicetree/bindings/pinctrl/qcom,pmic-gpio.yaml
@@ -57,6 +57,7 @@ properties:
           - qcom,pm8994-gpio
           - qcom,pm8998-gpio
           - qcom,pma8084-gpio
+          - qcom,pmau0102-gpio
           - qcom,pmc8180-gpio
           - qcom,pmc8180c-gpio
           - qcom,pmc8380-gpio
@@ -281,6 +282,7 @@ allOf:
               - qcom,pm8150l-gpio
               - qcom,pm8550-gpio
               - qcom,pm8550b-gpio
+              - qcom,pmau0102-gpio
               - qcom,pmc8180c-gpio
               - qcom,pmp8074-gpio
               - qcom,pms405-gpio
@@ -496,6 +498,7 @@ $defs:
                  - gpio1-gpio22 for pm8994
                  - gpio1-gpio26 for pm8998
                  - gpio1-gpio22 for pma8084
+                 - gpio1-gpio12 for pmau0102
                  - gpio1-gpio14 for pmcx0102
                  - gpio1-gpio4 for pmd8028
                  - gpio1-gpio4 for pmg1110
-- 
2.43.0


^ permalink raw reply related	[flat|nested] 6+ messages in thread

* [PATCH 2/2] pinctrl: qcom: spmi-gpio: Add PMAU0102 GPIO support
  2026-08-30  4:29 [PATCH 0/2] pinctrl: qcom: Add PMAU0102 GPIO support Shawn Guo
  2026-08-30  4:29 ` [PATCH 1/2] dt-bindings: pinctrl: qcom,pmic-gpio: Document " Shawn Guo
@ 2026-08-30  4:29 ` Shawn Guo
  2026-09-02 10:24 ` [PATCH 0/2] pinctrl: qcom: " Bartosz Golaszewski
  2 siblings, 0 replies; 6+ messages in thread
From: Shawn Guo @ 2026-08-30  4:29 UTC (permalink / raw)
  To: Bartosz Golaszewski
  Cc: Bjorn Andersson, Linus Walleij, Rob Herring, Krzysztof Kozlowski,
	Conor Dooley, Manivannan Sadhasivam, Dhruvin Rajpura,
	linux-arm-msm, linux-gpio, devicetree, linux-kernel, Shawn Guo

From: Dhruvin Rajpura <drajpura@qti.qualcomm.com>

Add support for the PMAU0102 PMIC GPIO block, which has 12 GPIOs,
used on Nord platform.

Signed-off-by: Dhruvin Rajpura <drajpura@qti.qualcomm.com>
Signed-off-by: Shawn Guo <shengchao.guo@oss.qualcomm.com>
---
 drivers/pinctrl/qcom/pinctrl-spmi-gpio.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/pinctrl/qcom/pinctrl-spmi-gpio.c b/drivers/pinctrl/qcom/pinctrl-spmi-gpio.c
index 922c27177b5a..f6dc43e27b38 100644
--- a/drivers/pinctrl/qcom/pinctrl-spmi-gpio.c
+++ b/drivers/pinctrl/qcom/pinctrl-spmi-gpio.c
@@ -1259,6 +1259,7 @@ static const struct of_device_id pmic_gpio_of_match[] = {
 	{ .compatible = "qcom,pm8994-gpio", .data = (void *) 22 },
 	{ .compatible = "qcom,pm8998-gpio", .data = (void *) 26 },
 	{ .compatible = "qcom,pma8084-gpio", .data = (void *) 22 },
+	{ .compatible = "qcom,pmau0102-gpio", .data = (void *) 12 },
 	{ .compatible = "qcom,pmc8380-gpio", .data = (void *) 10 },
 	{ .compatible = "qcom,pmcx0102-gpio", .data = (void *)14 },
 	{ .compatible = "qcom,pmd8028-gpio", .data = (void *) 4 },
-- 
2.43.0


^ permalink raw reply related	[flat|nested] 6+ messages in thread

* Re: [PATCH 1/2] dt-bindings: pinctrl: qcom,pmic-gpio: Document PMAU0102 GPIO support
  2026-08-30  4:29 ` [PATCH 1/2] dt-bindings: pinctrl: qcom,pmic-gpio: Document " Shawn Guo
@ 2026-08-30  4:39   ` sashiko-bot
  2026-08-31  9:31   ` Krzysztof Kozlowski
  1 sibling, 0 replies; 6+ messages in thread
From: sashiko-bot @ 2026-08-30  4:39 UTC (permalink / raw)
  To: Shawn Guo; +Cc: conor+dt, devicetree, robh

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] Missing main PMIC compatible string ('qcom,pmau0102') in the parent SPMI PMIC MFD binding schema.
--

commit 3791c0eb2161c16b2bc2d4e00e3124ab371b06be
Author: Dhruvin Rajpura <drajpura@qti.qualcomm.com>

dt-bindings: pinctrl: qcom,pmic-gpio: Document PMAU0102 GPIO support
    
Add compatible string for the PMAU0102 PMIC GPIO block, which has 12
GPIOs, used on Nord platform.

> diff --git a/Documentation/devicetree/bindings/pinctrl/qcom,pmic-gpio.yaml b/Documentation/devicetree/bindings/pinctrl/qcom,pmic-gpio.yaml
> index c27e24cb206fc..77be0690c751a 100644
> --- a/Documentation/devicetree/bindings/pinctrl/qcom,pmic-gpio.yaml
> +++ b/Documentation/devicetree/bindings/pinctrl/qcom,pmic-gpio.yaml
> @@ -57,6 +57,7 @@ properties:
>            - qcom,pm8994-gpio
>            - qcom,pm8998-gpio
>            - qcom,pma8084-gpio
> +          - qcom,pmau0102-gpio

[Severity: Medium]
Does the parent SPMI PMIC MFD binding schema also need to be updated?

The child GPIO node is being documented here, which implies the parent PMIC MFD
binding must also be updated with the main PMIC compatible string
(qcom,pmau0102).

If a device tree adds a node for the PMAU0102 PMIC using compatible =
"qcom,pmau0102", "qcom,spmi-pmic" and its child GPIO node, the parent node will
fail schema validation against qcom,spmi-pmic.yaml because it is undocumented.

Should the qcom,pmau0102 compatible string be added to
Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.yaml?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260830042939.144376-1-shengchao.guo@oss.qualcomm.com?part=1

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH 1/2] dt-bindings: pinctrl: qcom,pmic-gpio: Document PMAU0102 GPIO support
  2026-08-30  4:29 ` [PATCH 1/2] dt-bindings: pinctrl: qcom,pmic-gpio: Document " Shawn Guo
  2026-08-30  4:39   ` sashiko-bot
@ 2026-08-31  9:31   ` Krzysztof Kozlowski
  1 sibling, 0 replies; 6+ messages in thread
From: Krzysztof Kozlowski @ 2026-08-31  9:31 UTC (permalink / raw)
  To: Shawn Guo
  Cc: Bartosz Golaszewski, Bjorn Andersson, Linus Walleij, Rob Herring,
	Krzysztof Kozlowski, Conor Dooley, Manivannan Sadhasivam,
	Dhruvin Rajpura, linux-arm-msm, linux-gpio, devicetree,
	linux-kernel

On Sun, Aug 30, 2026 at 12:29:38PM +0800, Shawn Guo wrote:
> From: Dhruvin Rajpura <drajpura@qti.qualcomm.com>
> 
> Add compatible string for the PMAU0102 PMIC GPIO block, which has 12
> GPIOs, used on Nord platform.
> 
> Signed-off-by: Dhruvin Rajpura <drajpura@qti.qualcomm.com>
> Signed-off-by: Shawn Guo <shengchao.guo@oss.qualcomm.com>
> ---
>  Documentation/devicetree/bindings/pinctrl/qcom,pmic-gpio.yaml | 3 +++

Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>

Best regards,
Krzysztof


^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH 0/2] pinctrl: qcom: Add PMAU0102 GPIO support
  2026-08-30  4:29 [PATCH 0/2] pinctrl: qcom: Add PMAU0102 GPIO support Shawn Guo
  2026-08-30  4:29 ` [PATCH 1/2] dt-bindings: pinctrl: qcom,pmic-gpio: Document " Shawn Guo
  2026-08-30  4:29 ` [PATCH 2/2] pinctrl: qcom: spmi-gpio: Add " Shawn Guo
@ 2026-09-02 10:24 ` Bartosz Golaszewski
  2 siblings, 0 replies; 6+ messages in thread
From: Bartosz Golaszewski @ 2026-09-02 10:24 UTC (permalink / raw)
  To: Bartosz Golaszewski, Shawn Guo
  Cc: Bartosz Golaszewski, Bjorn Andersson, Linus Walleij, Rob Herring,
	Krzysztof Kozlowski, Conor Dooley, Manivannan Sadhasivam,
	Dhruvin Rajpura, linux-arm-msm, linux-gpio, devicetree,
	linux-kernel


On Sun, 30 Aug 2026 12:29:37 +0800, Shawn Guo wrote:
> PMAU0102 is a new PMIC used on the Qualcomm Nord platform. It exposes
> a 12-GPIO block that is compatible with the existing SPMI PMIC GPIO
> programming model, so support amounts to documenting and registering
> a new compatible string.
> 
> Dhruvin Rajpura (2):
>   dt-bindings: pinctrl: qcom,pmic-gpio: Document PMAU0102 GPIO support
>   pinctrl: qcom: spmi-gpio: Add PMAU0102 GPIO support
> 
> [...]

Applied, thanks!

[1/2] dt-bindings: pinctrl: qcom,pmic-gpio: Document PMAU0102 GPIO support
      https://git.kernel.org/brgl/c/25f42a33ecf914e6d8da6eed2cdf7ad86c9a904b
[2/2] pinctrl: qcom: spmi-gpio: Add PMAU0102 GPIO support
      https://git.kernel.org/brgl/c/1cc8b87bd9719f5c496d27a1b4d2892947ba70d5

Best regards,
-- 
Bartosz Golaszewski <bartosz.golaszewski@oss.qualcomm.com>

^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2026-09-02 10:24 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-08-30  4:29 [PATCH 0/2] pinctrl: qcom: Add PMAU0102 GPIO support Shawn Guo
2026-08-30  4:29 ` [PATCH 1/2] dt-bindings: pinctrl: qcom,pmic-gpio: Document " Shawn Guo
2026-08-30  4:39   ` sashiko-bot
2026-08-31  9:31   ` Krzysztof Kozlowski
2026-08-30  4:29 ` [PATCH 2/2] pinctrl: qcom: spmi-gpio: Add " Shawn Guo
2026-09-02 10:24 ` [PATCH 0/2] pinctrl: qcom: " Bartosz Golaszewski

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox