Re: [PATCH v5 1/2] dt-bindings: arm: stm32: Document st,stm32mp23/25-syscfg subnodes and cells

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 2 potential issue(s) to consider:
- [High] Backward Incompatible Schema Breakage for Existing Device Trees
- [Low] Broken Schema Reference to Non-Existent File
--

commit 03ebc2d5d17d202d6c215a130814ee9c1eb855c2
Author: Marek Vasut <marex@nabladev.com>

dt-bindings: arm: stm32: Document st,stm32mp23/25-syscfg subnodes and cells
    
The st,stm32mp23-syscfg and st,stm32mp25-syscfg can have subnodes, which
represent the USB 2.0 FEMTO-PHY. Document subnodes pattern properties and
address/size cells.

> diff --git a/Documentation/devicetree/bindings/arm/stm32/st,stm32-syscon.yaml b/Documentation/devicetree/bindings/arm/stm32/st,stm32-syscon.yaml
> index 95d2319afe235..2cce174004fe0 100644
> --- a/Documentation/devicetree/bindings/arm/stm32/st,stm32-syscon.yaml
> +++ b/Documentation/devicetree/bindings/arm/stm32/st,stm32-syscon.yaml
> @@ -39,6 +39,17 @@ properties:
>    "#clock-cells":
>      const: 0
>  
> +  "#address-cells":
> +    const: 1
> +
> +  "#size-cells":
> +    const: 1
> +
> +patternProperties:
> +  "^phy@[0-9a-f]+$":
> +    type: object
> +    $ref: /schemas/phy/st,stm32-usb2phy.yaml

[Severity: Low]
Does this reference a non-existent schema file? 

Running dt_binding_check fails because the target file 
/schemas/phy/st,stm32-usb2phy.yaml cannot be resolved, which breaks the 
schema validation tooling.

> +
>  required:
>    - compatible
>    - reg
> @@ -57,10 +68,17 @@ allOf:
>    - if:
>        properties:
>          compatible:
> -          const: st,stm32mp25-syscfg
> +          contains:
> +            enum:
> +              - st,stm32mp23-syscfg
> +              - st,stm32mp25-syscfg
>      then:
>        required:
>          - "#clock-cells"
> +        - "#address-cells"
> +        - "#size-cells"
> +        - phy@2400
> +        - phy@2800

[Severity: High]
The commit message mentions these nodes "can have subnodes", suggesting they 
should be optional. 

Making them mandatory in this conditional block will cause existing valid
device trees to fail schema validation.

For example, this existing node in arch/arm64/boot/dts/st/stm32mp251.dtsi
currently lacks these new properties:

		syscfg: syscon@44230000 {
			compatible = "st,stm32mp25-syscfg", "syscon";
			reg = <0x44230000 0x10000>;
			#clock-cells = <0>;
		};

Similar nodes exist in stm32mp231.dtsi.

Could these new required properties be made optional to avoid breaking
existing upstream device trees?

>  
>  additionalProperties: false

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260831231359.136475-1-marex@nabladev.com?part=1