From: Marek Vasut <marex@nabladev.com>
To: Conor Dooley <conor@kernel.org>
Cc: linux-arm-kernel@lists.infradead.org,
Alexandre Torgue <alexandre.torgue@foss.st.com>,
Christophe Roullier <christophe.roullier@foss.st.com>,
Conor Dooley <conor+dt@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Maxime Coquelin <mcoquelin.stm32@gmail.com>,
Raphael Gallais-Pou <raphael.gallais-pou@foss.st.com>,
Rob Herring <robh@kernel.org>,
Yannick Fertre <yannick.fertre@foss.st.com>,
devicetree@vger.kernel.org, kernel@dh-electronics.com,
linux-kernel@vger.kernel.org,
linux-stm32@st-md-mailman.stormreply.com
Subject: Re: [PATCH v5 1/2] dt-bindings: arm: stm32: Document st,stm32mp23/25-syscfg subnodes and cells
Date: Wed, 2 Sep 2026 14:24:49 +0200 [thread overview]
Message-ID: <42c3cb51-c8db-4edb-be10-92f2cba7c945@nabladev.com> (raw)
In-Reply-To: <20260901-smolder-debug-e37fdd2b3d20@spud>
On 9/1/26 8:11 PM, Conor Dooley wrote:
Hello Conor,
>> @@ -57,10 +68,17 @@ allOf:
>> - if:
>> properties:
>> compatible:
>> - const: st,stm32mp25-syscfg
>> + contains:
>> + enum:
>> + - st,stm32mp23-syscfg
>> + - st,stm32mp25-syscfg
>> then:
>> required:
>> - "#clock-cells"
>> + - "#address-cells"
>> + - "#size-cells"
>> + - phy@2400
>> + - phy@2800
>
> This looks good now, thanks.
>
> I got hung up last time though and maybe didn't notice - in addition to
> requiring these things here, should we also not forbid them on other
> platforms that don't have them? IOW, adding "else: properties: foo: false".
I did add this, and reduced the pattern in patternProperties to match
only on phy@2400 and phy@2800 so I can disable those too.
> With that, if appropriate,
> Reviewed-by: Conor Dooley <conor.dooley@microchip.com>
I will send a V6 without this tag, please have a look one more time.
Thank you for your help !
next prev parent reply other threads:[~2026-09-02 12:24 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-31 23:13 [PATCH v5 1/2] dt-bindings: arm: stm32: Document st,stm32mp23/25-syscfg subnodes and cells Marek Vasut
2026-08-31 23:13 ` [PATCH v5 2/2] soc: st: Add STM32MP2 SYSCFG driver Marek Vasut
2026-09-02 8:40 ` [Linux-stm32] " Fabrice Gasnier
2026-08-31 23:22 ` [PATCH v5 1/2] dt-bindings: arm: stm32: Document st,stm32mp23/25-syscfg subnodes and cells sashiko-bot
2026-09-01 18:11 ` Conor Dooley
2026-09-02 12:24 ` Marek Vasut [this message]
2026-09-02 8:55 ` [Linux-stm32] [PATCH v5 1/2] dt-bindings: arm: stm32: Document st, stm32mp23/25-syscfg " Fabrice Gasnier
2026-09-02 12:02 ` Marek Vasut
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=42c3cb51-c8db-4edb-be10-92f2cba7c945@nabladev.com \
--to=marex@nabladev.com \
--cc=alexandre.torgue@foss.st.com \
--cc=christophe.roullier@foss.st.com \
--cc=conor+dt@kernel.org \
--cc=conor@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=kernel@dh-electronics.com \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-stm32@st-md-mailman.stormreply.com \
--cc=mcoquelin.stm32@gmail.com \
--cc=raphael.gallais-pou@foss.st.com \
--cc=robh@kernel.org \
--cc=yannick.fertre@foss.st.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox