Re: [Linux-stm32] [PATCH v5 2/2] soc: st: Add STM32MP2 SYSCFG driver

[Fabrice Gasnier <fabrice.gasnier@foss.st.com>]

On 9/1/26 01:13, Marek Vasut wrote:
> Add trivial SYSCFG driver for ST STM32MP25xx, which binds drivers
> to its subnodes. This is currently used to bind USB PHY drivers to
> subnodes described in the SYSCFG DT node.
> 
> Signed-off-by: Marek Vasut <marex@nabladev.com>
> ---
> Cc: Alexandre Torgue <alexandre.torgue@foss.st.com>
> Cc: Christophe Roullier <christophe.roullier@foss.st.com>
> Cc: Conor Dooley <conor+dt@kernel.org>
> Cc: Krzysztof Kozlowski <krzk+dt@kernel.org>
> Cc: Marek Vasut <marex@nabladev.com>
> Cc: Maxime Coquelin <mcoquelin.stm32@gmail.com>
> Cc: Raphael Gallais-Pou <raphael.gallais-pou@foss.st.com>
> Cc: Rob Herring <robh@kernel.org>
> Cc: Yannick Fertre <yannick.fertre@foss.st.com>
> Cc: devicetree@vger.kernel.org
> Cc: kernel@dh-electronics.com
> Cc: linux-arm-kernel@lists.infradead.org
> Cc: linux-kernel@vger.kernel.org
> Cc: linux-stm32@st-md-mailman.stormreply.com
> ---
> V4: New patch
> V5: No change
> ---
>  drivers/soc/Kconfig              |  1 +
>  drivers/soc/Makefile             |  1 +
>  drivers/soc/st/Kconfig           | 12 ++++++++++++
>  drivers/soc/st/Makefile          |  1 +
>  drivers/soc/st/stm32mp2-syscfg.c | 33 ++++++++++++++++++++++++++++++++
>  5 files changed, 48 insertions(+)
>  create mode 100644 drivers/soc/st/Kconfig
>  create mode 100644 drivers/soc/st/Makefile
>  create mode 100644 drivers/soc/st/stm32mp2-syscfg.c
> 
> diff --git a/drivers/soc/Kconfig b/drivers/soc/Kconfig
> index a2d65adffb805..dfe5cec592626 100644
> --- a/drivers/soc/Kconfig
> +++ b/drivers/soc/Kconfig
> @@ -24,6 +24,7 @@ source "drivers/soc/renesas/Kconfig"
>  source "drivers/soc/rockchip/Kconfig"
>  source "drivers/soc/samsung/Kconfig"
>  source "drivers/soc/sophgo/Kconfig"
> +source "drivers/soc/st/Kconfig"
>  source "drivers/soc/sunxi/Kconfig"
>  source "drivers/soc/tegra/Kconfig"
>  source "drivers/soc/ti/Kconfig"
> diff --git a/drivers/soc/Makefile b/drivers/soc/Makefile
> index c9e689080ceb7..894bd6ebaaa4d 100644
> --- a/drivers/soc/Makefile
> +++ b/drivers/soc/Makefile
> @@ -30,6 +30,7 @@ obj-y				+= renesas/
>  obj-y				+= rockchip/
>  obj-$(CONFIG_SOC_SAMSUNG)	+= samsung/
>  obj-y				+= sophgo/
> +obj-y				+= st/
>  obj-y				+= sunxi/
>  obj-$(CONFIG_ARCH_TEGRA)	+= tegra/
>  obj-y				+= ti/
> diff --git a/drivers/soc/st/Kconfig b/drivers/soc/st/Kconfig
> new file mode 100644
> index 0000000000000..2a9d6a77be450
> --- /dev/null
> +++ b/drivers/soc/st/Kconfig
> @@ -0,0 +1,12 @@
> +# SPDX-License-Identifier: GPL-2.0-only
> +menu "ST SoC drivers"
> +
> +config SOC_STM32MP2
> +	tristate "STM32MP2 SoC family support"
> +	depends on ARCH_STM32 || COMPILE_TEST
> +	default ARCH_STM32 && ARM64
> +	select SOC_BUS
> +	help
> +	  If you say yes here, you get support for the ST STM32MP2 family
> +
> +endmenu
> diff --git a/drivers/soc/st/Makefile b/drivers/soc/st/Makefile
> new file mode 100644
> index 0000000000000..5ca313476ca93
> --- /dev/null
> +++ b/drivers/soc/st/Makefile
> @@ -0,0 +1 @@
> +obj-$(CONFIG_SOC_STM32MP2) += stm32mp2-syscfg.o
> diff --git a/drivers/soc/st/stm32mp2-syscfg.c b/drivers/soc/st/stm32mp2-syscfg.c
> new file mode 100644
> index 0000000000000..102430f258606
> --- /dev/null
> +++ b/drivers/soc/st/stm32mp2-syscfg.c
> @@ -0,0 +1,33 @@
> +// SPDX-License-Identifier: GPL-2.0

Hello Marek,

I think this header is deprecated:
https://spdx.org/licenses/GPL-2.0.html

Suggest to adopt GPL-2.0-only
https://spdx.org/licenses/GPL-2.0-only.html

With that, you can add my:
Acked-by: Fabrice Gasnier <fabrice.gasnier@foss.st.com>
Tested-by: Fabrice Gasnier <fabrice.gasnier@foss.st.com>

Thanks & BR,
Fabrice

> +/*
> + * Copyright 2026 Marek Vasut
> + */
> +
> +#include <linux/module.h>
> +#include <linux/of_platform.h>
> +#include <linux/platform_device.h>
> +
> +static int stm32mp2_syscfg_probe(struct platform_device *pdev)
> +{
> +	return devm_of_platform_populate(&pdev->dev);
> +}
> +
> +static const struct of_device_id stm32mp2_syscfg_ids[] = {
> +	{ .compatible = "st,stm32mp23-syscfg" },
> +	{ .compatible = "st,stm32mp25-syscfg" },
> +	{ }
> +};
> +MODULE_DEVICE_TABLE(of, stm32mp2_syscfg_ids);
> +
> +static struct platform_driver stm32mp2_syscfg_driver = {
> +	.driver = {
> +		.name	= "stm32mp2_syscfg",
> +		.of_match_table = stm32mp2_syscfg_ids,
> +	},
> +	.probe = stm32mp2_syscfg_probe,
> +};
> +module_platform_driver(stm32mp2_syscfg_driver);
> +
> +MODULE_AUTHOR("Marek Vasut <marex@nabladev.com>");
> +MODULE_DESCRIPTION("ST STM32MP2 SYSCFG driver");
> +MODULE_LICENSE("GPL");