* [PATCH v2 1/6] arm64: dts: qcom: qcs6490-rb3gen2: clean up PCI function nodes
2026-09-01 1:36 [PATCH v2 0/6] arm64: dts: qcom: clean up PCI function nodes Alex Elder
@ 2026-09-01 1:36 ` Alex Elder
2026-09-01 7:25 ` Abel Vesa
2026-09-01 1:36 ` [PATCH v2 2/6] arm64: dts: qcom: qcs6490-rb3gen2-industrial-mezzanine: " Alex Elder
` (4 subsequent siblings)
5 siblings, 1 reply; 14+ messages in thread
From: Alex Elder @ 2026-09-01 1:36 UTC (permalink / raw)
To: andersson, konradybcio, robh, krzk+dt, conor+dt
Cc: mani, krishna.chundru, dmitry.baryshkov, sushrut.trivedi,
umang.chheda, rosh, jsandom, daniel, mohd.anwar, lorenzo.bianconi,
devicetree, linux-arm-msm, linux-kernel, Manivannan Sadhasivam,
Konrad Dybcio
The TC9564 SoC contains a PCIe switch with three downstream ports.
The third downstream port connects to an embedded PCI endpoint,
and that endpoint implements two PCI functions.
The devicetree node describing those functions incorrectly includes
this property:
device_type = "pci";
That property should only be used for a PCI device "that implements
a PCI bus", but not a PCIe function. So remove the device_type
property from the nodes representing the two embedded PCI functions.
Additionally, those properties contain #address-cells, #size-cells,
and ranges properties. And although these properties *will* be
appropriate for these functions on an RB3gen2, they are not normally
used for PCI functions. So remove these properties as well; we'll
include them in the commit that actually adds the pci-ep-bus sub-node
to each of these PCI function nodes.
Reviewed-by: Manivannan Sadhasivam <manivannan.sadhasivam@oss.qualcomm.com>
Reviewed-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
Fixes: aa7b4bbcb3a1d ("arm64: dts: qcom: qcs6490-rb3gen2: Add TC9563 PCIe switch node")
Signed-off-by: Alex Elder <elder@riscstar.com>
---
arch/arm64/boot/dts/qcom/qcs6490-rb3gen2.dts | 8 --------
1 file changed, 8 deletions(-)
diff --git a/arch/arm64/boot/dts/qcom/qcs6490-rb3gen2.dts b/arch/arm64/boot/dts/qcom/qcs6490-rb3gen2.dts
index a13315bf0fb07..db6578f7fba51 100644
--- a/arch/arm64/boot/dts/qcom/qcs6490-rb3gen2.dts
+++ b/arch/arm64/boot/dts/qcom/qcs6490-rb3gen2.dts
@@ -956,18 +956,10 @@ pcie@3,0 {
pcie@0,0 {
reg = <0x50000 0x0 0x0 0x0 0x0>;
- #address-cells = <3>;
- #size-cells = <2>;
- device_type = "pci";
- ranges;
};
pcie@0,1 {
reg = <0x50100 0x0 0x0 0x0 0x0>;
- #address-cells = <3>;
- #size-cells = <2>;
- device_type = "pci";
- ranges;
};
};
};
--
2.53.0
^ permalink raw reply related [flat|nested] 14+ messages in thread* Re: [PATCH v2 1/6] arm64: dts: qcom: qcs6490-rb3gen2: clean up PCI function nodes
2026-09-01 1:36 ` [PATCH v2 1/6] arm64: dts: qcom: qcs6490-rb3gen2: " Alex Elder
@ 2026-09-01 7:25 ` Abel Vesa
0 siblings, 0 replies; 14+ messages in thread
From: Abel Vesa @ 2026-09-01 7:25 UTC (permalink / raw)
To: Alex Elder
Cc: andersson, konradybcio, robh, krzk+dt, conor+dt, mani,
krishna.chundru, dmitry.baryshkov, sushrut.trivedi, umang.chheda,
rosh, jsandom, daniel, mohd.anwar, lorenzo.bianconi, devicetree,
linux-arm-msm, linux-kernel, Manivannan Sadhasivam, Konrad Dybcio
On 26-08-31 20:36:48, Alex Elder wrote:
> The TC9564 SoC contains a PCIe switch with three downstream ports.
> The third downstream port connects to an embedded PCI endpoint,
> and that endpoint implements two PCI functions.
>
> The devicetree node describing those functions incorrectly includes
> this property:
>
> device_type = "pci";
>
> That property should only be used for a PCI device "that implements
> a PCI bus", but not a PCIe function. So remove the device_type
> property from the nodes representing the two embedded PCI functions.
>
> Additionally, those properties contain #address-cells, #size-cells,
> and ranges properties. And although these properties *will* be
> appropriate for these functions on an RB3gen2, they are not normally
> used for PCI functions. So remove these properties as well; we'll
> include them in the commit that actually adds the pci-ep-bus sub-node
> to each of these PCI function nodes.
>
> Reviewed-by: Manivannan Sadhasivam <manivannan.sadhasivam@oss.qualcomm.com>
> Reviewed-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
> Fixes: aa7b4bbcb3a1d ("arm64: dts: qcom: qcs6490-rb3gen2: Add TC9563 PCIe switch node")
> Signed-off-by: Alex Elder <elder@riscstar.com>
Reviewed-by: Abel Vesa <abel.vesa@oss.qualcomm.com>
^ permalink raw reply [flat|nested] 14+ messages in thread
* [PATCH v2 2/6] arm64: dts: qcom: qcs6490-rb3gen2-industrial-mezzanine: clean up PCI function nodes
2026-09-01 1:36 [PATCH v2 0/6] arm64: dts: qcom: clean up PCI function nodes Alex Elder
2026-09-01 1:36 ` [PATCH v2 1/6] arm64: dts: qcom: qcs6490-rb3gen2: " Alex Elder
@ 2026-09-01 1:36 ` Alex Elder
2026-09-01 7:26 ` Abel Vesa
2026-09-01 1:36 ` [PATCH v2 3/6] arm64: dts: qcom: lemans-evk-ifp-mezzanine: " Alex Elder
` (3 subsequent siblings)
5 siblings, 1 reply; 14+ messages in thread
From: Alex Elder @ 2026-09-01 1:36 UTC (permalink / raw)
To: andersson, konradybcio, robh, krzk+dt, conor+dt
Cc: mani, krishna.chundru, dmitry.baryshkov, sushrut.trivedi,
umang.chheda, rosh, jsandom, daniel, mohd.anwar, lorenzo.bianconi,
devicetree, linux-arm-msm, linux-kernel, Manivannan Sadhasivam,
Konrad Dybcio
The qcs6490-rb3gen2-industrial-mezzanine overlay defines two nodes
representing TC956x chips, each of which contains a PCIe switch and
an embedded endpoint that implements two PCIe functions.
The devicetree nodes erroneously include a "pci" device_type property
for the two PCIe functions. That property should only be used for a
PCI device "that implements a PCI bus". Remove this property for the
two function nodes.
In addition, these nodes define #address-cells, #size-cells, and ranges
properties, which are not normally defined for PCIe endpoints. Remove
properties as well; they can be added back once they are actually
needed/used.
Reviewed-by: Manivannan Sadhasivam <manivannan.sadhasivam@oss.qualcomm.com>
Reviewed-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
Fixes: 4559b435f741b ("arm64: dts: qcom: qcs6490-rb3gen2-industrial-mezzanine: Add TC9563 PCIe switch node for PCIe0")
Signed-off-by: Alex Elder <elder@riscstar.com>
---
.../qcs6490-rb3gen2-industrial-mezzanine.dtso | 16 ----------------
1 file changed, 16 deletions(-)
diff --git a/arch/arm64/boot/dts/qcom/qcs6490-rb3gen2-industrial-mezzanine.dtso b/arch/arm64/boot/dts/qcom/qcs6490-rb3gen2-industrial-mezzanine.dtso
index 46bb52c667a4d..82c4d47fc2aaa 100644
--- a/arch/arm64/boot/dts/qcom/qcs6490-rb3gen2-industrial-mezzanine.dtso
+++ b/arch/arm64/boot/dts/qcom/qcs6490-rb3gen2-industrial-mezzanine.dtso
@@ -132,18 +132,10 @@ pcie@3,0 {
pcie@0,0 {
reg = <0x50000 0x0 0x0 0x0 0x0>;
- #address-cells = <3>;
- #size-cells = <2>;
- device_type = "pci";
- ranges;
};
pcie@0,1 {
reg = <0x50100 0x0 0x0 0x0 0x0>;
- #address-cells = <3>;
- #size-cells = <2>;
- device_type = "pci";
- ranges;
};
};
@@ -227,18 +219,10 @@ pcie@3,0 {
pcie@0,0 {
reg = <0x50000 0x0 0x0 0x0 0x0>;
- #address-cells = <3>;
- #size-cells = <2>;
- device_type = "pci";
- ranges;
};
pcie@0,1 {
reg = <0x50100 0x0 0x0 0x0 0x0>;
- #address-cells = <3>;
- #size-cells = <2>;
- device_type = "pci";
- ranges;
};
};
};
--
2.53.0
^ permalink raw reply related [flat|nested] 14+ messages in thread* Re: [PATCH v2 2/6] arm64: dts: qcom: qcs6490-rb3gen2-industrial-mezzanine: clean up PCI function nodes
2026-09-01 1:36 ` [PATCH v2 2/6] arm64: dts: qcom: qcs6490-rb3gen2-industrial-mezzanine: " Alex Elder
@ 2026-09-01 7:26 ` Abel Vesa
0 siblings, 0 replies; 14+ messages in thread
From: Abel Vesa @ 2026-09-01 7:26 UTC (permalink / raw)
To: Alex Elder
Cc: andersson, konradybcio, robh, krzk+dt, conor+dt, mani,
krishna.chundru, dmitry.baryshkov, sushrut.trivedi, umang.chheda,
rosh, jsandom, daniel, mohd.anwar, lorenzo.bianconi, devicetree,
linux-arm-msm, linux-kernel, Manivannan Sadhasivam, Konrad Dybcio
On 26-08-31 20:36:49, Alex Elder wrote:
> The qcs6490-rb3gen2-industrial-mezzanine overlay defines two nodes
> representing TC956x chips, each of which contains a PCIe switch and
> an embedded endpoint that implements two PCIe functions.
>
> The devicetree nodes erroneously include a "pci" device_type property
> for the two PCIe functions. That property should only be used for a
> PCI device "that implements a PCI bus". Remove this property for the
> two function nodes.
>
> In addition, these nodes define #address-cells, #size-cells, and ranges
> properties, which are not normally defined for PCIe endpoints. Remove
> properties as well; they can be added back once they are actually
> needed/used.
>
> Reviewed-by: Manivannan Sadhasivam <manivannan.sadhasivam@oss.qualcomm.com>
> Reviewed-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
> Fixes: 4559b435f741b ("arm64: dts: qcom: qcs6490-rb3gen2-industrial-mezzanine: Add TC9563 PCIe switch node for PCIe0")
> Signed-off-by: Alex Elder <elder@riscstar.com>
Reviewed-by: Abel Vesa <abel.vesa@oss.qualcomm.com>
^ permalink raw reply [flat|nested] 14+ messages in thread
* [PATCH v2 3/6] arm64: dts: qcom: lemans-evk-ifp-mezzanine: clean up PCI function nodes
2026-09-01 1:36 [PATCH v2 0/6] arm64: dts: qcom: clean up PCI function nodes Alex Elder
2026-09-01 1:36 ` [PATCH v2 1/6] arm64: dts: qcom: qcs6490-rb3gen2: " Alex Elder
2026-09-01 1:36 ` [PATCH v2 2/6] arm64: dts: qcom: qcs6490-rb3gen2-industrial-mezzanine: " Alex Elder
@ 2026-09-01 1:36 ` Alex Elder
2026-09-01 7:26 ` Abel Vesa
2026-09-01 1:36 ` [PATCH v2 4/6] arm64: dts: qcom: monaco-evk-ifp-mezzanine: " Alex Elder
` (2 subsequent siblings)
5 siblings, 1 reply; 14+ messages in thread
From: Alex Elder @ 2026-09-01 1:36 UTC (permalink / raw)
To: andersson, konradybcio, robh, krzk+dt, conor+dt
Cc: mani, krishna.chundru, dmitry.baryshkov, sushrut.trivedi,
umang.chheda, rosh, jsandom, daniel, mohd.anwar, lorenzo.bianconi,
devicetree, linux-arm-msm, linux-kernel, Manivannan Sadhasivam,
Konrad Dybcio
The lemans-evk-ifp-mezzanine overlay defines a node representing a
TC956x chip which contains a PCIe switch and an embedded endpoint
that implements two PCIe functions.
The devicetree nodes erroneously include a "pci" device_type property
for the two PCIe functions. That property should only be used for a
PCI device "that implements a PCI bus". Remove this property for the
two function nodes.
In addition, these nodes define #address-cells, #size-cells, and ranges
properties, which are not normally defined for PCIe endpoints. Remove
these properties as well; they can be added back once they are actually
needed/used.
Reviewed-by: Manivannan Sadhasivam <manivannan.sadhasivam@oss.qualcomm.com>
Reviewed-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
Fixes: b64abb26a2916 ("arm64: dts: qcom: lemans-evk: Add IFP Mezzanine")
Signed-off-by: Alex Elder <elder@riscstar.com>
---
arch/arm64/boot/dts/qcom/lemans-evk-ifp-mezzanine.dtso | 8 --------
1 file changed, 8 deletions(-)
diff --git a/arch/arm64/boot/dts/qcom/lemans-evk-ifp-mezzanine.dtso b/arch/arm64/boot/dts/qcom/lemans-evk-ifp-mezzanine.dtso
index 6cfa0bc1440e9..9edb447ee990d 100644
--- a/arch/arm64/boot/dts/qcom/lemans-evk-ifp-mezzanine.dtso
+++ b/arch/arm64/boot/dts/qcom/lemans-evk-ifp-mezzanine.dtso
@@ -273,18 +273,10 @@ pcie@3,0 {
pcie@0,0 {
reg = <0x50000 0x0 0x0 0x0 0x0>;
- #address-cells = <3>;
- #size-cells = <2>;
- device_type = "pci";
- ranges;
};
pcie@0,1 {
reg = <0x50100 0x0 0x0 0x0 0x0>;
- #address-cells = <3>;
- #size-cells = <2>;
- device_type = "pci";
- ranges;
};
};
};
--
2.53.0
^ permalink raw reply related [flat|nested] 14+ messages in thread* Re: [PATCH v2 3/6] arm64: dts: qcom: lemans-evk-ifp-mezzanine: clean up PCI function nodes
2026-09-01 1:36 ` [PATCH v2 3/6] arm64: dts: qcom: lemans-evk-ifp-mezzanine: " Alex Elder
@ 2026-09-01 7:26 ` Abel Vesa
0 siblings, 0 replies; 14+ messages in thread
From: Abel Vesa @ 2026-09-01 7:26 UTC (permalink / raw)
To: Alex Elder
Cc: andersson, konradybcio, robh, krzk+dt, conor+dt, mani,
krishna.chundru, dmitry.baryshkov, sushrut.trivedi, umang.chheda,
rosh, jsandom, daniel, mohd.anwar, lorenzo.bianconi, devicetree,
linux-arm-msm, linux-kernel, Manivannan Sadhasivam, Konrad Dybcio
On 26-08-31 20:36:50, Alex Elder wrote:
> The lemans-evk-ifp-mezzanine overlay defines a node representing a
> TC956x chip which contains a PCIe switch and an embedded endpoint
> that implements two PCIe functions.
>
> The devicetree nodes erroneously include a "pci" device_type property
> for the two PCIe functions. That property should only be used for a
> PCI device "that implements a PCI bus". Remove this property for the
> two function nodes.
>
> In addition, these nodes define #address-cells, #size-cells, and ranges
> properties, which are not normally defined for PCIe endpoints. Remove
> these properties as well; they can be added back once they are actually
> needed/used.
>
> Reviewed-by: Manivannan Sadhasivam <manivannan.sadhasivam@oss.qualcomm.com>
> Reviewed-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
> Fixes: b64abb26a2916 ("arm64: dts: qcom: lemans-evk: Add IFP Mezzanine")
> Signed-off-by: Alex Elder <elder@riscstar.com>
Reviewed-by: Abel Vesa <abel.vesa@oss.qualcomm.com>
^ permalink raw reply [flat|nested] 14+ messages in thread
* [PATCH v2 4/6] arm64: dts: qcom: monaco-evk-ifp-mezzanine: clean up PCI function nodes
2026-09-01 1:36 [PATCH v2 0/6] arm64: dts: qcom: clean up PCI function nodes Alex Elder
` (2 preceding siblings ...)
2026-09-01 1:36 ` [PATCH v2 3/6] arm64: dts: qcom: lemans-evk-ifp-mezzanine: " Alex Elder
@ 2026-09-01 1:36 ` Alex Elder
2026-09-01 7:27 ` Abel Vesa
2026-09-01 1:36 ` [PATCH v2 5/6] arm64: dts: qcom: qcs6490-thundercomm-minipc-g1iot: " Alex Elder
2026-09-01 1:36 ` [PATCH v2 6/6] arm64: dts: qcom: qcs8550-rb5gen2: " Alex Elder
5 siblings, 1 reply; 14+ messages in thread
From: Alex Elder @ 2026-09-01 1:36 UTC (permalink / raw)
To: andersson, konradybcio, robh, krzk+dt, conor+dt
Cc: mani, krishna.chundru, dmitry.baryshkov, sushrut.trivedi,
umang.chheda, rosh, jsandom, daniel, mohd.anwar, lorenzo.bianconi,
devicetree, linux-arm-msm, linux-kernel, Manivannan Sadhasivam,
Konrad Dybcio
The monaco-evk-ifp-mezzanine overlay defines a node representing a
TC956x chip which contains a PCIe switch and an embedded endpoint
that implements two PCIe functions.
The devicetree nodes erroneously include a "pci" device_type property
for the two PCIe functions. That property should only be used for a
PCI device "that implements a PCI bus". Remove this property for the
two function nodes.
In addition, these nodes define #address-cells, #size-cells, and ranges
properties, which are not normally defined for PCIe endpoints. Remove
properties as well; they can be added back once they are actually
needed/used.
Reviewed-by: Manivannan Sadhasivam <manivannan.sadhasivam@oss.qualcomm.com>
Reviewed-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
Fixes: 5a67924d2fc57 ("arm64: dts: qcom: monaco-evk: Add IFP Mezzanine")
Signed-off-by: Alex Elder <elder@riscstar.com>
---
arch/arm64/boot/dts/qcom/monaco-evk-ifp-mezzanine.dtso | 8 --------
1 file changed, 8 deletions(-)
diff --git a/arch/arm64/boot/dts/qcom/monaco-evk-ifp-mezzanine.dtso b/arch/arm64/boot/dts/qcom/monaco-evk-ifp-mezzanine.dtso
index ca5bf0fe5ec6e..9b5e911b83210 100644
--- a/arch/arm64/boot/dts/qcom/monaco-evk-ifp-mezzanine.dtso
+++ b/arch/arm64/boot/dts/qcom/monaco-evk-ifp-mezzanine.dtso
@@ -119,18 +119,10 @@ pcie@3,0 {
pcie@0,0 {
reg = <0x50000 0x0 0x0 0x0 0x0>;
- #address-cells = <3>;
- #size-cells = <2>;
- device_type = "pci";
- ranges;
};
pcie@0,1 {
reg = <0x50100 0x0 0x0 0x0 0x0>;
- #address-cells = <3>;
- #size-cells = <2>;
- device_type = "pci";
- ranges;
};
};
};
--
2.53.0
^ permalink raw reply related [flat|nested] 14+ messages in thread* Re: [PATCH v2 4/6] arm64: dts: qcom: monaco-evk-ifp-mezzanine: clean up PCI function nodes
2026-09-01 1:36 ` [PATCH v2 4/6] arm64: dts: qcom: monaco-evk-ifp-mezzanine: " Alex Elder
@ 2026-09-01 7:27 ` Abel Vesa
0 siblings, 0 replies; 14+ messages in thread
From: Abel Vesa @ 2026-09-01 7:27 UTC (permalink / raw)
To: Alex Elder
Cc: andersson, konradybcio, robh, krzk+dt, conor+dt, mani,
krishna.chundru, dmitry.baryshkov, sushrut.trivedi, umang.chheda,
rosh, jsandom, daniel, mohd.anwar, lorenzo.bianconi, devicetree,
linux-arm-msm, linux-kernel, Manivannan Sadhasivam, Konrad Dybcio
On 26-08-31 20:36:51, Alex Elder wrote:
> The monaco-evk-ifp-mezzanine overlay defines a node representing a
> TC956x chip which contains a PCIe switch and an embedded endpoint
> that implements two PCIe functions.
>
> The devicetree nodes erroneously include a "pci" device_type property
> for the two PCIe functions. That property should only be used for a
> PCI device "that implements a PCI bus". Remove this property for the
> two function nodes.
>
> In addition, these nodes define #address-cells, #size-cells, and ranges
> properties, which are not normally defined for PCIe endpoints. Remove
> properties as well; they can be added back once they are actually
> needed/used.
>
> Reviewed-by: Manivannan Sadhasivam <manivannan.sadhasivam@oss.qualcomm.com>
> Reviewed-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
> Fixes: 5a67924d2fc57 ("arm64: dts: qcom: monaco-evk: Add IFP Mezzanine")
> Signed-off-by: Alex Elder <elder@riscstar.com>
Reviewed-by: Abel Vesa <abel.vesa@oss.qualcomm.com>
^ permalink raw reply [flat|nested] 14+ messages in thread
* [PATCH v2 5/6] arm64: dts: qcom: qcs6490-thundercomm-minipc-g1iot: clean up PCI function nodes
2026-09-01 1:36 [PATCH v2 0/6] arm64: dts: qcom: clean up PCI function nodes Alex Elder
` (3 preceding siblings ...)
2026-09-01 1:36 ` [PATCH v2 4/6] arm64: dts: qcom: monaco-evk-ifp-mezzanine: " Alex Elder
@ 2026-09-01 1:36 ` Alex Elder
2026-09-01 7:27 ` Abel Vesa
2026-09-01 1:36 ` [PATCH v2 6/6] arm64: dts: qcom: qcs8550-rb5gen2: " Alex Elder
5 siblings, 1 reply; 14+ messages in thread
From: Alex Elder @ 2026-09-01 1:36 UTC (permalink / raw)
To: andersson, konradybcio, robh, krzk+dt, conor+dt
Cc: mani, krishna.chundru, dmitry.baryshkov, sushrut.trivedi,
umang.chheda, rosh, jsandom, daniel, mohd.anwar, lorenzo.bianconi,
devicetree, linux-arm-msm, linux-kernel, Manivannan Sadhasivam,
Konrad Dybcio
The Thundercomm AI Mini PC G1 IoT devicetree source file defines a node
representing a TC956x chip which contains a PCIe switch and an embedded
endpoint that implements two PCIe functions.
The devicetree nodes erroneously include a "pci" device_type property
for the two PCIe functions. That property should only be used for a
PCI device "that implements a PCI bus". Remove this property for the
two function nodes.
In addition, these nodes define #address-cells, #size-cells, and ranges
properties, which are not normally defined for PCIe endpoints. Remove
properties as well; they can be added back once they are actually
needed/used.
Reviewed-by: Manivannan Sadhasivam <manivannan.sadhasivam@oss.qualcomm.com>
Reviewed-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
Fixes: 1cde54c54b83b ("arm64: dts: qcom: qcs6490: Add Thundercomm AI Mini PC G1 IoT")
Signed-off-by: Alex Elder <elder@riscstar.com>
---
.../boot/dts/qcom/qcs6490-thundercomm-minipc-g1iot.dts | 8 --------
1 file changed, 8 deletions(-)
diff --git a/arch/arm64/boot/dts/qcom/qcs6490-thundercomm-minipc-g1iot.dts b/arch/arm64/boot/dts/qcom/qcs6490-thundercomm-minipc-g1iot.dts
index 31bafa2cf51db..3e8d144f57b00 100644
--- a/arch/arm64/boot/dts/qcom/qcs6490-thundercomm-minipc-g1iot.dts
+++ b/arch/arm64/boot/dts/qcom/qcs6490-thundercomm-minipc-g1iot.dts
@@ -792,18 +792,10 @@ pcie@3,0 {
pcie@0,0 {
reg = <0x50000 0x0 0x0 0x0 0x0>;
- #address-cells = <3>;
- #size-cells = <2>;
- device_type = "pci";
- ranges;
};
pcie@0,1 {
reg = <0x50100 0x0 0x0 0x0 0x0>;
- #address-cells = <3>;
- #size-cells = <2>;
- device_type = "pci";
- ranges;
};
};
};
--
2.53.0
^ permalink raw reply related [flat|nested] 14+ messages in thread* Re: [PATCH v2 5/6] arm64: dts: qcom: qcs6490-thundercomm-minipc-g1iot: clean up PCI function nodes
2026-09-01 1:36 ` [PATCH v2 5/6] arm64: dts: qcom: qcs6490-thundercomm-minipc-g1iot: " Alex Elder
@ 2026-09-01 7:27 ` Abel Vesa
0 siblings, 0 replies; 14+ messages in thread
From: Abel Vesa @ 2026-09-01 7:27 UTC (permalink / raw)
To: Alex Elder
Cc: andersson, konradybcio, robh, krzk+dt, conor+dt, mani,
krishna.chundru, dmitry.baryshkov, sushrut.trivedi, umang.chheda,
rosh, jsandom, daniel, mohd.anwar, lorenzo.bianconi, devicetree,
linux-arm-msm, linux-kernel, Manivannan Sadhasivam, Konrad Dybcio
On 26-08-31 20:36:52, Alex Elder wrote:
> The Thundercomm AI Mini PC G1 IoT devicetree source file defines a node
> representing a TC956x chip which contains a PCIe switch and an embedded
> endpoint that implements two PCIe functions.
>
> The devicetree nodes erroneously include a "pci" device_type property
> for the two PCIe functions. That property should only be used for a
> PCI device "that implements a PCI bus". Remove this property for the
> two function nodes.
>
> In addition, these nodes define #address-cells, #size-cells, and ranges
> properties, which are not normally defined for PCIe endpoints. Remove
> properties as well; they can be added back once they are actually
> needed/used.
>
> Reviewed-by: Manivannan Sadhasivam <manivannan.sadhasivam@oss.qualcomm.com>
> Reviewed-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
> Fixes: 1cde54c54b83b ("arm64: dts: qcom: qcs6490: Add Thundercomm AI Mini PC G1 IoT")
> Signed-off-by: Alex Elder <elder@riscstar.com>
Reviewed-by: Abel Vesa <abel.vesa@oss.qualcomm.com>
^ permalink raw reply [flat|nested] 14+ messages in thread
* [PATCH v2 6/6] arm64: dts: qcom: qcs8550-rb5gen2: clean up PCI function nodes
2026-09-01 1:36 [PATCH v2 0/6] arm64: dts: qcom: clean up PCI function nodes Alex Elder
` (4 preceding siblings ...)
2026-09-01 1:36 ` [PATCH v2 5/6] arm64: dts: qcom: qcs6490-thundercomm-minipc-g1iot: " Alex Elder
@ 2026-09-01 1:36 ` Alex Elder
2026-09-01 7:27 ` Abel Vesa
2026-09-01 8:13 ` Manivannan Sadhasivam
5 siblings, 2 replies; 14+ messages in thread
From: Alex Elder @ 2026-09-01 1:36 UTC (permalink / raw)
To: andersson, konradybcio, robh, krzk+dt, conor+dt
Cc: mani, krishna.chundru, dmitry.baryshkov, sushrut.trivedi,
umang.chheda, rosh, jsandom, daniel, mohd.anwar, lorenzo.bianconi,
devicetree, linux-arm-msm, linux-kernel
The Qualcomm RB5gen2 devicetree source file defines a node representing
a TC956x chip which contains a PCIe switch and an embedded endpoint that
implements two PCIe functions.
The devicetree nodes erroneously include a "pci" device_type property
for the two PCIe functions. That property should only be used for a
PCI device "that implements a PCI bus". Remove this property for the
two function nodes.
In addition, these nodes define #address-cells, #size-cells, and ranges
properties, which are not normally defined for PCIe endpoints. Remove
properties as well; they can be added back once they are actually
needed/used.
Fixes: 33cae252054a6 ("arm64: dts: qcom: qcs8550: add QCS8550 RB5Gen2 board support")
Signed-off-by: Alex Elder <elder@riscstar.com>
---
v2: - New patch updating DTS that was not present for v1
arch/arm64/boot/dts/qcom/qcs8550-rb5gen2.dts | 8 --------
1 file changed, 8 deletions(-)
diff --git a/arch/arm64/boot/dts/qcom/qcs8550-rb5gen2.dts b/arch/arm64/boot/dts/qcom/qcs8550-rb5gen2.dts
index 9df8dcd6c62b6..2c74a1e242ef8 100644
--- a/arch/arm64/boot/dts/qcom/qcs8550-rb5gen2.dts
+++ b/arch/arm64/boot/dts/qcom/qcs8550-rb5gen2.dts
@@ -1128,18 +1128,10 @@ pcie@3,0 {
pci@0,0 {
reg = <0x50000 0x0 0x0 0x0 0x0>;
- #address-cells = <3>;
- #size-cells = <2>;
- device_type = "pci";
- ranges;
};
pci@0,1 {
reg = <0x50100 0x0 0x0 0x0 0x0>;
- #address-cells = <3>;
- #size-cells = <2>;
- device_type = "pci";
- ranges;
};
};
};
--
2.53.0
^ permalink raw reply related [flat|nested] 14+ messages in thread* Re: [PATCH v2 6/6] arm64: dts: qcom: qcs8550-rb5gen2: clean up PCI function nodes
2026-09-01 1:36 ` [PATCH v2 6/6] arm64: dts: qcom: qcs8550-rb5gen2: " Alex Elder
@ 2026-09-01 7:27 ` Abel Vesa
2026-09-01 8:13 ` Manivannan Sadhasivam
1 sibling, 0 replies; 14+ messages in thread
From: Abel Vesa @ 2026-09-01 7:27 UTC (permalink / raw)
To: Alex Elder
Cc: andersson, konradybcio, robh, krzk+dt, conor+dt, mani,
krishna.chundru, dmitry.baryshkov, sushrut.trivedi, umang.chheda,
rosh, jsandom, daniel, mohd.anwar, lorenzo.bianconi, devicetree,
linux-arm-msm, linux-kernel
On 26-08-31 20:36:53, Alex Elder wrote:
> The Qualcomm RB5gen2 devicetree source file defines a node representing
> a TC956x chip which contains a PCIe switch and an embedded endpoint that
> implements two PCIe functions.
>
> The devicetree nodes erroneously include a "pci" device_type property
> for the two PCIe functions. That property should only be used for a
> PCI device "that implements a PCI bus". Remove this property for the
> two function nodes.
>
> In addition, these nodes define #address-cells, #size-cells, and ranges
> properties, which are not normally defined for PCIe endpoints. Remove
> properties as well; they can be added back once they are actually
> needed/used.
>
> Fixes: 33cae252054a6 ("arm64: dts: qcom: qcs8550: add QCS8550 RB5Gen2 board support")
> Signed-off-by: Alex Elder <elder@riscstar.com>
Reviewed-by: Abel Vesa <abel.vesa@oss.qualcomm.com>
^ permalink raw reply [flat|nested] 14+ messages in thread* Re: [PATCH v2 6/6] arm64: dts: qcom: qcs8550-rb5gen2: clean up PCI function nodes
2026-09-01 1:36 ` [PATCH v2 6/6] arm64: dts: qcom: qcs8550-rb5gen2: " Alex Elder
2026-09-01 7:27 ` Abel Vesa
@ 2026-09-01 8:13 ` Manivannan Sadhasivam
1 sibling, 0 replies; 14+ messages in thread
From: Manivannan Sadhasivam @ 2026-09-01 8:13 UTC (permalink / raw)
To: Alex Elder
Cc: andersson, konradybcio, robh, krzk+dt, conor+dt, krishna.chundru,
dmitry.baryshkov, sushrut.trivedi, umang.chheda, rosh, jsandom,
daniel, mohd.anwar, lorenzo.bianconi, devicetree, linux-arm-msm,
linux-kernel
On Mon, Aug 31, 2026 at 08:36:53PM -0500, Alex Elder wrote:
> The Qualcomm RB5gen2 devicetree source file defines a node representing
> a TC956x chip which contains a PCIe switch and an embedded endpoint that
> implements two PCIe functions.
>
> The devicetree nodes erroneously include a "pci" device_type property
> for the two PCIe functions. That property should only be used for a
> PCI device "that implements a PCI bus". Remove this property for the
> two function nodes.
>
> In addition, these nodes define #address-cells, #size-cells, and ranges
> properties, which are not normally defined for PCIe endpoints. Remove
> properties as well; they can be added back once they are actually
> needed/used.
>
> Fixes: 33cae252054a6 ("arm64: dts: qcom: qcs8550: add QCS8550 RB5Gen2 board support")
> Signed-off-by: Alex Elder <elder@riscstar.com>
Reviewed-by: Manivannan Sadhasivam <manivannan.sadhasivam@oss.qualcomm.com>
- Mani
--
மணிவண்ணன் சதாசிவம்
^ permalink raw reply [flat|nested] 14+ messages in thread