Re: [PATCH v3 1/8] dt-bindings: Add InvenSense ICM-42370-p accelerometer

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] The schema includes SPI properties and unconditionally references the SPI peripheral schema, directly contradicting the commit message which states only I2C support is being added.
--

commit df5e4c67004b6299d9c5cce9f57c0acaa91c89bb
Author: Kanak Shilledar <kanak.shilledar@axis.com>

dt-bindings: Add InvenSense ICM-42370-p accelerometer

This commit adds the devicetree binding documentation for the InvenSense
ICM42370P 3-axis accelerometer. The commit message explicitly states that
only I2C support is being added, leaving SPI and I3C for future work.

> diff --git a/Documentation/devicetree/bindings/iio/accel/invensense,icm42370p.yaml b/Documentation/devicetree/bindings/iio/accel/invensense,icm42370p.yaml
> new file mode 100644
> index 0000000000000..d519dc7e63dd0
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/iio/accel/invensense,icm42370p.yaml

[ ... ]

> +  vddio-supply:
> +    description: Regulator operating range between 1.71V to 3.6V.
> +
> +  spi-cpha: true
> +  spi-cpol: true

[Severity: Medium]
The commit message states that only I2C support is being added and leaves
other protocols for future work. Are these SPI-specific properties intended
to be explicitly permitted here despite the stated omission of SPI support?

> +
> +required:
> +  - compatible
> +  - reg
> +  - interrupts
> +  - vdd-supply
> +  - vddio-supply
> +
> +allOf:
> +  - $ref: /schemas/spi/spi-peripheral-props.yaml#

[Severity: Medium]
Does unconditionally referencing the SPI peripheral schema here allow invalid
device tree configurations to silently pass validation? Since the binding is
currently scoped to I2C, this might inadvertently allow I2C nodes to define
SPI-specific properties without causing validation errors.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260901-b4-inv_icm42370p-v3-0-77cc31642115@axis.com?part=1