Devicetree
 help / color / mirror / Atom feed
* [PATCH v3 1/2] dt-bindings: hwmon: tmp102: Fix up TMP103 bindings
@ 2026-09-01 17:47 Marek Vasut
  2026-09-01 17:47 ` [PATCH v3 2/2] dt-bindings: hwmon: tmp102: Document TMP113 Marek Vasut
                   ` (3 more replies)
  0 siblings, 4 replies; 9+ messages in thread
From: Marek Vasut @ 2026-09-01 17:47 UTC (permalink / raw)
  To: linux-pm
  Cc: Marek Vasut, Conor Dooley, Flaviu Nistor, Guenter Roeck,
	Krzysztof Kozlowski, Rob Herring, devicetree, linux-hwmon,
	linux-kernel

The TMP102 and TMP110 are backward compatible, therefore the valid
compatible strings are "ti,tmp110", "ti,tmp102" and "ti,tmp102" .

The TMP103 is not backward compatible with TMP102, but it does share a
schema now, therefore the only valid compatible string for the TMP103
should be "ti,tmp103" .

Make exactly those three compatible strings valid and everything else
rejected.

Fixes: d67ec24d3f07 ("dt-bindings: hwmon: tmp102: move ti,tmp103 out of trivial-devices.yaml")
Signed-off-by: Marek Vasut <marex@nabladev.com>
---
Cc: Conor Dooley <conor+dt@kernel.org>
Cc: Flaviu Nistor <flaviu.nistor@gmail.com>
Cc: Guenter Roeck <linux@roeck-us.net>
Cc: Krzysztof Kozlowski <krzk+dt@kernel.org>
Cc: Rob Herring <robh@kernel.org>
Cc: devicetree@vger.kernel.org
Cc: linux-hwmon@vger.kernel.org
Cc: linux-kernel@vger.kernel.org
---
V3: New patch
---
 Documentation/devicetree/bindings/hwmon/ti,tmp102.yaml | 7 +++----
 1 file changed, 3 insertions(+), 4 deletions(-)

diff --git a/Documentation/devicetree/bindings/hwmon/ti,tmp102.yaml b/Documentation/devicetree/bindings/hwmon/ti,tmp102.yaml
index 55d9f106465d7..477f478b9dd0f 100644
--- a/Documentation/devicetree/bindings/hwmon/ti,tmp102.yaml
+++ b/Documentation/devicetree/bindings/hwmon/ti,tmp102.yaml
@@ -13,11 +13,10 @@ properties:
   compatible:
     oneOf:
       - items:
-          - const: ti,tmp102
-          - const: ti,tmp103
           - const: ti,tmp110
-      - enum:
-          - ti,tmp102
+          - const: ti,tmp102
+      - const: ti,tmp102
+      - const: ti,tmp103
 
   interrupts:
     maxItems: 1
-- 
2.53.0


^ permalink raw reply related	[flat|nested] 9+ messages in thread

* [PATCH v3 2/2] dt-bindings: hwmon: tmp102: Document TMP113
  2026-09-01 17:47 [PATCH v3 1/2] dt-bindings: hwmon: tmp102: Fix up TMP103 bindings Marek Vasut
@ 2026-09-01 17:47 ` Marek Vasut
  2026-09-01 17:53   ` sashiko-bot
                     ` (2 more replies)
  2026-09-01 17:53 ` [PATCH v3 1/2] dt-bindings: hwmon: tmp102: Fix up TMP103 bindings sashiko-bot
                   ` (2 subsequent siblings)
  3 siblings, 3 replies; 9+ messages in thread
From: Marek Vasut @ 2026-09-01 17:47 UTC (permalink / raw)
  To: linux-pm
  Cc: Marek Vasut, Conor Dooley, Flaviu Nistor, Guenter Roeck,
	Krzysztof Kozlowski, Rob Herring, devicetree, linux-hwmon,
	linux-kernel

The TMP113 temperature sensor part is register compatible with TMP102,
document it using a fallback compatible. Unlike TMP102 and TMP110, the
TMP113 does have additional unique ID registers, it is up to the driver
to handle those.

Signed-off-by: Marek Vasut <marex@nabladev.com>
---
Cc: Conor Dooley <conor+dt@kernel.org>
Cc: Flaviu Nistor <flaviu.nistor@gmail.com>
Cc: Guenter Roeck <linux@roeck-us.net>
Cc: Krzysztof Kozlowski <krzk+dt@kernel.org>
Cc: Rob Herring <robh@kernel.org>
Cc: devicetree@vger.kernel.org
Cc: linux-hwmon@vger.kernel.org
Cc: linux-kernel@vger.kernel.org
---
V2: Rebase on current next and resend, resolve a conflict with commit
    d67ec24d3f07 ("dt-bindings: hwmon: tmp102: move ti,tmp103 out of trivial-devices.yaml")
    Note that the TMP102,110,113 are backward compatible, therefore the
    valid compatible strings are:
    - "ti,tmp110", "ti,tmp102"
    - "ti,tmp113", "ti,tmp102"
    - "ti,tmp102"
    The TMP103 is not backward compatible, it only shares bindings now,
    therefore the only valid compatible string for the TMP103 should be:
    - "ti,tmp103"
    And that is all, no other compatible strings are acceptable here.
V3: Rebase on top of 1/2 dt-bindings: hwmon: tmp102: Fix up TMP103 bindings
---
 Documentation/devicetree/bindings/hwmon/ti,tmp102.yaml | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/Documentation/devicetree/bindings/hwmon/ti,tmp102.yaml b/Documentation/devicetree/bindings/hwmon/ti,tmp102.yaml
index 477f478b9dd0f..c0b747a9ce0de 100644
--- a/Documentation/devicetree/bindings/hwmon/ti,tmp102.yaml
+++ b/Documentation/devicetree/bindings/hwmon/ti,tmp102.yaml
@@ -4,7 +4,7 @@
 $id: http://devicetree.org/schemas/hwmon/ti,tmp102.yaml#
 $schema: http://devicetree.org/meta-schemas/core.yaml#
 
-title: TMP102/TMP103/TMP110 temperature sensor
+title: TMP102/TMP103/TMP110/TMP113 temperature sensor
 
 maintainers:
   - Krzysztof Kozlowski <krzk@kernel.org>
@@ -13,7 +13,9 @@ properties:
   compatible:
     oneOf:
       - items:
-          - const: ti,tmp110
+          - enum:
+              - ti,tmp110
+              - ti,tmp113
           - const: ti,tmp102
       - const: ti,tmp102
       - const: ti,tmp103
-- 
2.53.0


^ permalink raw reply related	[flat|nested] 9+ messages in thread

* Re: [PATCH v3 2/2] dt-bindings: hwmon: tmp102: Document TMP113
  2026-09-01 17:47 ` [PATCH v3 2/2] dt-bindings: hwmon: tmp102: Document TMP113 Marek Vasut
@ 2026-09-01 17:53   ` sashiko-bot
  2026-09-01 18:03   ` Conor Dooley
  2026-09-01 18:20   ` Guenter Roeck
  2 siblings, 0 replies; 9+ messages in thread
From: sashiko-bot @ 2026-09-01 17:53 UTC (permalink / raw)
  To: Marek Vasut; +Cc: devicetree, conor+dt, linux-hwmon, robh

> The TMP113 temperature sensor part is register compatible with TMP102,
> document it using a fallback compatible. Unlike TMP102 and TMP110, the
> TMP113 does have additional unique ID registers, it is up to the driver
> to handle those.
> 
> Signed-off-by: Marek Vasut <marex@nabladev.com>

Sashiko has reviewed this patch and found no issues. It looks great!

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260901174847.97261-1-marex@nabladev.com?part=2


^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: [PATCH v3 1/2] dt-bindings: hwmon: tmp102: Fix up TMP103 bindings
  2026-09-01 17:47 [PATCH v3 1/2] dt-bindings: hwmon: tmp102: Fix up TMP103 bindings Marek Vasut
  2026-09-01 17:47 ` [PATCH v3 2/2] dt-bindings: hwmon: tmp102: Document TMP113 Marek Vasut
@ 2026-09-01 17:53 ` sashiko-bot
  2026-09-01 18:03 ` Conor Dooley
  2026-09-01 18:17 ` Guenter Roeck
  3 siblings, 0 replies; 9+ messages in thread
From: sashiko-bot @ 2026-09-01 17:53 UTC (permalink / raw)
  To: Marek Vasut; +Cc: robh, linux-hwmon, devicetree, conor+dt

> The TMP102 and TMP110 are backward compatible, therefore the valid
> compatible strings are "ti,tmp110", "ti,tmp102" and "ti,tmp102" .
> 
> The TMP103 is not backward compatible with TMP102, but it does share a
> schema now, therefore the only valid compatible string for the TMP103
> should be "ti,tmp103" .
> 
> Make exactly those three compatible strings valid and everything else
> rejected.
> 
> Fixes: d67ec24d3f07 ("dt-bindings: hwmon: tmp102: move ti,tmp103 out of trivial-devices.yaml")
> Signed-off-by: Marek Vasut <marex@nabladev.com>

Sashiko has reviewed this patch and found no issues. It looks great!

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260901174847.97261-1-marex@nabladev.com?part=1


^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: [PATCH v3 1/2] dt-bindings: hwmon: tmp102: Fix up TMP103 bindings
  2026-09-01 17:47 [PATCH v3 1/2] dt-bindings: hwmon: tmp102: Fix up TMP103 bindings Marek Vasut
  2026-09-01 17:47 ` [PATCH v3 2/2] dt-bindings: hwmon: tmp102: Document TMP113 Marek Vasut
  2026-09-01 17:53 ` [PATCH v3 1/2] dt-bindings: hwmon: tmp102: Fix up TMP103 bindings sashiko-bot
@ 2026-09-01 18:03 ` Conor Dooley
  2026-09-01 18:17 ` Guenter Roeck
  3 siblings, 0 replies; 9+ messages in thread
From: Conor Dooley @ 2026-09-01 18:03 UTC (permalink / raw)
  To: Marek Vasut
  Cc: linux-pm, Conor Dooley, Flaviu Nistor, Guenter Roeck,
	Krzysztof Kozlowski, Rob Herring, devicetree, linux-hwmon,
	linux-kernel

[-- Attachment #1: Type: text/plain, Size: 1950 bytes --]

On Tue, Sep 01, 2026 at 07:47:54PM +0200, Marek Vasut wrote:
> The TMP102 and TMP110 are backward compatible, therefore the valid
> compatible strings are "ti,tmp110", "ti,tmp102" and "ti,tmp102" .
> 
> The TMP103 is not backward compatible with TMP102, but it does share a
> schema now, therefore the only valid compatible string for the TMP103
> should be "ti,tmp103" .
> 
> Make exactly those three compatible strings valid and everything else
> rejected.
> 
> Fixes: d67ec24d3f07 ("dt-bindings: hwmon: tmp102: move ti,tmp103 out of trivial-devices.yaml")
> Signed-off-by: Marek Vasut <marex@nabladev.com>

Acked-by: Conor Dooley <conor.dooley@microchip.com>
(I am just realising now that the reason for this was the binding
in-tree having been cocked up)

> ---
> Cc: Conor Dooley <conor+dt@kernel.org>
> Cc: Flaviu Nistor <flaviu.nistor@gmail.com>
> Cc: Guenter Roeck <linux@roeck-us.net>
> Cc: Krzysztof Kozlowski <krzk+dt@kernel.org>
> Cc: Rob Herring <robh@kernel.org>
> Cc: devicetree@vger.kernel.org
> Cc: linux-hwmon@vger.kernel.org
> Cc: linux-kernel@vger.kernel.org
> ---
> V3: New patch
> ---
>  Documentation/devicetree/bindings/hwmon/ti,tmp102.yaml | 7 +++----
>  1 file changed, 3 insertions(+), 4 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/hwmon/ti,tmp102.yaml b/Documentation/devicetree/bindings/hwmon/ti,tmp102.yaml
> index 55d9f106465d7..477f478b9dd0f 100644
> --- a/Documentation/devicetree/bindings/hwmon/ti,tmp102.yaml
> +++ b/Documentation/devicetree/bindings/hwmon/ti,tmp102.yaml
> @@ -13,11 +13,10 @@ properties:
>    compatible:
>      oneOf:
>        - items:
> -          - const: ti,tmp102
> -          - const: ti,tmp103
>            - const: ti,tmp110
> -      - enum:
> -          - ti,tmp102
> +          - const: ti,tmp102
> +      - const: ti,tmp102
> +      - const: ti,tmp103
>  
>    interrupts:
>      maxItems: 1
> -- 
> 2.53.0
> 

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]

^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: [PATCH v3 2/2] dt-bindings: hwmon: tmp102: Document TMP113
  2026-09-01 17:47 ` [PATCH v3 2/2] dt-bindings: hwmon: tmp102: Document TMP113 Marek Vasut
  2026-09-01 17:53   ` sashiko-bot
@ 2026-09-01 18:03   ` Conor Dooley
  2026-09-01 18:20   ` Guenter Roeck
  2 siblings, 0 replies; 9+ messages in thread
From: Conor Dooley @ 2026-09-01 18:03 UTC (permalink / raw)
  To: Marek Vasut
  Cc: linux-pm, Conor Dooley, Flaviu Nistor, Guenter Roeck,
	Krzysztof Kozlowski, Rob Herring, devicetree, linux-hwmon,
	linux-kernel

[-- Attachment #1: Type: text/plain, Size: 2536 bytes --]

On Tue, Sep 01, 2026 at 07:47:55PM +0200, Marek Vasut wrote:
> The TMP113 temperature sensor part is register compatible with TMP102,
> document it using a fallback compatible. Unlike TMP102 and TMP110, the
> TMP113 does have additional unique ID registers, it is up to the driver
> to handle those.
> 
> Signed-off-by: Marek Vasut <marex@nabladev.com>

Acked-by: Conor Dooley <conor.dooley@microchip.com>
pw-bot: not-applicable

> ---
> Cc: Conor Dooley <conor+dt@kernel.org>
> Cc: Flaviu Nistor <flaviu.nistor@gmail.com>
> Cc: Guenter Roeck <linux@roeck-us.net>
> Cc: Krzysztof Kozlowski <krzk+dt@kernel.org>
> Cc: Rob Herring <robh@kernel.org>
> Cc: devicetree@vger.kernel.org
> Cc: linux-hwmon@vger.kernel.org
> Cc: linux-kernel@vger.kernel.org
> ---
> V2: Rebase on current next and resend, resolve a conflict with commit
>     d67ec24d3f07 ("dt-bindings: hwmon: tmp102: move ti,tmp103 out of trivial-devices.yaml")
>     Note that the TMP102,110,113 are backward compatible, therefore the
>     valid compatible strings are:
>     - "ti,tmp110", "ti,tmp102"
>     - "ti,tmp113", "ti,tmp102"
>     - "ti,tmp102"
>     The TMP103 is not backward compatible, it only shares bindings now,
>     therefore the only valid compatible string for the TMP103 should be:
>     - "ti,tmp103"
>     And that is all, no other compatible strings are acceptable here.
> V3: Rebase on top of 1/2 dt-bindings: hwmon: tmp102: Fix up TMP103 bindings
> ---
>  Documentation/devicetree/bindings/hwmon/ti,tmp102.yaml | 6 ++++--
>  1 file changed, 4 insertions(+), 2 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/hwmon/ti,tmp102.yaml b/Documentation/devicetree/bindings/hwmon/ti,tmp102.yaml
> index 477f478b9dd0f..c0b747a9ce0de 100644
> --- a/Documentation/devicetree/bindings/hwmon/ti,tmp102.yaml
> +++ b/Documentation/devicetree/bindings/hwmon/ti,tmp102.yaml
> @@ -4,7 +4,7 @@
>  $id: http://devicetree.org/schemas/hwmon/ti,tmp102.yaml#
>  $schema: http://devicetree.org/meta-schemas/core.yaml#
>  
> -title: TMP102/TMP103/TMP110 temperature sensor
> +title: TMP102/TMP103/TMP110/TMP113 temperature sensor
>  
>  maintainers:
>    - Krzysztof Kozlowski <krzk@kernel.org>
> @@ -13,7 +13,9 @@ properties:
>    compatible:
>      oneOf:
>        - items:
> -          - const: ti,tmp110
> +          - enum:
> +              - ti,tmp110
> +              - ti,tmp113
>            - const: ti,tmp102
>        - const: ti,tmp102
>        - const: ti,tmp103
> -- 
> 2.53.0
> 

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]

^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: [PATCH v3 1/2] dt-bindings: hwmon: tmp102: Fix up TMP103 bindings
  2026-09-01 17:47 [PATCH v3 1/2] dt-bindings: hwmon: tmp102: Fix up TMP103 bindings Marek Vasut
                   ` (2 preceding siblings ...)
  2026-09-01 18:03 ` Conor Dooley
@ 2026-09-01 18:17 ` Guenter Roeck
  2026-09-01 18:30   ` Marek Vasut
  3 siblings, 1 reply; 9+ messages in thread
From: Guenter Roeck @ 2026-09-01 18:17 UTC (permalink / raw)
  To: Marek Vasut
  Cc: linux-pm, Conor Dooley, Flaviu Nistor, Krzysztof Kozlowski,
	Rob Herring, devicetree, linux-hwmon, linux-kernel

On Tue, Sep 01, 2026 at 07:47:54PM +0200, Marek Vasut wrote:
> The TMP102 and TMP110 are backward compatible, therefore the valid
> compatible strings are "ti,tmp110", "ti,tmp102" and "ti,tmp102" .
> 
> The TMP103 is not backward compatible with TMP102, but it does share a
> schema now, therefore the only valid compatible string for the TMP103
> should be "ti,tmp103" .
> 
> Make exactly those three compatible strings valid and everything else
> rejected.
> 
> Fixes: d67ec24d3f07 ("dt-bindings: hwmon: tmp102: move ti,tmp103 out of trivial-devices.yaml")
> Signed-off-by: Marek Vasut <marex@nabladev.com>
> Acked-by: Conor Dooley <conor.dooley@microchip.com>

Applied (I'll squash it with d67ec24d3f07).

Thanks,
Guenter

^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: [PATCH v3 2/2] dt-bindings: hwmon: tmp102: Document TMP113
  2026-09-01 17:47 ` [PATCH v3 2/2] dt-bindings: hwmon: tmp102: Document TMP113 Marek Vasut
  2026-09-01 17:53   ` sashiko-bot
  2026-09-01 18:03   ` Conor Dooley
@ 2026-09-01 18:20   ` Guenter Roeck
  2 siblings, 0 replies; 9+ messages in thread
From: Guenter Roeck @ 2026-09-01 18:20 UTC (permalink / raw)
  To: Marek Vasut
  Cc: linux-pm, Conor Dooley, Flaviu Nistor, Krzysztof Kozlowski,
	Rob Herring, devicetree, linux-hwmon, linux-kernel

On Tue, Sep 01, 2026 at 07:47:55PM +0200, Marek Vasut wrote:
> The TMP113 temperature sensor part is register compatible with TMP102,
> document it using a fallback compatible. Unlike TMP102 and TMP110, the
> TMP113 does have additional unique ID registers, it is up to the driver
> to handle those.
> 
> Signed-off-by: Marek Vasut <marex@nabladev.com>
> Acked-by: Conor Dooley <conor.dooley@microchip.com>

Applied.

Thanks,
Guenter

^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: [PATCH v3 1/2] dt-bindings: hwmon: tmp102: Fix up TMP103 bindings
  2026-09-01 18:17 ` Guenter Roeck
@ 2026-09-01 18:30   ` Marek Vasut
  0 siblings, 0 replies; 9+ messages in thread
From: Marek Vasut @ 2026-09-01 18:30 UTC (permalink / raw)
  To: Guenter Roeck
  Cc: linux-pm, Conor Dooley, Flaviu Nistor, Krzysztof Kozlowski,
	Rob Herring, devicetree, linux-hwmon, linux-kernel

On 9/1/26 8:17 PM, Guenter Roeck wrote:
> On Tue, Sep 01, 2026 at 07:47:54PM +0200, Marek Vasut wrote:
>> The TMP102 and TMP110 are backward compatible, therefore the valid
>> compatible strings are "ti,tmp110", "ti,tmp102" and "ti,tmp102" .
>>
>> The TMP103 is not backward compatible with TMP102, but it does share a
>> schema now, therefore the only valid compatible string for the TMP103
>> should be "ti,tmp103" .
>>
>> Make exactly those three compatible strings valid and everything else
>> rejected.
>>
>> Fixes: d67ec24d3f07 ("dt-bindings: hwmon: tmp102: move ti,tmp103 out of trivial-devices.yaml")
>> Signed-off-by: Marek Vasut <marex@nabladev.com>
>> Acked-by: Conor Dooley <conor.dooley@microchip.com>
> 
> Applied (I'll squash it with d67ec24d3f07).
Thank you

^ permalink raw reply	[flat|nested] 9+ messages in thread

end of thread, other threads:[~2026-09-01 18:30 UTC | newest]

Thread overview: 9+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-09-01 17:47 [PATCH v3 1/2] dt-bindings: hwmon: tmp102: Fix up TMP103 bindings Marek Vasut
2026-09-01 17:47 ` [PATCH v3 2/2] dt-bindings: hwmon: tmp102: Document TMP113 Marek Vasut
2026-09-01 17:53   ` sashiko-bot
2026-09-01 18:03   ` Conor Dooley
2026-09-01 18:20   ` Guenter Roeck
2026-09-01 17:53 ` [PATCH v3 1/2] dt-bindings: hwmon: tmp102: Fix up TMP103 bindings sashiko-bot
2026-09-01 18:03 ` Conor Dooley
2026-09-01 18:17 ` Guenter Roeck
2026-09-01 18:30   ` Marek Vasut

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox