Re: [PATCH v2 3/3] arm64: dts: ti: k3-am62p: use ti,am62-m_can compatible for m_can devices

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] The patch introduces an undocumented device tree compatible string "ti,am62-m_can", which violates DT schema and will fail dtbs_check. Additionally, the patch lacks corresponding driver support and 'wakeup-source' properties to fulfill the claimed out-of-band wakeup functionality.
--

commit cef42e3b48831e21d6aea546d64d5e3a76c6a43c
Author: Kendall Willis <k-willis@ti.com>

arm64: dts: ti: k3-am62p: use ti,am62-m_can compatible for m_can devices

This commit prepends the "ti,am62-m_can" compatible string to the m_can
devices in the k3-am62p-j722s-common-mcu device tree. The commit message
states this allows the pins to act as a wakeup source in deep low-power
states via out-of-band wakeup capability.

> diff --git a/arch/arm64/boot/dts/ti/k3-am62p-j722s-common-mcu.dtsi b/arch/arm64/boot/dts/ti/k3-am62p-j722s-common-mcu.dtsi
> index 5288c959f3c1a..d26d6b6d0cf46 100644
> --- a/arch/arm64/boot/dts/ti/k3-am62p-j722s-common-mcu.dtsi
> +++ b/arch/arm64/boot/dts/ti/k3-am62p-j722s-common-mcu.dtsi
[ ... ]
> @@ -154,7 +154,7 @@ mcu_rti0: watchdog@4880000 {
>  	};
>  
>  	mcu_mcan0: can@4e08000 {
> -		compatible = "bosch,m_can";
> +		compatible = "ti,am62-m_can", "bosch,m_can";

[Severity: Medium]
Is this new compatible string documented in the device tree bindings?

Using an undocumented compatible string will cause make dtbs_check to fail
against the bosch,m_can schema.

Additionally, the commit message mentions this enables out-of-band wakeup
functionality, but the standard wakeup-source property doesn't seem to be
added to this node. Without the wakeup-source property or driver-side
configuration for this specific compatible, will the Linux PM framework
actually arm the device for wakeup during system suspend?

>  		reg = <0x00 0x4e08000 0x00 0x200>,
>  		      <0x00 0x4e00000 0x00 0x8000>;
[ ... ]
> @@ -169,7 +169,7 @@ mcu_mcan0: can@4e08000 {
>  	};
>  
>  	mcu_mcan1: can@4e18000 {
> -		compatible = "bosch,m_can";
> +		compatible = "ti,am62-m_can", "bosch,m_can";

[Severity: Medium]
Similar to mcu_mcan0 above, does this node also need the wakeup-source
property to function as a wakeup source, and does the driver currently
support the ti,am62-m_can compatible string?

>  		reg = <0x00 0x4e18000 0x00 0x200>,
>  		      <0x00 0x4e10000 0x00 0x8000>;

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260902-smth-v2-0-b3678ca44c7b@ti.com?part=3