From: sashiko-bot@kernel.org
To: "Kendall Willis" <k-willis@ti.com>
Cc: conor+dt@kernel.org, devicetree@vger.kernel.org, robh@kernel.org
Subject: Re: [PATCH v2 2/3] arm64: dts: ti: k3-am62a: use ti,am62-m_can compatible for m_can devices
Date: Wed, 02 Sep 2026 21:16:55 +0000 [thread overview]
Message-ID: <20260902211656.38F091F000E9@smtp.kernel.org> (raw)
In-Reply-To: <20260902-smth-v2-2-b3678ca44c7b@ti.com>
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] The patch introduces a new compatible string 'ti,am62-m_can' without updating the corresponding device tree binding schema, and lacks the kernel driver support and devicetree properties needed to implement the claimed out-of-band wakeup functionality.
--
commit 71acd1ade37c4bc66e5c6dc0a75ca7bcf4cda1e9
Author: Kendall Willis <k-willis@ti.com>
arm64: dts: ti: k3-am62a: use ti,am62-m_can compatible for m_can devices
This commit prepends the "ti,am62-m_can" compatible string to the m_can
devices in the k3-am62a-mcu device tree to enable out-of-band wakeup
functionality.
> diff --git a/arch/arm64/boot/dts/ti/k3-am62a-mcu.dtsi b/arch/arm64/boot/dts/ti/k3-am62a-mcu.dtsi
> index d22caa7c346b3..7026c15ef8e3d 100644
> --- a/arch/arm64/boot/dts/ti/k3-am62a-mcu.dtsi
> +++ b/arch/arm64/boot/dts/ti/k3-am62a-mcu.dtsi
> @@ -152,7 +152,7 @@ mcu_rti0: watchdog@4880000 {
> };
>
> mcu_mcan0: can@4e08000 {
> - compatible = "bosch,m_can";
> + compatible = "ti,am62-m_can", "bosch,m_can";
[Severity: Medium]
Does this new compatible string violate the existing device tree binding schema?
The devicetree bindings in Documentation/devicetree/bindings/net/can/bosch,m_can.yaml
currently require const: bosch,m_can, so adding ti,am62-m_can here causes a
failure when running make dtbs_check.
Additionally, the commit message claims this introduces out-of-band wakeup
functionality, but is the driver support for this compatible string missing
from the kernel? It appears the necessary devicetree properties (like
wakeup-source) and the driver implementation to back this capability are
absent from this patch series.
--
Sashiko AI review · https://sashiko.dev/#/patchset/20260902-smth-v2-0-b3678ca44c7b@ti.com?part=2
next prev parent reply other threads:[~2026-09-02 21:16 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-02 21:04 [PATCH v2 0/3] arm64: dts: ti: use ti,am62-m_can compatible for m_can devices Kendall Willis
2026-09-02 21:04 ` [PATCH v2 1/3] arm64: dts: ti: k3-am62: " Kendall Willis
2026-09-02 21:16 ` sashiko-bot
2026-09-02 21:04 ` [PATCH v2 2/3] arm64: dts: ti: k3-am62a: " Kendall Willis
2026-09-02 21:16 ` sashiko-bot [this message]
2026-09-02 21:04 ` [PATCH v2 3/3] arm64: dts: ti: k3-am62p: " Kendall Willis
2026-09-02 21:13 ` sashiko-bot
2026-09-04 14:09 ` Kumar, Udit
2026-09-04 14:59 ` Kendall Willis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260902211656.38F091F000E9@smtp.kernel.org \
--to=sashiko-bot@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=k-willis@ti.com \
--cc=robh@kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox